Add breaking change attributes for upcoming cmdlet changes #11207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Overlooked a breaking change attribute for parameter types in my previous PR. Correcting it here. This is the breaking change PR: #11184 (comment) |
pilor
reviewed
Feb 27, 2020
| @@ -75,6 +75,7 @@ public class NewAzurePolicyAssignmentCmdlet : PolicyCmdletBase, IDynamicParamete | |||
| /// <summary> | |||
| /// Gets or sets the policy assignment policy definition parameter. | |||
| /// </summary> | |||
| [CmdletParameterBreakingChange("PolicyDefinition", OldParamaterType = typeof(PSObject), NewParameterTypeName = "PsPolicyDefinition")] | |||
There was a problem hiding this comment.
these are the only places that the cmdlets take in policy entities?
There was a problem hiding this comment.
Yes, it's the only place the current ones do, hence the only break. The new ones take policy entities in new InputObject parameters.
pilor
approved these changes
Feb 27, 2020
wyunchi-ms
approved these changes
Feb 28, 2020
dingmeng-xue
pushed a commit
to dingmeng-xue/azure-powershell
that referenced
this pull request
Mar 29, 2020
Add breaking change attributes for upcoming cmdlet changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
CONTRIBUTING.mdChangeLog.mdfile(s) has been updated:ChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader -- no new version header should be added