Adding new optional parameter to specify dns servers for Virtual Wan P2SVpnGateway and P2SClients #12006
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…P2SVpnGateway and P2SClients
|
Related PowerShell command let command let review :- Azure/azure-powershell-cmdlet-review-pr#585 is approved. ToDo:- Need to add recorded test session file. |
VeryEarly
approved these changes
May 29, 2020
VeryEarly
reviewed
May 29, 2020
| @@ -119,11 +120,24 @@ Accept pipeline input: False | |||
| Accept wildcard characters: False | |||
| ``` | |||
|
|
|||
| ### -CustomDnsServer | |||
| The list of Custom Dns Servers.```yaml | |||
There was a problem hiding this comment.
please move ```yaml to next line
VeryEarly
reviewed
May 29, 2020
| @@ -135,11 +141,24 @@ Accept pipeline input: False | |||
| Accept wildcard characters: False | |||
| ``` | |||
|
|
|||
| ### -CustomDnsServer | |||
| The list of Custom Dns Servers.```yaml | |||
There was a problem hiding this comment.
please move ```yaml to next line
|
@VeryEarly Incorporated code review comments and added test record. Can we merge the PR? Thanks! |
Please take a look and let me know if merge is fine. Thanks! |
VeryEarly
approved these changes
Jun 1, 2020
shyamshd
pushed a commit
to shyamshd/azure-powershell
that referenced
this pull request
Jun 12, 2020
…P2SVpnGateway and P2SClients (Azure#12006) * Adding new optional parameter to specify dns servers for Virtual Wan-P2SVpnGateway and P2SClients * Incorporate code review comments and added test record * Suppress warnings * Suppress cred scan errors
VeryEarly
added a commit
that referenced
this pull request
Jun 16, 2020
* PR: LoadBalancerBackendAddressPool powershell Cmdlets (#11734) * lb backend address pool create/update/delete operations * adding tests with draft * making some updates for design review PR to powershell team * adding .md files * -adding tests -updating help files -addressing feedback * pulling in sdk changes for network-may branch for validation errors * Addressing comments and updating output format for PsLoadBalancerBackendAddress * updating .md files and making final changes Co-authored-by: Ali Egal <[email protected]> * Adding new optional parameter to specify dns servers for Virtual Wan P2SVpnGateway and P2SClients (#12006) * Adding new optional parameter to specify dns servers for Virtual Wan-P2SVpnGateway and P2SClients * Incorporate code review comments and added test record * Suppress warnings * Suppress cred scan errors * updating help files examples (#12068) Co-authored-by: Ali Egal <[email protected]> * multipip changes * Do not pass new fields with default values unless configured explicitly (#12076) * multi pip changes * ps tests * generating help files * help files changes * help file * regenerating help files * updated markdown file * renaming the cmdlets * name change * tests * renaming a help file * updating the recordings * test * Used signed Network SDK with API version 2020-05-01 (#12100) * Network SDK for 2020-05-01 * Fixes for FirewallPolicy * Recs * Recs * SDK package * Ignore Network API version in Batch tests * CredScan suppression * clean up * updatid recordings * clean up * clean up * Vpn gateway commandlet update (#12108) * commit1 * commit2 * Fix1 Co-authored-by: Khushboo Baheti <[email protected]> * addressing comments * added exceptions * correcting the exceptions * Change RuleGroup, RuleCollectionGroup, and RuleType and add support for Multiple DNAT Rule Collections (#12095) * Change RuleGroup and RuleCollectionGroup based on swagger change. Also, add support for NAT Rule Collections containing multiple NAT Rule Collections * PR Comments * Updated the SDK * StaticAnalysis * Previous changes got removed in rebase * update to vnet reference id only * Use Network SDK from NuGet (#12114) * Use Network SDK from NuGet * Additional mappings * Firewall Policy ThreatIntelWhitelist (#12078) * ti whitelist changes * build fix * help files * added examples for help files * adding the online version * recordings done * changed to markdown files * fixed statis analysis * added exception for static analysis * addressing comments * updated recordings * new recordings * updating due to validation error on CICD pipeline * refreshing test files, updating to remove id from variable to fix casting error * DNS Proxy in Firewall Policy (#12120) * merge conflict * fixes * tejas review Co-authored-by: Ishani Gupta <[email protected]> * Add support for IPGroups in Firewall Policy Rules (#12118) * Add support for IPGroups in Firewall Policy Rules * Pr Comments * Resolved merge conflicts * Update ChangeLog.md * Update ChangeLog.md Co-authored-by: Yabo Hu <[email protected]> * Application Gateway Private Link Cmdlets (#12133) * Application Gateway Private Link Cmdlets * add change log * Add new cmdlet Reset-AzHubRouter (#12094) * add routing state and expose reset-hubrouter * update help * updated * Update ChangeLog.md * update help file name * export cmdlet * update test * fix * update md file * update tests * updated help * Update Reset-AzHubRouter.md * test recorded Co-authored-by: Yabo Hu <[email protected]> * Fixes after merge * Revert HPCCache.Test.csproj Co-authored-by: aegal <[email protected]> Co-authored-by: Ali Egal <[email protected]> Co-authored-by: Nilambari <[email protected]> Co-authored-by: Sai Mankala <[email protected]> Co-authored-by: tejasshah7 <[email protected]> Co-authored-by: Khushboo Baheti <[email protected]> Co-authored-by: Khushboo Baheti <[email protected]> Co-authored-by: Ishani Gupta <[email protected]> Co-authored-by: Ishani Gupta <[email protected]> Co-authored-by: Yabo Hu <[email protected]> Co-authored-by: jaishals <[email protected]> Co-authored-by: Ritvika Reddy Nagula <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, with VirtualWan-P2SVpnGateway creation, there is no way for customers to specify custom dns servers which they are planning to use. Once, customer can specify custom dns servers, it will get set on gateway(HubVNet) and will be passed to customer Point to site clients as well. So, Point to site clients can also use their dns server/s instead of azure dns. This feature is asked by many customers till now and we have helped them with updating it at backend till this feature releases in PowerShell and customer can add custom dns servers themselves.
Checklist
CONTRIBUTING.mdChangeLog.mdfile(s) has been updated:ChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader -- no new version header should be added