Skip to content

Add support for IPGroups in Firewall Policy Rules #12118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 12, 2020
Merged

Add support for IPGroups in Firewall Policy Rules #12118

merged 5 commits into from
Jun 12, 2020

Conversation

tejasshah7
Copy link
Contributor

Description

This change adds support for IPGroups in Firewall Policy Application, Network and NAT rules. Here is the commandlet review PR: https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/606

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • [ x The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@tejasshah7 tejasshah7 requested a review from anton-evseev as a code owner June 11, 2020 00:18
@adxsdkps
Copy link
Collaborator

Can one of the admins verify this patch?

@VeryEarly
Copy link
Collaborator

/azp run

@VeryEarly VeryEarly self-assigned this Jun 11, 2020
@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

VeryEarly
VeryEarly reviewed Jun 11, 2020
View reviewed changes
VeryEarly
VeryEarly reviewed Jun 11, 2020
View reviewed changes
VeryEarly
VeryEarly reviewed Jun 11, 2020
View reviewed changes
@VeryEarly
Copy link
Collaborator

please also resolve the merge conflicts

@tejasshah7 tejasshah7 force-pushed the tesha/AddIpGroupsOnFirewallPolicy branch from 37a51c9 to ecb3d43 Compare June 11, 2020 14:15
@tejasshah7
Copy link
Contributor Author

please also resolve the merge conflicts

Done

@anton-evseev
Copy link
Contributor

@VeryEarly please merge if everything's okay

@tejasshah7 tejasshah7 force-pushed the tesha/AddIpGroupsOnFirewallPolicy branch from ecb3d43 to 5d03daa Compare June 12, 2020 03:08
@VeryEarly
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@VeryEarly VeryEarly merged commit 82068e2 into Azure:network-may Jun 12, 2020
VeryEarly added a commit that referenced this pull request Jun 16, 2020
@anton-evseev @aegal
@Nilambari @saisujithreddym @tejasshah7 @Khushboo-Baheti @ishaniGupta27 @VeryEarly @jaishals @nagula-ritvika
Network May release (#12157)
4697bbe 
* PR: LoadBalancerBackendAddressPool powershell Cmdlets (#11734)

* lb backend address pool create/update/delete operations

* adding tests with draft

* making some updates for design review PR to powershell team

* adding .md files

* -adding tests
-updating help files
-addressing feedback

* pulling in sdk changes for network-may branch for validation errors

* Addressing comments and updating output format for PsLoadBalancerBackendAddress

* updating .md files and making final changes

Co-authored-by: Ali Egal <[email protected]>

* Adding new optional parameter to specify dns servers for Virtual Wan P2SVpnGateway and P2SClients (#12006)

* Adding new optional parameter to specify dns servers for Virtual Wan-P2SVpnGateway and P2SClients

* Incorporate code review comments and added test record

* Suppress warnings

* Suppress cred scan errors

* updating help files examples (#12068)

Co-authored-by: Ali Egal <[email protected]>

* multipip changes

* Do not pass new fields with default values unless configured explicitly (#12076)

* multi pip changes

* ps tests

* generating help files

* help files changes

* help file

* regenerating help files

* updated markdown file

* renaming the cmdlets

* name change

* tests

* renaming a help file

* updating the recordings

* test

* Used signed Network SDK with API version 2020-05-01 (#12100)

* Network SDK for 2020-05-01

* Fixes for FirewallPolicy

* Recs

* Recs

* SDK package

* Ignore Network API version in Batch tests

* CredScan suppression

* clean up

* updatid recordings

* clean up

* clean up

* Vpn gateway commandlet update (#12108)

* commit1

* commit2

* Fix1

Co-authored-by: Khushboo Baheti <[email protected]>

* addressing comments

* added exceptions

* correcting the exceptions

* Change RuleGroup, RuleCollectionGroup, and RuleType and add support for Multiple DNAT Rule Collections (#12095)

* Change RuleGroup and RuleCollectionGroup based on swagger change. Also,
add support for NAT Rule Collections containing multiple NAT Rule
Collections

* PR Comments

* Updated the SDK

* StaticAnalysis

* Previous changes got removed in rebase

* update to vnet reference id only

* Use Network SDK from NuGet (#12114)

* Use Network SDK from NuGet

* Additional mappings

* Firewall Policy ThreatIntelWhitelist (#12078)

* ti whitelist changes

* build fix

* help files

* added examples for help files

* adding the online version

* recordings done

* changed to markdown files

* fixed statis analysis

* added exception for static analysis

* addressing comments

* updated recordings

* new recordings

* updating due to validation error on CICD pipeline

* refreshing test files, updating to remove id from variable to fix casting error

* DNS Proxy in Firewall Policy (#12120)

* merge conflict

* fixes

* tejas review

Co-authored-by: Ishani Gupta <[email protected]>

* Add support for IPGroups in Firewall Policy Rules (#12118)

* Add support for IPGroups in Firewall Policy Rules

* Pr Comments

* Resolved merge conflicts

* Update ChangeLog.md

* Update ChangeLog.md

Co-authored-by: Yabo Hu <[email protected]>

* Application Gateway Private Link Cmdlets (#12133)

* Application Gateway Private Link Cmdlets

* add change log

* Add new cmdlet Reset-AzHubRouter (#12094)

* add routing state and expose reset-hubrouter

* update help

* updated

* Update ChangeLog.md

* update help file name

* export cmdlet

* update test

* fix

* update md file

* update tests

* updated help

* Update Reset-AzHubRouter.md

* test recorded

Co-authored-by: Yabo Hu <[email protected]>

* Fixes after merge

* Revert HPCCache.Test.csproj

Co-authored-by: aegal <[email protected]>
Co-authored-by: Ali Egal <[email protected]>
Co-authored-by: Nilambari <[email protected]>
Co-authored-by: Sai Mankala <[email protected]>
Co-authored-by: tejasshah7 <[email protected]>
Co-authored-by: Khushboo Baheti <[email protected]>
Co-authored-by: Khushboo Baheti <[email protected]>
Co-authored-by: Ishani Gupta <[email protected]>
Co-authored-by: Ishani Gupta <[email protected]>
Co-authored-by: Yabo Hu <[email protected]>
Co-authored-by: jaishals <[email protected]>
Co-authored-by: Ritvika Reddy Nagula <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anton-evseev anton-evseev anton-evseev approved these changes

@VeryEarly VeryEarly VeryEarly approved these changes

Assignees

@VeryEarly VeryEarly

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tejasshah7 @adxsdkps @VeryEarly @anton-evseev