Skip to content

[Synapse] Add access control cmdlets #12309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 3, 2020
Merged

[Synapse] Add access control cmdlets #12309

merged 3 commits into from
Jul 3, 2020

Conversation

wonner
Copy link
Contributor

@wonner wonner commented Jul 2, 2020

Description

This change add access control cmdlets. Here is the commandlet review PR:https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/652

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@wonner wonner requested a review from idear1203 July 2, 2020 10:36
@adxsdkps
Copy link
Collaborator

adxsdkps commented Jul 2, 2020

Can one of the admins verify this patch?

@idear1203
Copy link
Contributor 

           'Azure.Analytics.Synapse.Spark.dll'

Add 'Azure.Analytics.Synapse.AccessControl.dll' here

Refers to: src/Synapse/Synapse/Az.Synapse.psd1:60 in 96b6d6f. [](commit_id = 96b6d6f, deletion_comment = False)

aim-for-better
aim-for-better reviewed Jul 2, 2020
View reviewed changes
@VeryEarly VeryEarly self-assigned this Jul 3, 2020
@VeryEarly VeryEarly merged commit 06b4238 into Azure:master Jul 3, 2020
litchiyangMSFT pushed a commit to litchiyangMSFT/azure-powershell that referenced this pull request Aug 4, 2020
@wonner @litchiyangMSFT
[Synapse] Add access control cmdlets (Azure#12309)
05abc7c 
* add support for access control

* fix RequiredAssemblies

Co-authored-by: Wan Yang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aim-for-better aim-for-better aim-for-better left review comments

@VeryEarly VeryEarly VeryEarly approved these changes

@idear1203 idear1203 Awaiting requested review from idear1203

Assignees

@VeryEarly VeryEarly

Labels
needs-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@wonner @adxsdkps @idear1203 @aim-for-better @VeryEarly @azuresdkci