-
Notifications
You must be signed in to change notification settings - Fork 4k
[Synapse] Add access control cmdlets #12309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
154 changes: 154 additions & 0 deletions
154
...Synapse/Synapse/Commands/DataPlaneCommands/AccessControl/GetAzureSynapseRoleAssignment.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,154 @@ | ||
using Azure.Analytics.Synapse.AccessControl; | ||
using Microsoft.Azure.Commands.ResourceManager.Common.ArgumentCompleters; | ||
using Microsoft.Azure.Commands.Synapse.Common; | ||
using Microsoft.Azure.Commands.Synapse.Models; | ||
using Microsoft.WindowsAzure.Commands.Utilities.Common; | ||
using System; | ||
using System.Collections.Generic; | ||
using System.Linq; | ||
using System.Management.Automation; | ||
using System.Text; | ||
|
||
namespace Microsoft.Azure.Commands.Synapse | ||
{ | ||
[Cmdlet(VerbsCommon.Get, ResourceManager.Common.AzureRMConstants.AzureRMPrefix + SynapseConstants.SynapsePrefix + SynapseConstants.RoleAssignment, | ||
DefaultParameterSetName = GetByWorkspaceNameAndNameParameterSet)] | ||
[OutputType(typeof(PSRoleAssignmentDetails))] | ||
public class GetAzureSynapseRoleAssignment : SynapseRoleCmdletBase | ||
{ | ||
private const string GetByWorkspaceNameAndNameParameterSet = "GetByWorkspaceNameAndNameParameterSet"; | ||
private const string GetByWorkspaceNameAndIdParameterSet = "GetByWorkspaceNameAndIdParameterSet"; | ||
private const string GetByWorkspaceObjectAndNameParameterSet = "GetByWorkspaceObjectAndNameParameterSet"; | ||
private const string GetByWorkspaceObjectAndIdParameterSet = "GetByWorkspaceObjectAndIdParameterSet"; | ||
private const string GetByWorkspaceNameAndRoleDefinitionIdAndObjectIdParameterSet = "GetByWorkspaceNameAndRoleDefinitionIdAndObjectIdParameterSet"; | ||
private const string GetByWorkspaceObjectAndRoleDefinitionIdAndObjectIdParameterSet = "GetByWorkspaceObjectAndRoleDefinitionIdAndObjectIdParameterSet"; | ||
private const string GetByWorkspaceNameAndAssignmentIdParameterSet = "GetByWorkspaceNameAndAssignmentIdParameterSet"; | ||
private const string GetByWorkspaceObjectAndAssignmentIdParameterSet = "GetByWorkspaceObjectAndAssignmentIdParameterSet"; | ||
private const string GetByWorkspaceNameAndServicePrincipalNameParameterSet = "GetByWorkspaceNameAndServicePrincipalNameParameterSet"; | ||
private const string GetByWorkspaceObjectAndServicePrincipalNameParameterSet = "GetByWorkspaceObjectAndServicePrincipalNameParameterSet"; | ||
|
||
[Parameter(ValueFromPipelineByPropertyName = false, ParameterSetName = GetByWorkspaceNameAndNameParameterSet, | ||
Mandatory = true, HelpMessage = HelpMessages.WorkspaceName)] | ||
[Parameter(ValueFromPipelineByPropertyName = false, ParameterSetName = GetByWorkspaceNameAndIdParameterSet, | ||
Mandatory = true, HelpMessage = HelpMessages.WorkspaceName)] | ||
[Parameter(ValueFromPipelineByPropertyName = false, ParameterSetName = GetByWorkspaceNameAndRoleDefinitionIdAndObjectIdParameterSet, | ||
Mandatory = true, HelpMessage = HelpMessages.WorkspaceName)] | ||
[Parameter(ValueFromPipelineByPropertyName = false, ParameterSetName = GetByWorkspaceNameAndAssignmentIdParameterSet, | ||
Mandatory = true, HelpMessage = HelpMessages.WorkspaceName)] | ||
[Parameter(ValueFromPipelineByPropertyName = false, ParameterSetName = GetByWorkspaceNameAndServicePrincipalNameParameterSet, | ||
Mandatory = true, HelpMessage = HelpMessages.WorkspaceName)] | ||
[ResourceNameCompleter(ResourceTypes.Workspace, "ResourceGroupName")] | ||
[ValidateNotNullOrEmpty] | ||
public override string WorkspaceName { get; set; } | ||
|
||
[Parameter(ValueFromPipeline = true, ParameterSetName = GetByWorkspaceObjectAndNameParameterSet, | ||
Mandatory = true, HelpMessage = HelpMessages.WorkspaceObject)] | ||
[Parameter(ValueFromPipeline = true, ParameterSetName = GetByWorkspaceObjectAndIdParameterSet, | ||
Mandatory = true, HelpMessage = HelpMessages.WorkspaceObject)] | ||
[Parameter(ValueFromPipeline = true, ParameterSetName = GetByWorkspaceObjectAndRoleDefinitionIdAndObjectIdParameterSet, | ||
Mandatory = true, HelpMessage = HelpMessages.WorkspaceObject)] | ||
[Parameter(ValueFromPipeline = true, ParameterSetName = GetByWorkspaceObjectAndAssignmentIdParameterSet, | ||
Mandatory = true, HelpMessage = HelpMessages.WorkspaceObject)] | ||
[Parameter(ValueFromPipeline = true, ParameterSetName = GetByWorkspaceObjectAndServicePrincipalNameParameterSet, | ||
Mandatory = true, HelpMessage = HelpMessages.WorkspaceObject)] | ||
[ValidateNotNull] | ||
public PSSynapseWorkspace WorkspaceObject { get; set; } | ||
|
||
[Parameter(ValueFromPipelineByPropertyName = false, ParameterSetName = GetByWorkspaceNameAndAssignmentIdParameterSet, | ||
Mandatory = true, HelpMessage = HelpMessages.RoleAssignmentId)] | ||
[Parameter(ValueFromPipelineByPropertyName = false, ParameterSetName = GetByWorkspaceObjectAndAssignmentIdParameterSet, | ||
Mandatory = true, HelpMessage = HelpMessages.RoleAssignmentId)] | ||
[ValidateNotNullOrEmpty] | ||
public string RoleAssignmentId { get; set; } | ||
|
||
[Parameter(ValueFromPipelineByPropertyName = false, ParameterSetName = GetByWorkspaceNameAndNameParameterSet, | ||
Mandatory = false, HelpMessage = HelpMessages.RoleDefinitionName)] | ||
[Parameter(ValueFromPipelineByPropertyName = false, ParameterSetName = GetByWorkspaceNameAndIdParameterSet, | ||
Mandatory = false, HelpMessage = HelpMessages.RoleDefinitionName)] | ||
[Parameter(ValueFromPipelineByPropertyName = false, ParameterSetName = GetByWorkspaceObjectAndNameParameterSet, | ||
Mandatory = false, HelpMessage = HelpMessages.RoleDefinitionName)] | ||
[Parameter(ValueFromPipelineByPropertyName = false, ParameterSetName = GetByWorkspaceObjectAndIdParameterSet, | ||
Mandatory = false, HelpMessage = HelpMessages.RoleDefinitionName)] | ||
[Parameter(ValueFromPipelineByPropertyName = false, ParameterSetName = GetByWorkspaceNameAndServicePrincipalNameParameterSet, | ||
Mandatory = false, HelpMessage = HelpMessages.RoleDefinitionName)] | ||
[Parameter(ValueFromPipelineByPropertyName = false, ParameterSetName = GetByWorkspaceObjectAndServicePrincipalNameParameterSet, | ||
Mandatory = false, HelpMessage = HelpMessages.RoleDefinitionName)] | ||
[ValidateNotNullOrEmpty] | ||
public string RoleDefinitionName { get; set; } | ||
|
||
[Parameter(ValueFromPipelineByPropertyName = false, ParameterSetName = GetByWorkspaceNameAndRoleDefinitionIdAndObjectIdParameterSet, | ||
Mandatory = true, HelpMessage = HelpMessages.RoleDefinitionId)] | ||
[Parameter(ValueFromPipelineByPropertyName = false, ParameterSetName = GetByWorkspaceObjectAndRoleDefinitionIdAndObjectIdParameterSet, | ||
Mandatory = true, HelpMessage = HelpMessages.RoleDefinitionId)] | ||
[ValidateNotNullOrEmpty] | ||
public string RoleDefinitionId { get; set; } | ||
|
||
[Parameter(ValueFromPipelineByPropertyName = false, ParameterSetName = GetByWorkspaceNameAndNameParameterSet, | ||
Mandatory = false, HelpMessage = HelpMessages.SignInName)] | ||
[Parameter(ValueFromPipelineByPropertyName = false, ParameterSetName = GetByWorkspaceObjectAndNameParameterSet, | ||
Mandatory = true, HelpMessage = HelpMessages.SignInName)] | ||
[Alias("Email", "UserPrincipalName")] | ||
[ValidateNotNullOrEmpty] | ||
public string SignInName { get; set; } | ||
|
||
[Parameter(ValueFromPipelineByPropertyName = false, ParameterSetName = GetByWorkspaceNameAndServicePrincipalNameParameterSet, | ||
Mandatory = false, HelpMessage = HelpMessages.ServicePrincipalName)] | ||
[Parameter(ValueFromPipelineByPropertyName = false, ParameterSetName = GetByWorkspaceObjectAndServicePrincipalNameParameterSet, | ||
Mandatory = true, HelpMessage = HelpMessages.ServicePrincipalName)] | ||
[ValidateNotNullOrEmpty] | ||
public string ServicePrincipalName { get; set; } | ||
|
||
[Parameter(ValueFromPipelineByPropertyName = false, ParameterSetName = GetByWorkspaceNameAndIdParameterSet, | ||
Mandatory = false, HelpMessage = HelpMessages.PrincipalId)] | ||
[Parameter(ValueFromPipelineByPropertyName = false, ParameterSetName = GetByWorkspaceObjectAndIdParameterSet, | ||
Mandatory = false, HelpMessage = HelpMessages.PrincipalId)] | ||
[Parameter(ValueFromPipelineByPropertyName = false, ParameterSetName = GetByWorkspaceNameAndRoleDefinitionIdAndObjectIdParameterSet, | ||
Mandatory = false, HelpMessage = HelpMessages.PrincipalId)] | ||
[Parameter(ValueFromPipelineByPropertyName = false, ParameterSetName = GetByWorkspaceObjectAndRoleDefinitionIdAndObjectIdParameterSet, | ||
Mandatory = false, HelpMessage = HelpMessages.PrincipalId)] | ||
[Alias("Id", "PrincipalId")] | ||
[ValidateNotNullOrEmpty] | ||
public string ObjectId { get; set; } | ||
|
||
public override void ExecuteCmdlet() | ||
{ | ||
if (this.IsParameterBound(c => c.WorkspaceObject)) | ||
{ | ||
this.WorkspaceName = this.WorkspaceObject.Name; | ||
} | ||
|
||
if (this.IsParameterBound(c => c.RoleDefinitionName)) | ||
{ | ||
this.RoleDefinitionId = SynapseAnalyticsClient.GetRoleDefinitionIdFromRoleDefinitionName(this.RoleDefinitionName); | ||
} | ||
|
||
if (this.IsParameterBound(c => c.SignInName)) | ||
{ | ||
this.ObjectId = SynapseAnalyticsClient.GetObjectIdFromSignInName(this.SignInName); | ||
} | ||
|
||
if (this.IsParameterBound(c => c.ServicePrincipalName)) | ||
idear1203 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
{ | ||
this.ObjectId = SynapseAnalyticsClient.GetObjectIdFromServicePrincipalName(this.ServicePrincipalName); | ||
} | ||
|
||
if (this.IsParameterBound(c => c.RoleAssignmentId)) | ||
{ | ||
WriteObject(new PSRoleAssignmentDetails(SynapseAnalyticsClient.GetRoleAssignmentById(this.RoleAssignmentId))); | ||
idear1203 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
} | ||
else | ||
{ | ||
var roleAssignment = SynapseAnalyticsClient.ListRoleAssignments(this.RoleDefinitionId, this.ObjectId) | ||
.Select(element => new PSRoleAssignmentDetails(element)); | ||
|
||
// TODO: Currently, when only `ObjectId` is specified, the cmdlet returns incorrect result. Filter from client side as a workaround | ||
if (!string.IsNullOrEmpty(this.ObjectId)) | ||
{ | ||
roleAssignment = roleAssignment.Where(element => element.ObjectId == this.ObjectId); | ||
} | ||
|
||
WriteObject(roleAssignment, true); | ||
} | ||
} | ||
} | ||
} |
85 changes: 85 additions & 0 deletions
85
...Synapse/Synapse/Commands/DataPlaneCommands/AccessControl/GetAzureSynapseRoleDefinition.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,85 @@ | ||
using Azure.Analytics.Synapse.AccessControl.Models; | ||
using Microsoft.Azure.Commands.ResourceManager.Common.ArgumentCompleters; | ||
using Microsoft.Azure.Commands.Synapse.Common; | ||
using Microsoft.Azure.Commands.Synapse.Models; | ||
using Microsoft.Azure.Commands.Synapse.Properties; | ||
using Microsoft.WindowsAzure.Commands.Utilities.Common; | ||
using System; | ||
using System.Collections.Generic; | ||
using System.Linq; | ||
using System.Management.Automation; | ||
using System.Text; | ||
|
||
namespace Microsoft.Azure.Commands.Synapse | ||
{ | ||
[Cmdlet(VerbsCommon.Get, ResourceManager.Common.AzureRMConstants.AzureRMPrefix + SynapseConstants.SynapsePrefix + SynapseConstants.RoleDefinition, | ||
DefaultParameterSetName = GetByWorkspaceNameAndIdParameterSet)] | ||
[OutputType(typeof(PSSynapseRole))] | ||
public class GetAzureSynapseRoleDefinition : SynapseRoleCmdletBase | ||
{ | ||
private const string GetByWorkspaceNameAndIdParameterSet = "GetByWorkspaceNameAndIdParameterSet"; | ||
private const string GetByWorkspaceObjectAndIdParameterSet = "GetByWorkspaceObjectAndIdParameterSet"; | ||
private const string GetByWorkspaceNameAndNameParameterSet = "GetByWorkspaceNameAndNameParameterSet"; | ||
private const string GetByWorkspaceObjectAndNameParameterSet = "GetByWorkspaceObjectAndNameParameterSet"; | ||
|
||
[Parameter(ValueFromPipelineByPropertyName = false, ParameterSetName = GetByWorkspaceNameAndIdParameterSet, | ||
Mandatory = true, HelpMessage = HelpMessages.WorkspaceName)] | ||
[Parameter(ValueFromPipelineByPropertyName = false, ParameterSetName = GetByWorkspaceNameAndNameParameterSet, | ||
Mandatory = true, HelpMessage = HelpMessages.WorkspaceName)] | ||
[ResourceNameCompleter(ResourceTypes.Workspace, "ResourceGroupName")] | ||
[ValidateNotNullOrEmpty] | ||
public override string WorkspaceName { get; set; } | ||
|
||
[Parameter(ValueFromPipeline = true, ParameterSetName = GetByWorkspaceObjectAndIdParameterSet, | ||
Mandatory = true, HelpMessage = HelpMessages.WorkspaceObject)] | ||
[Parameter(ValueFromPipeline = true, ParameterSetName = GetByWorkspaceObjectAndNameParameterSet, | ||
Mandatory = true, HelpMessage = HelpMessages.WorkspaceObject)] | ||
[ValidateNotNull] | ||
public PSSynapseWorkspace WorkspaceObject { get; set; } | ||
|
||
[Parameter(ValueFromPipelineByPropertyName = false, ParameterSetName = GetByWorkspaceNameAndIdParameterSet, | ||
Mandatory = false, HelpMessage = HelpMessages.RoleDefinitionId)] | ||
[Parameter(ValueFromPipelineByPropertyName = false, ParameterSetName = GetByWorkspaceObjectAndIdParameterSet, | ||
Mandatory = true, HelpMessage = HelpMessages.RoleDefinitionId)] | ||
[ValidateNotNullOrEmpty] | ||
public string Id { get; set; } | ||
|
||
[Parameter(ValueFromPipelineByPropertyName = false, ParameterSetName = GetByWorkspaceNameAndNameParameterSet, | ||
Mandatory = false, HelpMessage = HelpMessages.RoleDefinitionName)] | ||
[Parameter(ValueFromPipelineByPropertyName = false, ParameterSetName = GetByWorkspaceObjectAndNameParameterSet, | ||
Mandatory = false, HelpMessage = HelpMessages.RoleDefinitionName)] | ||
[ValidateNotNullOrEmpty] | ||
public string Name { get; set; } | ||
|
||
public override void ExecuteCmdlet() | ||
{ | ||
if (this.IsParameterBound(c => c.WorkspaceObject)) | ||
{ | ||
this.WorkspaceName = this.WorkspaceObject.Name; | ||
} | ||
|
||
if (this.IsParameterBound(c => c.Id)) | ||
{ | ||
WriteObject(new PSSynapseRole(SynapseAnalyticsClient.GetRoleDefinitionById(this.Id))); | ||
} | ||
else | ||
{ | ||
var roleDefinitions = SynapseAnalyticsClient.GetRoleDefinitions() | ||
.Select(element => new PSSynapseRole(element)); | ||
if (this.IsParameterBound(c => c.Name)) | ||
{ | ||
PSSynapseRole role = roleDefinitions.SingleOrDefault(element => element.Name == this.Name); | ||
if (role == null) | ||
{ | ||
throw new InvalidOperationException(String.Format(Resources.RoleDefinitionNameDoesNotExist, this.Name)); | ||
} | ||
WriteObject(role); | ||
} | ||
else | ||
{ | ||
WriteObject(roleDefinitions, true); | ||
} | ||
} | ||
} | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.