Skip to content

Updated ConnectionMonitorEndpoint cmdlet #12851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Updated ConnectionMonitorEndpoint cmdlet #12851

wants to merge 5 commits into from

Conversation

irrogozh
Copy link
Member

@irrogozh irrogozh commented Sep 4, 2020

Description

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)

Link on design spec: https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/733

- [ ] the markdown help files have been regenerated using the commands listed [here](../blob/master/documentation/development-docs/help-generation.md#updating-all-markdown-files-in-a-module)

@msJinLei
Copy link
Contributor

msJinLei commented Sep 8, 2020

@irrogozh
Have already submit a cmdlet review here?
Your PR contains a lot of breaking change, which cannot merge to master now.

  "AssemblyFileName","ClassName","Target","Severity","ProblemId","Description","Remediation"
  "Microsoft.Azure.PowerShell.Cmdlets.Network.dll","Microsoft.Azure.Commands.Network.GetAzureNetworkWatcherConnectionMonitorCommand","Get-AzNetworkWatcherConnectionMonitor","0","3010","The property 'Filter' of type 'Microsoft.Azure.Commands.Network.Models.PSNetworkWatcherConnectionMonitorEndpointObject' has been removed.","Add the property 'Filter' back to type 'Microsoft.Azure.Commands.Network.Models.PSNetworkWatcherConnectionMonitorEndpointObject'."
  "Microsoft.Azure.PowerShell.Cmdlets.Network.dll","Microsoft.Azure.Commands.Network.GetAzureNetworkWatcherConnectionMonitorCommand","Get-AzNetworkWatcherConnectionMonitor","0","3010","The property 'FilterText' of type 'Microsoft.Azure.Commands.Network.Models.PSNetworkWatcherConnectionMonitorEndpointObject' has been removed.","Add the property 'FilterText' back to type 'Microsoft.Azure.Commands.Network.Models.PSNetworkWatcherConnectionMonitorEndpointObject'."
  "Microsoft.Azure.PowerShell.Cmdlets.Network.dll","Microsoft.Azure.Commands.Network.NewAzureNetworkWatcherConnectionMonitorEndpointFilterItemObjectCommand","New-AzNetworkWatcherConnectionMonitorEndpointFilterItemObject","0","1000","The cmdlet 'New-AzNetworkWatcherConnectionMonitorEndpointFilterItemObject' has been removed and no alias was found for the original cmdlet name.","Add the cmdlet 'New-AzNetworkWatcherConnectionMonitorEndpointFilterItemObject' back to the module, or add an alias to the original cmdlet name."
  "Microsoft.Azure.PowerShell.Cmdlets.Network.dll","Microsoft.Azure.Commands.Network.NewAzureNetworkWatcherConnectionMonitorEndpointObjectCommand","New-AzNetworkWatcherConnectionMonitorEndpointObject","0","3010","The property 'Filter' of type 'Microsoft.Azure.Commands.Network.Models.PSNetworkWatcherConnectionMonitorEndpointObject' has been removed.","Add the property 'Filter' back to type 'Microsoft.Azure.Commands.Network.Models.PSNetworkWatcherConnectionMonitorEndpointObject'."
  "Microsoft.Azure.PowerShell.Cmdlets.Network.dll","Microsoft.Azure.Commands.Network.NewAzureNetworkWatcherConnectionMonitorEndpointObjectCommand","New-AzNetworkWatcherConnectionMonitorEndpointObject","0","3010","The property 'FilterText' of type 'Microsoft.Azure.Commands.Network.Models.PSNetworkWatcherConnectionMonitorEndpointObject' has been removed.","Add the property 'FilterText' back to type 'Microsoft.Azure.Commands.Network.Models.PSNetworkWatcherConnectionMonitorEndpointObject'."
  "Microsoft.Azure.PowerShell.Cmdlets.Network.dll","Microsoft.Azure.Commands.Network.NewAzureNetworkWatcherConnectionMonitorEndpointObjectCommand","New-AzNetworkWatcherConnectionMonitorEndpointObject","0","2000","The cmdlet 'New-AzNetworkWatcherConnectionMonitorEndpointObject' no longer supports the parameter 'FilterType' and no alias was found for the original parameter name.","Add the parameter 'FilterType' back to the cmdlet 'New-AzNetworkWatcherConnectionMonitorEndpointObject', or add an alias to the original parameter name."
  "Microsoft.Azure.PowerShell.Cmdlets.Network.dll","Microsoft.Azure.Commands.Network.NewAzureNetworkWatcherConnectionMonitorEndpointObjectCommand","New-AzNetworkWatcherConnectionMonitorEndpointObject","0","2000","The cmdlet 'New-AzNetworkWatcherConnectionMonitorEndpointObject' no longer supports the parameter 'FilterItem' and no alias was found for the original parameter name.","Add the parameter 'FilterItem' back to the cmdlet 'New-AzNetworkWatcherConnectionMonitorEndpointObject', or add an alias to the original parameter name."
  "Microsoft.Azure.PowerShell.Cmdlets.Network.dll","Microsoft.Azure.Commands.Network.NewAzureNetworkWatcherConnectionMonitorEndpointObjectCommand","New-AzNetworkWatcherConnectionMonitorEndpointObject","0","1050","The parameter set '__AllParameterSets' for cmdlet 'New-AzNetworkWatcherConnectionMonitorEndpointObject' has been removed.","Add parameter set '__AllParameterSets' back to cmdlet 'New-AzNetworkWatcherConnectionMonitorEndpointObject'."
  "Microsoft.Azure.PowerShell.Cmdlets.Network.dll","Microsoft.Azure.Commands.Network.NewAzureNetworkWatcherConnectionMonitorEndpointObjectCommand","New-AzNetworkWatcherConnectionMonitorEndpointObject","0","1050","The parameter set 'SetByResourceId' for cmdlet 'New-AzNetworkWatcherConnectionMonitorEndpointObject' has been removed.","Add parameter set 'SetByResourceId' back to cmdlet 'New-AzNetworkWatcherConnectionMonitorEndpointObject'."
  "Microsoft.Azure.PowerShell.Cmdlets.Network.dll","Microsoft.Azure.Commands.Network.NewAzureNetworkWatcherConnectionMonitorEndpointObjectCommand","New-AzNetworkWatcherConnectionMonitorEndpointObject","0","1050","The parameter set 'SetByAddress' for cmdlet 'New-AzNetworkWatcherConnectionMonitorEndpointObject' has been removed.","Add parameter set 'SetByAddress' back to cmdlet 'New-AzNetworkWatcherConnectionMonitorEndpointObject'."
  
  
  D:\a\1\s\artifacts//StaticAnalysisResults\BreakingChangeIssues.csv:
  "AssemblyFileName","ClassName","Target","Severity","ProblemId","Description","Remediation"
  "Microsoft.Azure.PowerShell.Cmdlets.Network.dll","Microsoft.Azure.Commands.Network.GetAzureNetworkWatcherConnectionMonitorCommand","Get-AzNetworkWatcherConnectionMonitor","0","3010","The property 'Filter' of type 'Microsoft.Azure.Commands.Network.Models.PSNetworkWatcherConnectionMonitorEndpointObject' has been removed.","Add the property 'Filter' back to type 'Microsoft.Azure.Commands.Network.Models.PSNetworkWatcherConnectionMonitorEndpointObject'."
  "Microsoft.Azure.PowerShell.Cmdlets.Network.dll","Microsoft.Azure.Commands.Network.GetAzureNetworkWatcherConnectionMonitorCommand","Get-AzNetworkWatcherConnectionMonitor","0","3010","The property 'FilterText' of type 'Microsoft.Azure.Commands.Network.Models.PSNetworkWatcherConnectionMonitorEndpointObject' has been removed.","Add the property 'FilterText' back to type 'Microsoft.Azure.Commands.Network.Models.PSNetworkWatcherConnectionMonitorEndpointObject'."
  "Microsoft.Azure.PowerShell.Cmdlets.Network.dll","Microsoft.Azure.Commands.Network.NewAzureNetworkWatcherConnectionMonitorEndpointFilterItemObjectCommand","New-AzNetworkWatcherConnectionMonitorEndpointFilterItemObject","0","1000","The cmdlet 'New-AzNetworkWatcherConnectionMonitorEndpointFilterItemObject' has been removed and no alias was found for the original cmdlet name.","Add the cmdlet 'New-AzNetworkWatcherConnectionMonitorEndpointFilterItemObject' back to the module, or add an alias to the original cmdlet name."
  "Microsoft.Azure.PowerShell.Cmdlets.Network.dll","Microsoft.Azure.Commands.Network.NewAzureNetworkWatcherConnectionMonitorEndpointObjectCommand","New-AzNetworkWatcherConnectionMonitorEndpointObject","0","3010","The property 'Filter' of type 'Microsoft.Azure.Commands.Network.Models.PSNetworkWatcherConnectionMonitorEndpointObject' has been removed.","Add the property 'Filter' back to type 'Microsoft.Azure.Commands.Network.Models.PSNetworkWatcherConnectionMonitorEndpointObject'."
  "Microsoft.Azure.PowerShell.Cmdlets.Network.dll","Microsoft.Azure.Commands.Network.NewAzureNetworkWatcherConnectionMonitorEndpointObjectCommand","New-AzNetworkWatcherConnectionMonitorEndpointObject","0","3010","The property 'FilterText' of type 'Microsoft.Azure.Commands.Network.Models.PSNetworkWatcherConnectionMonitorEndpointObject' has been removed.","Add the property 'FilterText' back to type 'Microsoft.Azure.Commands.Network.Models.PSNetworkWatcherConnectionMonitorEndpointObject'."
  "Microsoft.Azure.PowerShell.Cmdlets.Network.dll","Microsoft.Azure.Commands.Network.NewAzureNetworkWatcherConnectionMonitorEndpointObjectCommand","New-AzNetworkWatcherConnectionMonitorEndpointObject","0","2000","The cmdlet 'New-AzNetworkWatcherConnectionMonitorEndpointObject' no longer supports the parameter 'FilterType' and no alias was found for the original parameter name.","Add the parameter 'FilterType' back to the cmdlet 'New-AzNetworkWatcherConnectionMonitorEndpointObject', or add an alias to the original parameter name."
  "Microsoft.Azure.PowerShell.Cmdlets.Network.dll","Microsoft.Azure.Commands.Network.NewAzureNetworkWatcherConnectionMonitorEndpointObjectCommand","New-AzNetworkWatcherConnectionMonitorEndpointObject","0","2000","The cmdlet 'New-AzNetworkWatcherConnectionMonitorEndpointObject' no longer supports the parameter 'FilterItem' and no alias was found for the original parameter name.","Add the parameter 'FilterItem' back to the cmdlet 'New-AzNetworkWatcherConnectionMonitorEndpointObject', or add an alias to the original parameter name."
  "Microsoft.Azure.PowerShell.Cmdlets.Network.dll","Microsoft.Azure.Commands.Network.NewAzureNetworkWatcherConnectionMonitorEndpointObjectCommand","New-AzNetworkWatcherConnectionMonitorEndpointObject","0","1050","The parameter set '__AllParameterSets' for cmdlet 'New-AzNetworkWatcherConnectionMonitorEndpointObject' has been removed.","Add parameter set '__AllParameterSets' back to cmdlet 'New-AzNetworkWatcherConnectionMonitorEndpointObject'."
  "Microsoft.Azure.PowerShell.Cmdlets.Network.dll","Microsoft.Azure.Commands.Network.NewAzureNetworkWatcherConnectionMonitorEndpointObjectCommand","New-AzNetworkWatcherConnectionMonitorEndpointObject","0","1050","The parameter set 'SetByResourceId' for cmdlet 'New-AzNetworkWatcherConnectionMonitorEndpointObject' has been removed.","Add parameter set 'SetByResourceId' back to cmdlet 'New-AzNetworkWatcherConnectionMonitorEndpointObject'."
  "Microsoft.Azure.PowerShell.Cmdlets.Network.dll","Microsoft.Azure.Commands.Network.NewAzureNetworkWatcherConnectionMonitorEndpointObjectCommand","New-AzNetworkWatcherConnectionMonitorEndpointObject","0","1050","The parameter set 'SetByAddress' for cmdlet 'New-AzNetworkWatcherConnectionMonitorEndpointObject' has been removed.","Add parameter set 'SetByAddress' back to cmdlet 'New-AzNetworkWatcherConnectionMonitorEndpointObject'."

Let's do the cmdlet review first.

@irrogozh
Copy link
Member Author

irrogozh commented Sep 8, 2020

@msJinLei, I've already submitted design spec for updated cmdlets here: https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/733
And you even reviewed it

@msJinLei
Copy link
Contributor

msJinLei commented Sep 9, 2020

@msJinLei, I've already submitted design spec for updated cmdlets here: Azure/azure-powershell-cmdlet-review-pr#733
And you even reviewed it

@irrogozh
Sorry not to remember it as review to many things every day.

Version 3.3.0 is not a public review version. What release version do you want to include the changes of this PR?

Please also update the changelog.md understand Network.

//related PR: #12852

@msJinLei
Copy link
Contributor

@irrogozh As @MikhailTryakhov asks to delete the network-june branch and create the branch of network-july, can you re-target this PR to network-july or close it?

@msJinLei msJinLei self-assigned this Sep 14, 2020
@msJinLei
Copy link
Contributor

closed since duplicate with #12943

@msJinLei msJinLei closed this Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking Change Release This PR contains breaking change needs-revision
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants