Skip to content

Updated Connection monitor endpoint cmdlet #12943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 15, 2020
Merged

Updated Connection monitor endpoint cmdlet #12943

merged 4 commits into from
Sep 15, 2020

Conversation

irrogozh
Copy link
Member

Reviewed in master branch: #12852

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@msJinLei
Copy link
Contributor

@irrogozh can these 2 PR be closed as you can merge the change from preview release branch to master when it is ready.
#12851
#12852

@irrogozh
Copy link
Member Author

@msJinLei , sure, you can close them. Thank you!

@msJinLei msJinLei self-assigned this Sep 14, 2020
@msJinLei
Copy link
Contributor

@msJinLei , sure, you can close them. Thank you!

@irrogozh
are you waiting for MikhailTryakhov to approve? or merge directly?

This was referenced Sep 15, 2020
Closed
Closed
@irrogozh
Copy link
Member Author

@msJinLei , if it's possible, please merge it.

@VeryEarly VeryEarly merged commit 1e76b09 into Azure:Az.Network-preview Sep 15, 2020
dingmeng-xue pushed a commit that referenced this pull request Oct 23, 2020
@johunte @irrogozh
Updated Connection monitor endpoint cmdlet (#13308)
0c7265b 
Security-tools check passed. Force merge it because status cannot sync for the time being.

* Updated Connection monitor endpoint cmdlet (#12943)

* Updated ConnectionMonitorEndpoint cmdlet

* Updated help files

* Fixed help files

* Suppressed breaking changes warnings

* Fixed bug in New-AzConnectionMonitorEndpoint cmdlet. Updated help file (#13001)

* Fixed bug in New-AzConnectionMonitorEndpoint cmdlet. Updated help file

* Fixed typo and add online version in help file

* Updated change log

* fix changelog update

Co-authored-by: irrogozh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VeryEarly VeryEarly VeryEarly approved these changes

@msJinLei msJinLei msJinLei approved these changes

@MikhailTryakhov MikhailTryakhov Awaiting requested review from MikhailTryakhov

Assignees

@msJinLei msJinLei

Labels
needs-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@irrogozh @msJinLei @VeryEarly @azuresdkci