-
Notifications
You must be signed in to change notification settings - Fork 4k
Add generated cmdlets for new RedisEnterpriseCache service #13498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
What do I have to update for ChangeLog.md? My service does not have a src/{{SERVICE}}/{{SERVICE}}/ path, so where would the ChangeLog.md file go? |
src/RedisEnterpriseCache/custom/Export-AzRedisEnterpriseCacheDatabase.ps1
Outdated
Show resolved
Hide resolved
src/RedisEnterpriseCache/docs/Export-AzRedisEnterpriseCacheDatabase.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Some examples are not provided
- Please record your tests for mock tests run in CI pipeline
.\test-module.ps1 -Record
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some changes are required
@dolauli Do all CredScan checks have to pass? Or can CredScan checks fail if they are false positives? |
src/RedisEnterpriseCache/examples/Get-AzRedisEnterpriseCacheOperationStatus.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of the tests are skipped. Is that expected?
@dolauli Yes, there are some cmdlets that are not yet fully supported, so these wouldn't return expected output at this time. Two of these partially supported cmdlets require using a valid storage key which we wouldn't want in the repo. There are a few other cmdlets that could still be tested. I will create tests for those soon and push them. Thanks. |
Description
New PowerShell cmdlets for new Azure service
Checklist
CONTRIBUTING.md
ChangeLog.md
file(s) has been updated:ChangeLog.md
file can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
## Upcoming Release
header -- no new version header should be added