Skip to content

Add private link support for Redis Enterprise #13511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 17, 2020
Merged

Conversation

greenms
Copy link
Contributor

@greenms greenms commented Nov 13, 2020

Description

Update 1 file (ProviderConfiguration.cs) on master branch to support Redis Enterprise private links.

This is a companion PR to #13498

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:

@msJinLei
Copy link
Contributor

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

Copy link
Contributor

@msJinLei msJinLei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@greenms Please add the description item to ChangeLog.md of src/Network.

@greenms
Copy link
Contributor Author

greenms commented Nov 16, 2020

@greenms Please add the description item to ChangeLog.md of src/Network.

@msJinLei It doesn't appear that we update the change log in this case. At least, that's what @isra-fel appears to have said 12 days ago. Link to support my statement: #13403 Do I still need to update the ChangeLog.md of src/Network?

@isra-fel
Copy link
Member

Taked with Jin Lei offline. Yes, you don't need to update changelog for enabling private link

@isra-fel
Copy link
Member

/azp run azure-powershell - powershell-core

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@msJinLei msJinLei merged commit 6d74717 into Azure:master Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants