-
Notifications
You must be signed in to change notification settings - Fork 4k
[Resources] Use JsonExtensions to serialize and deserialize template and parameter objects #15552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -21,6 +21,7 @@ | |||
</ItemGroup> | |||
|
|||
<ItemGroup> | |||
<ProjectReference Include="..\ResourceManager\ResourceManager.csproj" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added this reference to be able to access JsonExtensions, probably, as a future PR, consider moving JsonExtensions to a common project.
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Just fixed a merge conflict in ChangeLog.md, do we have an ETA when this fix will be merged and after is merged how long it takes for it to be published? Thanks! |
Next official release will be September 7 |
Did this break Tag case sensitivity? |
Description
Checklist
CONTRIBUTING.md
ChangeLog.md
file(s) has been updated:ChangeLog.md
file can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
## Upcoming Release
header -- no new version header should be added