Skip to content

[Resources] Use JsonExtensions to serialize and deserialize template and parameter objects #15552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Aug 2, 2021
Merged

Conversation

jorgecotillo
Copy link
Contributor

@jorgecotillo jorgecotillo commented Jul 27, 2021

Description

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

@jorgecotillo jorgecotillo changed the title Use JsonExtensions to serialize and deserialize objects [Resources] Use JsonExtensions to serialize and deserialize template and parameter objects Jul 27, 2021
@jorgecotillo jorgecotillo marked this pull request as ready for review July 27, 2021 21:06
@@ -21,6 +21,7 @@
</ItemGroup>

<ItemGroup>
<ProjectReference Include="..\ResourceManager\ResourceManager.csproj" />
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added this reference to be able to access JsonExtensions, probably, as a future PR, consider moving JsonExtensions to a common project.

@isra-fel isra-fel self-assigned this Jul 28, 2021
Xynoclafe
Xynoclafe previously approved these changes Jul 28, 2021
@Xynoclafe
Copy link
Contributor

LGTM

isra-fel
isra-fel previously approved these changes Jul 30, 2021
Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jorgecotillo
Copy link
Contributor Author

Just fixed a merge conflict in ChangeLog.md, do we have an ETA when this fix will be merged and after is merged how long it takes for it to be published? Thanks!

@isra-fel isra-fel merged commit 832979d into Azure:main Aug 2, 2021
@isra-fel
Copy link
Member

isra-fel commented Aug 2, 2021

Next official release will be September 7

@ChristopherGLewis
Copy link
Contributor

Did this break Tag case sensitivity?

#15876

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants