Skip to content

[Az Resources] Fix resource tags casing serialization - tags casing not being preserved when passed as parameters #15920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 23, 2021

Conversation

jorgecotillo
Copy link
Contributor

Description

We've encountered that after this PR got merged: #15552 we regressed the way casing is handled on the template parameters. Basically casing was not preserved and it affected the way resource tags works.

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

@shenglol
Copy link
Contributor

The unit test Microsoft.Azure.Commands.Resources.Test.Json.PSJsonSerializerTests.Serialize_Hashtable_Success failed, otherwise it looks good to me.

@jorgecotillo
Copy link
Contributor Author

The unit test Microsoft.Azure.Commands.Resources.Test.Json.PSJsonSerializerTests.Serialize_Hashtable_Success failed, otherwise it looks good to me.

Thanks Shenglong, yeah Gokul mentioned it to me as well, I just fixed the test.

Copy link
Contributor

@Xynoclafe Xynoclafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wyunchi-ms wyunchi-ms merged commit 4929e40 into Azure:main Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants