Skip to content

Add SqlSetting Property to Azure Firewall Policy #17111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 21, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,14 @@ public void TestAzureFirewallPolicyWithDNSSettings()
TestRunner.RunTestScript("Test-AzureFirewallPolicyWithDNSSettings");
}

[Fact]
[Trait(Category.AcceptanceType, Category.CheckIn)]
[Trait(Category.Owner, NrpTeamAlias.azurefirewall)]
public void TestAzureFirewallPolicyWithSQLSetting()
{
TestRunner.RunTestScript("Test-AzureFirewallPolicyWithSQLSetting");
}

[Fact]
[Trait(Category.AcceptanceType, Category.CheckIn)]
[Trait(Category.Owner, NrpTeamAlias.azurefirewall)]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -396,6 +396,68 @@ function Test-AzureFirewallPolicyWithDNSSettings {
}
}

<#
.SYNOPSIS
Tests AzureFirewallPolicyWithSQLSettings
#>
function Test-AzureFirewallPolicyWithSQLSetting {
$rgname = Get-ResourceGroupName
$azureFirewallPolicyName = Get-ResourceName
$azureFirewallPolicyName2 = Get-ResourceName
$location = "eastus2euap"

try {

# Create the resource group
$resourceGroup = New-AzResourceGroup -Name $rgname -Location $location -Tags @{ testtag = "testval" }

# test new AzureFirewallPolicy with sql redirect
$allowSql = New-AzFirewallPolicySqlSetting -AllowSqlRedirect
$azureFirewallPolicy = New-AzFirewallPolicy -Name $azureFirewallPolicyName -ResourceGroupName $rgname -Location $location -SqlSetting $allowSql
$getAzureFirewallPolicy = Get-AzFirewallPolicy -Name $azureFirewallPolicyName -ResourceGroupName $rgname

# verification
Assert-AreEqual $rgName $getAzureFirewallPolicy.ResourceGroupName
Assert-AreEqual $azureFirewallPolicyName $getAzureFirewallPolicy.Name
Assert-NotNull $getAzureFirewallPolicy.Location
Assert-AreEqual (Normalize-Location $location) $getAzureFirewallPolicy.Location

# check sql setting
Assert-NotNull $getAzureFirewallPolicy.SqlSetting
Assert-AreEqual true $getAzureFirewallPolicy.SqlSetting.AllowSqlRedirect

# test set AzureFirewallPolicy without sql redirect
$disallowSql = New-AzFirewallPolicySqlSetting
$azureFirewallPolicy = Set-AzFirewallPolicy -Name $azureFirewallPolicyName -ResourceGroupName $rgname -Location $location -SqlSetting $disallowSql
$getAzureFirewallPolicy = Get-AzFirewallPolicy -Name $azureFirewallPolicyName -ResourceGroupName $rgname
Assert-Null $getAzureFirewallPolicy.SqlSetting.AllowSqlRedirect

# test set AzureFirewallPolicy with sql redirect
$azureFirewallPolicy = Set-AzFirewallPolicy -Name $azureFirewallPolicyName -ResourceGroupName $rgname -Location $location -SqlSetting $allowSql
$getAzureFirewallPolicy = Get-AzFirewallPolicy -Name $azureFirewallPolicyName -ResourceGroupName $rgname
Assert-NotNull $getAzureFirewallPolicy.SqlSetting
Assert-AreEqual true $getAzureFirewallPolicy.SqlSetting.AllowSqlRedirect

# test new AzureFirewallPolicy without sql redirect
$azureFirewallPolicy2 = New-AzFirewallPolicy -Name $azureFirewallPolicyName2 -ResourceGroupName $rgname -Location $location
$getAzureFirewallPolicy2 = Get-AzFirewallPolicy -Name $azureFirewallPolicyName2 -ResourceGroupName $rgname

# verification
Assert-AreEqual $rgName $getAzureFirewallPolicy2.ResourceGroupName
Assert-AreEqual $azureFirewallPolicyName2 $getAzureFirewallPolicy2.Name
Assert-NotNull $getAzureFirewallPolicy2.Location
Assert-AreEqual (Normalize-Location $location) $getAzureFirewallPolicy2.Location

# check sql setting
Assert-Null $getAzureFirewallPolicy2.SqlSetting

}
finally {
# Cleanup
Clean-ResourceGroup $rgname
}
}

<#
.SYNOPSIS
Tests function Test-AzureFirewallPolicyCRUDWithNetworkRuleDestinationFQDNs.
Expand Down

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Loading