-
Notifications
You must be signed in to change notification settings - Fork 4k
add ScriptLocalPath param set for Set-AzVmRunCommand #19935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
how do i update changelog when updating generation branch? @VeryEarly |
@grizzlytheodore changelog can be added from generation to main sync. You can let me know and I will help add. |
|
||
function Set-AzVMRunCommand_ScriptLocalPath { | ||
[OutputType([Microsoft.Azure.PowerShell.Cmdlets.Compute.Models.Api20210701.IVirtualMachineRunCommand])] | ||
[CmdletBinding(PositionalBinding=$false, SupportsShouldProcess, ConfirmImpact='Medium')] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the DefaultParameterSetName missing here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do i need to set that? looking at other customized cmdlets in the folder, it doesn't seem necessary. Looking at the doc, it looks like it resolves the original as the defaultParameterSet by default.
https://github.com/Azure/azure-powershell/pull/19935/files#diff-98b2e209fe660fbafe42a698f08f3105e161521fdca07891934035f26f317b01R15
@vidai-msft I want to add Please show me where I add to add that for changelog |
Hi @grizzlytheodore , Please leave changelog here in description of this PR, I'll add it to release branch while migration. |
its in the comment you just reply to @VeryEarly |
Description
addressing #19468
Checklist
CONTRIBUTING.md
and reviewed the following information:generation
branch.ChangeLog.md
file(s) appropriatelyChangeLog.md
file can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
## Upcoming Release
header in the past tense. Add changelog in description section if PR goes intogeneration
branch.ChangeLog.md
if no new release is required, such as fixing test case only.