Skip to content

add ScriptLocalPath param set for Set-AzVmRunCommand #19935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 26, 2022

Conversation

grizzlytheodore
Copy link
Member

@grizzlytheodore grizzlytheodore commented Oct 25, 2022

Description

addressing #19468

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT adjust version of module manually in pull request

@grizzlytheodore
Copy link
Member Author

how do i update changelog when updating generation branch? @VeryEarly

@vidai-msft
Copy link
Contributor

@grizzlytheodore changelog can be added from generation to main sync. You can let me know and I will help add.


function Set-AzVMRunCommand_ScriptLocalPath {
[OutputType([Microsoft.Azure.PowerShell.Cmdlets.Compute.Models.Api20210701.IVirtualMachineRunCommand])]
[CmdletBinding(PositionalBinding=$false, SupportsShouldProcess, ConfirmImpact='Medium')]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the DefaultParameterSetName missing here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do i need to set that? looking at other customized cmdlets in the folder, it doesn't seem necessary. Looking at the doc, it looks like it resolves the original as the defaultParameterSet by default.
https://github.com/Azure/azure-powershell/pull/19935/files#diff-98b2e209fe660fbafe42a698f08f3105e161521fdca07891934035f26f317b01R15

@vidai-msft vidai-msft self-assigned this Oct 25, 2022
@grizzlytheodore
Copy link
Member Author

@vidai-msft I want to add
"Added 'ScriptFilePath' parameter sets for Set-AzVMRunCommand and Set-AzVmssVMRunCommand to allow users to pass in the path of the file that has the run command script."

Please show me where I add to add that for changelog

@VeryEarly
Copy link
Collaborator

@vidai-msft I want to add "Added 'ScriptFilePath' parameter sets for Set-AzVMRunCommand and Set-AzVmssVMRunCommand to allow users to pass in the path of the file that has the run command script."

Please show me where I add to add that for changelog

Hi @grizzlytheodore ,

Please leave changelog here in description of this PR, I'll add it to release branch while migration.

@grizzlytheodore
Copy link
Member Author

its in the comment you just reply to @VeryEarly

@VeryEarly VeryEarly assigned VeryEarly and unassigned vidai-msft Oct 26, 2022
@VeryEarly VeryEarly merged commit 289ec47 into generation Oct 26, 2022
@VeryEarly VeryEarly deleted the RcAddLocalFilePathVariant branch October 26, 2022 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants