-
Notifications
You must be signed in to change notification settings - Fork 4k
fix issue found for Set-AzVmssVMRunCommand #19993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…azure-powershell into RcAddLocalFilePathVariant
@dingmeng-xue , @VeryEarly pls see the description. The PR I made last week for this update has a bug and I want to address it before it goes out |
please create OOB request, it's too late for current release |
got it. spoke to the feature owner, and we will let this out in the next release scheduled on 12/6. Please review/merge |
It looks good to me. Please help me double check @BethanyZhou |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me with few changes required
@BethanyZhou added back output blocks. Please review/merge ! |
@Nickcandy looks all good. Please review/merge! thank you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add output for each example.
addressed your comment. pls review/merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Hi @Nickcandy , could you help carry @grizzlytheodore 's changes to main branch? |
@BethanyZhou Merged |
Description
New parameter sets for Set-AzVMRunCommand and Set-AzVmssVMRunCommand were added in this PR(#19935) set to GA on 11/1,
but the feature owner @vivlingaiah has already found a bug(#19985), and I want to address them before it goes out.
Also adding examples here instead of in the PR that @vivlingaiah made in this PR: #19969
Checklist
CONTRIBUTING.md
and reviewed the following information:generation
branch.ChangeLog.md
file(s) appropriatelyChangeLog.md
file can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
## Upcoming Release
header in the past tense. Add changelog in description section if PR goes intogeneration
branch.ChangeLog.md
if no new release is required, such as fixing test case only.