Skip to content

fix issue found for Set-AzVmssVMRunCommand #19993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Nov 24, 2022

Conversation

grizzlytheodore
Copy link
Member

@grizzlytheodore grizzlytheodore commented Oct 31, 2022

Description

New parameter sets for Set-AzVMRunCommand and Set-AzVmssVMRunCommand were added in this PR(#19935) set to GA on 11/1,
but the feature owner @vivlingaiah has already found a bug(#19985), and I want to address them before it goes out.

Also adding examples here instead of in the PR that @vivlingaiah made in this PR: #19969

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT adjust version of module manually in pull request

@grizzlytheodore
Copy link
Member Author

@dingmeng-xue , @VeryEarly pls see the description. The PR I made last week for this update has a bug and I want to address it before it goes out

@VeryEarly
Copy link
Collaborator

please create OOB request, it's too late for current release

@grizzlytheodore
Copy link
Member Author

got it. spoke to the feature owner, and we will let this out in the next release scheduled on 12/6. Please review/merge

@VeryEarly

@Nickcandy
Copy link
Contributor

It looks good to me. Please help me double check @BethanyZhou

Copy link
Contributor

@BethanyZhou BethanyZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me with few changes required

@grizzlytheodore
Copy link
Member Author

@BethanyZhou added back output blocks. Please review/merge !

@grizzlytheodore
Copy link
Member Author

@Nickcandy looks all good. Please review/merge! thank you

Copy link
Contributor

@BethanyZhou BethanyZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add output for each example.

@grizzlytheodore
Copy link
Member Author

Please add output for each example.

addressed your comment. pls review/merge

Copy link
Contributor

@BethanyZhou BethanyZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@BethanyZhou BethanyZhou merged commit 366e5ef into generation Nov 24, 2022
@BethanyZhou BethanyZhou deleted the RcAddLocalFilePathVariant branch November 24, 2022 02:20
@BethanyZhou
Copy link
Contributor

Hi @Nickcandy , could you help carry @grizzlytheodore 's changes to main branch?

@Nickcandy
Copy link
Contributor

@BethanyZhou Merged

@BethanyZhou BethanyZhou mentioned this pull request Nov 25, 2022
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants