Skip to content

Adding positional params to Resource group cmdlets and updating help #2153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 27, 2016
Merged

Adding positional params to Resource group cmdlets and updating help #2153

merged 8 commits into from
Apr 27, 2016

Conversation

ravbhatnagar
Copy link
Contributor

@ravbhatnagar ravbhatnagar commented Apr 26, 2016

Added positional params for Resource group cmdlets
Updated help for a bunch of cmdlets
Updated AzureRM.Resources.psd1 to include the Microsoft.Azure.Commands.ResourceManager.Cmdlets.format.ps1xml and its corresponding types file

@azurecla
Copy link

Hi @ravbhatnagar, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!


It looks like you're working at Microsoft (gauravbh). If you're full-time, we DON'T require a contribution license agreement.



If you are a vendor, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

@@ -1115,6 +1116,37 @@
</command:commandLine>
</command:commandLines>
</command:example>
<command:example>
<maml:title>------- Example2 Get the request and response content for each deployment operation if enabled on new deployment -------</maml:title>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. nit: Example 2
  2. Description should go to next line to be consistent with Example 1 above

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@@ -882,7 +903,8 @@
<dev:version />
</command:details>
<maml:description>
<maml:para>Gets the resource group deployment operation</maml:para>
<maml:para>This lists all the operations that were part of a deployment. It can be used for debugging deployment failures as it will help you identify and give more information about the exact operations that failed for a particular deployment. It can also give out the response and the request content for each deployment operation. This is the same information that you get from the deployment details on the portal. </maml:para>
<maml:para>For getting the request and the response content, the setting will have to be enabled when submitting a deployment through New-AzureRmResourceGroupDeployment. log and expose secrets like passwords used in the resource property or listKeys operations that are then returned when you retrieve the deployment operations. For more details on this setting and how to enable it, please see the help for New-AzureRmResourceGroupDeployment</maml:para>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

log and expose secrets like passwords used in the resource property or listKeys operations that are then returned when you retrieve the deployment operations. - this statement needs to be revised and It should start with upper case "L"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ravbhatnagar Not fixed. This has not been pushed to this fork and branch

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@markcowl - This should be merged now.

@vivsriaus
Copy link
Contributor

@ravbhatnagar Let's add the positional parameter to -Tag in New-AzureRmResourceGroup as well.

vivsriaus and others added 2 commits April 26, 2016 15:02
Add RG positional params test, update RM manifest to include RGDO for…
@vivsriaus
Copy link
Contributor

@ravbhatnagar
Copy link
Contributor Author

@vivsriaus - Currently we added the positional parameters to the mandatory params on this one. Don't think we should add this yet as this is not mandatory.

@vivsriaus
Copy link
Contributor

vivsriaus commented Apr 27, 2016

@hovsepm hovsepm merged commit 7edd186 into Azure:dev Apr 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants