-
Notifications
You must be signed in to change notification settings - Fork 4k
Adding positional params to Resource group cmdlets and updating help #2153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…for a bunch of cmdlets
Hi @ravbhatnagar, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!
TTYL, AZPRBOT; |
@@ -1115,6 +1116,37 @@ | |||
</command:commandLine> | |||
</command:commandLines> | |||
</command:example> | |||
<command:example> | |||
<maml:title>------- Example2 Get the request and response content for each deployment operation if enabled on new deployment -------</maml:title> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- nit: Example 2
- Description should go to next line to be consistent with Example 1 above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
@@ -882,7 +903,8 @@ | |||
<dev:version /> | |||
</command:details> | |||
<maml:description> | |||
<maml:para>Gets the resource group deployment operation</maml:para> | |||
<maml:para>This lists all the operations that were part of a deployment. It can be used for debugging deployment failures as it will help you identify and give more information about the exact operations that failed for a particular deployment. It can also give out the response and the request content for each deployment operation. This is the same information that you get from the deployment details on the portal. </maml:para> | |||
<maml:para>For getting the request and the response content, the setting will have to be enabled when submitting a deployment through New-AzureRmResourceGroupDeployment. log and expose secrets like passwords used in the resource property or listKeys operations that are then returned when you retrieve the deployment operations. For more details on this setting and how to enable it, please see the help for New-AzureRmResourceGroupDeployment</maml:para> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
log and expose secrets like passwords used in the resource property or listKeys operations that are then returned when you retrieve the deployment operations. - this statement needs to be revised and It should start with upper case "L"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ravbhatnagar Not fixed. This has not been pushed to this fork and branch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@markcowl - This should be merged now.
@ravbhatnagar Let's add the positional parameter to -Tag in New-AzureRmResourceGroup as well. |
…mat and types files
Add RG positional params test, update RM manifest to include RGDO for…
On demand job here: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-demand/702/ |
@vivsriaus - Currently we added the positional parameters to the mandatory params on this one. Don't think we should add this yet as this is not mandatory. |
@markcowl new on-demand for this PR here: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-demand/713/ |
Added positional params for Resource group cmdlets
Updated help for a bunch of cmdlets
Updated AzureRM.Resources.psd1 to include the Microsoft.Azure.Commands.ResourceManager.Cmdlets.format.ps1xml and its corresponding types file