Skip to content

Adding positional params to Resource group cmdlets and updating help #2153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 27, 2016
Merged

Adding positional params to Resource group cmdlets and updating help #2153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
447460a
Adding positional params to Resource group cmdlets and updating help …
ravbhatnagar Apr 26, 2016
a42d12d
Updating help based on feedback
ravbhatnagar Apr 26, 2016
54ac658
Add RG positional params test, update RM manifest to include RGDO for…
vivsriaus Apr 26, 2016
c951c29
Merge pull request #1 from vivsriaus/AddRGTest
ravbhatnagar Apr 26, 2016
03aac1f
Updating based on some review feedback
ravbhatnagar Apr 26, 2016
2a03ef9
Merge branch 'dev' of https://github.com/azure/azure-powershell into dev
ravbhatnagar Apr 26, 2016
c555143
Merge branch 'dev' of https://github.com/ravbhatnagar/azure-powershel…
ravbhatnagar Apr 26, 2016
6c4bdc5
Fixing typo Example 1-> Example 2
ravbhatnagar Apr 26, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/ResourceManager/Resources/AzureRM.Resources.psd1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,11 +54,14 @@ RequiredAssemblies = @()
ScriptsToProcess = @()

# Type files (.ps1xml) to be loaded when importing this module
TypesToProcess = @()
TypesToProcess = @(
'Microsoft.Azure.Commands.ResourceManager.Cmdlets.Types.ps1xml'
)

# Format files (.ps1xml) to be loaded when importing this module
FormatsToProcess = @(
'.\Microsoft.Azure.Commands.Resources.format.ps1xml'
'.\Microsoft.Azure.Commands.Resources.format.ps1xml',
'.\Microsoft.Azure.Commands.ResourceManager.Cmdlets.format.ps1xml'
)

# Modules to import as nested modules of the module specified in ModuleToProcess
Expand Down
103 changes: 78 additions & 25 deletions ...nds.ResourceManager/Cmdlets/Microsoft.Azure.Commands.ResourceManager.Cmdlets.dll-Help.xml
View file
Open in desktop

Large diffs are not rendered by default.

3 changes: 3 additions & 0 deletions src/ResourceManager/Resources/Commands.Resources.Test/Commands.Resources.Test.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,6 +402,9 @@
<None Include="SessionRecords\Microsoft.Azure.Commands.Resources.Test.ScenarioTests.ResourceGroupTests\TestRemoveNonExistingResourceGroup.json">
<CopyToOutputDirectory>Always</CopyToOutputDirectory>
</None>
<None Include="SessionRecords\Microsoft.Azure.Commands.Resources.Test.ScenarioTests.ResourceGroupTests\TestResourceGroupWithPositionalParams.json">
<CopyToOutputDirectory>Always</CopyToOutputDirectory>
</None>
<None Include="SessionRecords\Microsoft.Azure.Commands.Resources.Test.ScenarioTests.ResourceGroupTests\TestUpdatesExistingResourceGroup.json">
<CopyToOutputDirectory>Always</CopyToOutputDirectory>
</None>
Expand Down
7 changes: 7 additions & 0 deletions src/ResourceManager/Resources/Commands.Resources.Test/ScenarioTests/ResourceGroupTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,13 @@ public void TestExportResourceGroup()
ResourcesController.NewInstance.RunPsTest("Test-ExportResourceGroup");
}

[Fact]
[Trait(Category.AcceptanceType, Category.CheckIn)]
public void TestResourceGroupWithPositionalParams()
{
ResourcesController.NewInstance.RunPsTest("Test-ResourceGroupWithPositionalParams");
}

[Fact (Skip = "TODO: Fix the broken test.")]
public void TestAzureTagsEndToEnd()
{
Expand Down
30 changes: 30 additions & 0 deletions src/ResourceManager/Resources/Commands.Resources.Test/ScenarioTests/ResourceGroupTests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,4 +350,34 @@ function Test-ExportResourceGroup
# Cleanup
Clean-ResourceGroup $rgname
}
}

<#
.SYNOPSIS
Tests resource group new, get and remove using positional parameters.
#>
function Test-ResourceGroupWithPositionalParams
{
# Setup
$rgname = Get-ResourceGroupName
$location = "West US"

try
{
$ErrorActionPreference = "SilentlyContinue"
$Error.Clear()
# Test
$actual = New-AzureRmResourceGroup $rgname $location
$expected = Get-AzureRmResourceGroup $rgname

# Assert
Assert-AreEqual $expected.ResourceGroupName $actual.ResourceGroupName

#Test
Remove-AzureRmResourceGroup $rgname -Force
}
catch
{
Assert-True { $Error[0].Contains("Provided resource group does not exist.") }
}
}
Loading