[NetAppFiles] Generate SDK to api-version 2023-05-01 #23710
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️Az.Accounts
|
| Type | Cmdlet | Example | Line | RuleName | Description | Extent | Remediation |
|---|---|---|---|---|---|---|---|
| Update-AzNetAppFilesNetworkSiblingSet | 1 | 2 | Unassigned_Variable | Update-AzNetAppFilesNetworkSiblingSet -SubnetId $subnetId is a null-valued parameter value. | -SubnetId | Assign value for $subnetId. | |
| Update-AzNetAppFilesNetworkSiblingSet | 1 | 2 | Unassigned_Variable | Update-AzNetAppFilesNetworkSiblingSet -NetworkSiblingSetStateId $networkSiblingSet.NetworkSiblingSetStateId is a null-valued parameter value. | -NetworkSiblingSetStateId | Assign value for $networkSiblingSet.NetworkSiblingSetStateId. |
⚠️ Windows PowerShell - Windows
| Type | Cmdlet | Example | Line | RuleName | Description | Extent | Remediation |
|---|---|---|---|---|---|---|---|
| Update-AzNetAppFilesNetworkSiblingSet | 1 | 2 | Unassigned_Variable | Update-AzNetAppFilesNetworkSiblingSet -SubnetId $subnetId is a null-valued parameter value. | -SubnetId | Assign value for $subnetId. | |
| Update-AzNetAppFilesNetworkSiblingSet | 1 | 2 | Unassigned_Variable | Update-AzNetAppFilesNetworkSiblingSet -NetworkSiblingSetStateId $networkSiblingSet.NetworkSiblingSetStateId is a null-valued parameter value. | -NetworkSiblingSetStateId | Assign value for $networkSiblingSet.NetworkSiblingSetStateId. |
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️File Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Generated Sdk Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️ Test
⚠️ - Linux
Type Title Current Coverage Last Coverage Description ⚠️ Test Coverage Less Than 80% 74.65 % 76.81% Test coverage cannot be lower than the number of the last release.
⚠️ - MacOS
Type Title Current Coverage Last Coverage Description ⚠️ Test Coverage Less Than 80% 74.65% 76.81% Test coverage cannot be lower than the number of the last release.
⚠️ PowerShell Core - Windows
Type Title Current Coverage Last Coverage Description ⚠️ Test Coverage Less Than 80% 74.65% 76.81% Test coverage cannot be lower than the number of the last release.
⚠️ Windows PowerShell - Windows
Type Title Current Coverage Last Coverage Description ⚠️ Test Coverage Less Than 80% 74.65% 76.81% Test coverage cannot be lower than the number of the last release.
️✔️Az.Network
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
|
@audunn Please resolve the conflicts. |
|
/azp run |
|
@audunn There are some issues detected in the |
… ANF-31970-NetAppFiles-2023-05-01
dolauli
requested changes
Dec 14, 2023
| * Fixed some minor issues | ||
| * Updated to api-version 2023-05-01 | ||
| * Added `EncryptionKeySource`, `KeyVaultKeyName`, `KeyVaultResourceId`, `KeyVaultUri`, `IdentityType`, `UserAssignedIdentity` to `New-AzNetAppFilesAccount` and `Update-AzNetAppFilesAccount` | ||
| * Added new cmdLets `Get-AzNetAppFilesNetworkSiblingSet` and `Update-AzNetAppFilesNetworkSiblingSet` to query and update update the network features of a network sibling set |
There was a problem hiding this comment.
update update - one update is redundant.
There was a problem hiding this comment.
line#24 and line#25 are the same. Please remove one
dolauli
approved these changes
Dec 19, 2023
6 tasks
|
Note we are be adding a fix for NetApp Account Identity in #23808 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.