-
Notifications
You must be signed in to change notification settings - Fork 4k
[NetAppFiles] Add test and fix for NetAppAccount Identity #23808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dolauli
merged 5 commits into
Azure:main
from
audunn:ANF-31970-NetAppFiles-2023-05-01-AccountIdentity
Dec 25, 2023
Merged
[NetAppFiles] Add test and fix for NetAppAccount Identity #23808
dolauli
merged 5 commits into
Azure:main
from
audunn:ANF-31970-NetAppFiles-2023-05-01-AccountIdentity
Dec 25, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️Az.Accounts
|
Type | Cmdlet | Description | Remediation |
---|---|---|---|
It is required to update ChangeLog.md if you want to release a new version for Az.NetAppFiles. | Add a changelog record under Upcoming Release section with past tense. |
⚠️ Windows PowerShell - Windows
Type | Cmdlet | Description | Remediation |
---|---|---|---|
It is required to update ChangeLog.md if you want to release a new version for Az.NetAppFiles. | Add a changelog record under Upcoming Release section with past tense. |
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️PowerShell Core - Linux
️✔️PowerShell Core - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Network
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
Continues from #23710 |
6 tasks
@audunn Please fix the test failure. |
@dolauli Test fixed, please merge as soon as possible, we would like for this to be included in the next release of Azure Powershell to fix the issu.e. |
dolauli
approved these changes
Dec 25, 2023
@dolauli Do we have an eta for this fix, it is urgently needed for some important customers using CMK with Azure NetApp Files } |
Will be release in Jan 9. |
@dolauli thank you |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes an issue with setting identity on NetApp account also adds test for this same issue and Update-AzNetAppFilesAccountCredential.
Mandatory Checklist
Please choose the target release of Azure PowerShell
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.md
and reviewed the following information:ChangeLog.md
file(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
.## Upcoming Release
header in the past tense.ChangeLog.md
if no new release is required, such as fixing test case only.