Skip to content

[NetAppFiles] Add test and fix for NetAppAccount Identity #23808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

audunn
Copy link
Member

@audunn audunn commented Dec 21, 2023

Description

This fixes an issue with setting identity on NetApp account also adds test for this same issue and Update-AzNetAppFilesAccountCredential.

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • For autorest-based development mode, include the changelog in the PR description.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Copy link

azure-client-tools-bot-prd bot commented Dec 21, 2023

️✔️Az.Accounts
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️Az.NetAppFiles
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Breaking Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Signature Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️File Change Check
⚠️PowerShell Core - Windows
Type Cmdlet Description Remediation
⚠️ It is required to update ChangeLog.md if you want to release a new version for Az.NetAppFiles. Add a changelog record under Upcoming Release section with past tense.
⚠️Windows PowerShell - Windows
Type Cmdlet Description Remediation
⚠️ It is required to update ChangeLog.md if you want to release a new version for Az.NetAppFiles. Add a changelog record under Upcoming Release section with past tense.
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️PowerShell Core - Linux
️✔️PowerShell Core - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Network
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows

@audunn
Copy link
Member Author

audunn commented Dec 21, 2023

Continues from #23710

@dolauli
Copy link
Contributor

dolauli commented Dec 22, 2023

@audunn Please fix the test failure.

@dolauli dolauli self-assigned this Dec 22, 2023
@audunn
Copy link
Member Author

audunn commented Dec 22, 2023

@audunn Please fix the test failure.

@dolauli Yes, it curiusly is not failing when we run the test locally in record model. We are trying to find out but are not sure what is causing this atm.

@audunn
Copy link
Member Author

audunn commented Dec 22, 2023

@dolauli Test fixed, please merge as soon as possible, we would like for this to be included in the next release of Azure Powershell to fix the issu.e.

@dolauli dolauli merged commit db50240 into Azure:main Dec 25, 2023
@audunn
Copy link
Member Author

audunn commented Jan 3, 2024

@dolauli Do we have an eta for this fix, it is urgently needed for some important customers using CMK with Azure NetApp Files }

@dolauli
Copy link
Contributor

dolauli commented Jan 4, 2024

Will be release in Jan 9.

@audunn
Copy link
Member Author

audunn commented Jan 4, 2024

@dolauli thank you

@audunn audunn changed the title [NetAppFilse] Add test and fix for NetAppAccount Identity [NetAppFiles] Add test and fix for NetAppAccount Identity Jan 4, 2024
@audunn
Copy link
Member Author

audunn commented Jan 4, 2024

@dolauli can we include this small fix as we found a related issue in Update-AzNetAppFilesAccount ?
#23878

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants