Skip to content

Add migration(Reservedip, nsg, route) cmdlets #2698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

DeepakRajendranMsft
Copy link
Contributor

No description provided.

@azurecla
Copy link

Hi @DeepakRajendranMsft, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
We will now validate the agreement and then real humans will evaluate your PR.

TTYL, AZPRBOT;

@DeepakRajendranMsft DeepakRajendranMsft changed the title [DO NOT MERGE] Add migration cmdlets Add migration(Reservedip, nsg, route) cmdlets Jul 31, 2016
@DeepakRajendranMsft
Copy link
Contributor Author

This failure is not related to my changes, the previous commit passed all tests. Could you please trigger the build again.

d:\workspace\powershell\src\Common\Commands.Common.Authentication\Models\DiskDataStore.cs(42): error : Microsoft.WindowsAzure.Commands.Test.Websites.SaveAzureWebsiteLogTests.SaveAzureWebsiteLogWithNoFileExtensionTest [FAIL]

@markcowl
Copy link
Member

markcowl commented Aug 1, 2016

@DeepakRajendranMsft Yep, rerunning

[Fact]
[Trait(Category.Service, Category.ServiceManagement)]
[Trait(Category.AcceptanceType, Category.CheckIn)]
[Trait(Category.AcceptanceType, Category.BVT)]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the other AcceptanceType attribute is redundant. CheckIn tests are automatically included as BVTs

@markcowl
Copy link
Member

markcowl commented Aug 1, 2016

@DeepakRajendranMsft Looks like issues with the Azure.psd1 module and some CredScan issues with the help. Also, you will need to merge with upstream, as there are merge conflicts.

@DeepakRajendranMsft
Copy link
Contributor Author

DeepakRajendranMsft commented Aug 1, 2016

@markcowl Thanks!

I didnt change anything in azure.psd1 and with regards to help. i just added some description of cmdlets and parameters. is there a way of identifying is exactly wrong with the help. Also, is this issue with only CI or with other PRs?

@markcowl
Copy link
Member

markcowl commented Aug 3, 2016

@DeepakRajendranMsft You will need to retarget this PR at release-2.0.0

@DeepakRajendranMsft
Copy link
Contributor Author

@markcowl will do

@DeepakRajendranMsft
Copy link
Contributor Author

DeepakRajendranMsft commented Aug 3, 2016

created a new pull request against release-2.0.0 branch -#2721

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants