-
Notifications
You must be signed in to change notification settings - Fork 4k
Add migration cmdlets #2721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add migration cmdlets #2721
Conversation
…hell into AddMigrationCmdlets
Hi @DeepakRajendranMsft, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution! TTYL, AZPRBOT; |
@markcowl, CI is good now :) |
it failed with this test (same test failed in my PR also), someone should fix this test |
/// <summary> | ||
/// Migrate ASM Network Security Group to ARM | ||
/// </summary> | ||
[Cmdlet(VerbsCommon.Move, "AzureNetworkSecurityGroup"), OutputType(typeof(OperationStatusResponse))] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SupportsShouldProcess=true
@markcowl why do you think we need ShouldProcess() here? we do not need any confirmation of sorts from the user? @DeepakRajendranMsft This is required for all new cmdlets. ShouldProcess does not normally print a prompt; it just allows the user to use -Confirm and -WhatIf to cotnrol / reflect over execution of the cmdlet. @markcowl These cmdlets are not “new-” cmdlets. These are similar to Move-Azurestorage, and so I don’t believe we need ShouldProcess for these Move- cmdlets. @DeepakRajendranMsft It is the same for substantially changed cmdlets, like these. If these are a major new set of cmdlets for migrating resources, we want to make sure that they are following best practices |
Assert-Null $status.ValidationMessages | ||
|
||
# Prepare move | ||
Move-AzureRouteTable -RouteTableName $routeTableName -Prepare -Confirm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not pass -Confirm
Yep. just fixed that. :)
@DeepakRajendranMsft It looks like you added the -Confirm parameter to each of your cmdlet invocatiosn in script. -Confirm tells the cmdlet to always prompt on ShouldProcess. Remove this parameter and these issues should go away @markcowl yep, just fixed that |
@markcowl @cormacpayne are we good for the merge? |
No description provided.