[Do Not Merge] Added daemon and secret-key option in ChefExtension for ASM and ARM commands. #3322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: aliasgar16 <[email protected]>
|
Hi @Aliasgar16, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution! TTYL, AZPRBOT; |
|
Can one of the admins verify this patch? |
|
@hyonholee Hey Hyonho, would you mind reviewing this PR? |
Aliasgar16
changed the title
…s and daemon option for ARM commands. Signed-off-by: aliasgar16 <[email protected]>
added 2 commits
December 23, 2016 05:42
Signed-off-by: aliasgar16 <[email protected]>
Signed-off-by: aliasgar16 <[email protected]>
|
@Aliasgar16 please resolve the merge conflicts |
Signed-off-by: aliasgar16 <[email protected]>
|
@cormacpayne I will resolve all the conflicts once I am done adding test cases for the functionality. |
|
Cherry-picked the commits and created another PR as it was impossible to re-base this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In-progress.