Added daemon and databag secret-key options in ChefExtension for ASM and ARM commands. #3387
Conversation
|
Hi @Aliasgar16, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution! TTYL, AZPRBOT; |
|
Can one of the admins verify this patch? |
|
@cormacpayne I have created this new PR as it was impossible to re-base the earlier PR, can you review this now ? |
|
@azuresdkci add to whitelist |
|
@Aliasgar16 please pull the latest changes from dev |
Aliasgar16
force-pushed
the
ali/add_daemon_and_databag_secret_key_options_in_chef_extension
branch
from
79d0dd4 to
debdc3a
Compare
|
@cormacpayne I have re-based the branch with dev. |
| @@ -29,6 +29,10 @@ | |||
| - FullBackupWindowInHours : Specifies the window (in hours) when Sql Server Full Backup should occur. | |||
| - LogBackupFrequencyInMinutes : Specifies the frequency of Sql Server Log Backup. | |||
| * New-AzureVMSqlServer* cmdlets are renamed to New-AzureRmVMSqlServer* now. Old ones will continue to work however. | |||
| * Updated Set-AzureRmVMChefExtension cmdlet to add following new options : | |||
There was a problem hiding this comment.
This shoudl go in the 'Current Release' section
| @@ -33,6 +33,14 @@ public void TestSetAzureVMChefExtension() | |||
| this.RunPowerShellTest("Test-SetAzureVMChefExtension"); | |||
| } | |||
|
|
|||
| [Fact] | |||
| [Trait(Category.AcceptanceType, Category.CheckIn)] | |||
| [Trait(Category.AcceptanceType, Category.BVT)] | |||
There was a problem hiding this comment.
No need for the BVT trait, check-in tests are always included in every run
| @@ -27,6 +27,10 @@ | |||
| - FullBackupStartHour : Specifies the hour of the day when the Sql Server Full Backup should start. | |||
| - FullBackupWindowInHours : Specifies the window (in hours) when Sql Server Full Backup should occur. | |||
| - LogBackupFrequencyInMinutes : Specifies the frequency of Sql Server Log Backup. | |||
| * Updated Set-AzureVMChefExtension cmdlet to add following new options : | |||
There was a problem hiding this comment.
same comment - this belongs in the 'current release' section
| @@ -162,6 +162,7 @@ | |||
| <string>ServiceManagement\\Common\\Commands.ScenarioTest\\Resources\\RdfeTestDummy.publishsettings</string> | |||
| <string>ServiceManagement\\Common\\Commands.ScenarioTest\\Resources\\ChefExtension\\client.rb</string> | |||
| <string>ServiceManagement\\Common\\Commands.ScenarioTest\\Resources\\ChefExtension\\tstorgnztn-validator.pem</string> | |||
| <string>ServiceManagement\\Common\\Commands.ScenarioTest\\Resources\\ChefExtension\\encrypted_data_bag_secret</string> | |||
There was a problem hiding this comment.
Please ensure that this new file does not represent a credentials used anywhere in azure - it would be a security breach to include a real credential.
There was a problem hiding this comment.
@markcowl yes..this is not a real credential.
| @@ -13015,6 +13015,24 @@ PS C:\> Set-AzureRmVMBootDiagnostics -VM $VM -Enable -ResourceGroupName "Reso | |||
| <maml:uri /></dev:type> | |||
| <dev:defaultValue>None</dev:defaultValue> | |||
| </command:parameter> | |||
| <command:parameter required="false" variableLength="true" globbing="false" pipelineInput="True (ByPropertyName)" position="named" aliases="none"><maml:name>Secret</maml:name> | |||
| <maml:Description><maml:para>The encryption key used to encrypt and decrypt the data bag item values. | |||
There was a problem hiding this comment.
Please make these changes to the markdoan file here: https://github.com/Azure/azure-powershell/blob/dev/src/ResourceManager/Compute/Commands.Compute/help/Set-AzureRmVMChefExtension.md and add regenerate the help xml.
There was a problem hiding this comment.
@markcowl I have fixed all the review comments. Just I did not understand this part add regenerate the help xml. from the above comment, can you elaborate this part as I am not aware of this.
There was a problem hiding this comment.
Our help now resides in Markdown files. See: https://github.com/Azure/azure-powershell/blob/dev/documentation/platyPSHelp-documentation.md for details. This is designed to make it easire for you to update the help for cmdlets, in this case, because you used a different mechanism, it's an extra step, but next time, this should make it easier.
Signed-off-by: aliasgar16 <[email protected]>
…s and daemon option for ARM commands. Signed-off-by: aliasgar16 <[email protected]>
Signed-off-by: aliasgar16 <[email protected]>
Signed-off-by: aliasgar16 <[email protected]>
Signed-off-by: aliasgar16 <[email protected]>
Signed-off-by: aliasgar16 <[email protected]>
Aliasgar16
force-pushed
the
ali/add_daemon_and_databag_secret_key_options_in_chef_extension
branch
from
debdc3a to
ebfb8b4
Compare
Signed-off-by: aliasgar16 <[email protected]>
Done.