-
Notifications
You must be signed in to change notification settings - Fork 4k
Post-release serialization of cmdlets for breaking change tool #3403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @cormacpayne, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution! TTYL, AZPRBOT; |
@@ -1,2 +0,0 @@ | |||
"AssemblyFileName","ClassName","Target","Severity","ProblemId","Description","Remediation" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like Azure.AnalysisServices did not make it in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also Commands.ResourceManager.Cmdlets is not included. We should look at all our commands dlls and compare them to the list in SerializedCmdflets to ensure there are no other omissions.
Note: this is OK to merge as is, but we must add serializations for the additional assemblies ASAP.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@markcowl fixed
de1b26b
to
592b351
Compare
@azuresdkci test this please |
13fbaab
to
d530e27
Compare
Description
After the release of Azure PowerShell, serialize cmdlets and remove all existing exceptions that had been added for the breaking change tool.
This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.
General Guidelines
Testing Guidelines
Cmdlet Signature Guidelines
ShouldProcess
and haveSupportShouldProcess=true
specified in the cmdlet attribute. You can find more information onShouldProcess
here.OutputType
attribute if any output is produced - if the cmdlet produces no output, it should implement aPassThru
parameter.Cmdlet Parameter Guidelines