-
Notifications
You must be signed in to change notification settings - Fork 4k
Post-release serialization of cmdlets for breaking change tool #3403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
d530e27
Serialize cmdlets and change method for finding dll files
cormacpayne 0e184fa
Merge branch 'dev' into regenerate-cmdlets
cormacpayne 45ab56f
Fix directory path for BreakingChangeAnalyzer
cormacpayne 1f946cc
Merge branch 'regenerate-cmdlets' of https://github.com/cormacpayne/a…
cormacpayne File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,2 @@ | ||
"AssemblyFileName","ClassName","Target","Severity","ProblemId","Description","Remediation" | ||
"Microsoft.Azure.Commands.Sql.dll","Microsoft.Azure.Commands.Sql.Auditing.Cmdlet.RemoveSqlDatabaseAuditing","Remove-AzureRmSqlDatabaseAuditing","0","1010","The cmdlet 'Remove-AzureRmSqlDatabaseAuditing' no longer supports the alias 'Remove-AzureRmSqlDatabaseAuditing'.","Add the alias 'Remove-AzureRmSqlDatabaseAuditing back to the cmdlet 'Remove-AzureRmSqlDatabaseAuditing'." | ||
"Microsoft.Azure.Commands.Sql.dll","Microsoft.Azure.Commands.Sql.ImportExport.Cmdlet.NewAzureSqlDatabaseImport","New-AzureRmSqlDatabaseImport","0","2020","The cmdlet 'New-AzureRmSqlDatabaseImport' no longer supports the type 'Int32' for parameter 'DatabaseMaxSizeBytes'.","Change the type for parameter 'DatabaseMaxSizeBytes' back to 'Int32'." | ||
"AssemblyFileName","ClassName","Target","Severity","ProblemId","Description","Remediation" | ||
"Microsoft.Azure.Commands.Sql.dll","Microsoft.Azure.Commands.Sql.ImportExport.Cmdlet.NewAzureSqlDatabaseImport","New-AzureRmSqlDatabaseImport","0","2020","The cmdlet 'New-AzureRmSqlDatabaseImport' no longer supports the type 'Int32' for parameter 'DatabaseMaxSizeBytes'.","Change the type for parameter 'DatabaseMaxSizeBytes' back to 'Int32'." |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like Azure.AnalysisServices did not make it in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also Commands.ResourceManager.Cmdlets is not included. We should look at all our commands dlls and compare them to the list in SerializedCmdflets to ensure there are no other omissions.
Note: this is OK to merge as is, but we must add serializations for the additional assemblies ASAP.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@markcowl fixed