Skip to content

ADLA and ADLS Update: Compute Policy, Job Recurrence, App ID and Key Rotation #4136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 20, 2017
Merged

ADLA and ADLS Update: Compute Policy, Job Recurrence, App ID and Key Rotation #4136

merged 6 commits into from
Jun 20, 2017

Conversation

begoldsm
Copy link
Contributor

@begoldsm begoldsm commented Jun 14, 2017 •
edited by azuresdkci
Loading

Description

This set of changes does the following:
1. Update PowerShell to support Compute Policy CRUD cmdlets
2. Update for Job Relationship (pipeline and recurrence)
3. Update for Resource App ID for ADLA and ADLS FE services
4. Updates for Key rotation for user managed key vault keys

This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.
  • The pull request does not introduce breaking changes (unless a major version change occurs in the assembly and module).

Testing Guidelines

  • Pull request includes test coverage for the included changes.
  • PowerShell scripts used in tests should do any necessary setup as part of the test or suite setup, and should not use hard-coded values for locations or existing resources.

Cmdlet Signature Guidelines

  • New cmdlets that make changes or have side effects should implement ShouldProcess and have SupportShouldProcess=true specified in the cmdlet attribute. You can find more information on ShouldProcess here.
  • Cmdlet specifies OutputType attribute if any output is produced - if the cmdlet produces no output, it should implement a PassThru parameter.

Cmdlet Parameter Guidelines

  • Parameter types should not expose types from the management library - complex parameter types should be defined in the module.
  • Complex parameter types are discouraged - a parameter type should be simple types as often as possible. If complex types are used, they should be shallow and easily creatable from a constructor or another cmdlet.
  • Cmdlet parameter sets should be mutually exclusive - each parameter set must have at least one mandatory parameter not in other parameter sets.

initial prep for new ADLA cmdlets.
cdc12c1 
Update to official ADLA sdk package.

Update help based on feedback.

Updates to support data lake resource ID auth.

Update for Submit-Job to include relationship

Flesh out all of the commands.

Next step is adding in the tests.

Add tests for new cmdlets

Update help

update an incorrect copy/paste for help
begoldsm added 3 commits June 15, 2017 10:47
Fix test and add new recordings.
abc6bb7 
The AzureRMProfileTest hardcodes an expected json object, which is
incredibly dangerous and fragile. In this case, I just updated the json
string to resemble exactly what is output, including the new properties
that I added.
revert ordering change
bb828c6 
This is why direct comparison of string tests are bad for json objects.
In visual studio Environment comes first, but when run outside of
visualstudio Account comes first.
revert breaking change and add exceptions
8142d9f
@cormacpayne
Copy link
Member

On-demand: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-demand/1676/

@begoldsm
Copy link
Contributor Author

@cormacpayne on demand failed, but I have no idea why, none of the build artifacts in the run indicate there was a failure that I can see. Can you take a look?

@begoldsm
Copy link
Contributor Author

@cormacpayne new on demand: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-demand/1684/

cormacpayne
cormacpayne approved these changes Jun 20, 2017
View reviewed changes
Copy link
Member

@cormacpayne cormacpayne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

...Analytics/Commands.DataLakeAnalytics/Commands/RemoveAzureRmDataLakeAnalyticsComputePolicy.cs
{
[Cmdlet(VerbsCommon.Remove, "AzureRmDataLakeAnalyticsComputePolicy", SupportsShouldProcess = true), OutputType(typeof(bool))]
[Alias("Remove-AdlAnalyticsComputePolicy")]
public class RemoveAzureDataLakeAnalyticsComputePolicy : DataLakeAnalyticsCmdletBase
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We talked about adding InputObject parameter (and parameter set) to this cmdlet (and all cmdlets that follow that this would apply to) in our cmdlet review and decided against it for now until we had a more pipeline focused review with @begoldsm and his PM

@cormacpayne cormacpayne merged commit a714fae into Azure:preview Jun 20, 2017
@begoldsm begoldsm deleted the job_recurrence branch June 21, 2017 17:47
@begoldsm begoldsm mentioned this pull request Nov 10, 2017
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cormacpayne cormacpayne cormacpayne approved these changes

Assignees

@cormacpayne cormacpayne

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@begoldsm @cormacpayne @azuresdkci @msftclas