[ADL] - Fixing AzureEnvironment to use DataLake audience

[ro-joowan]

• Fixing some of the methods in AzureEnvironmentExtensions.cs that do not carry over the DataLakeAudience

  • TryGetEndpointString
  • CopyFrom
  • Update

• Adding DataLakeAudience to some of the Profile tests

Description

---

This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.

• I have read the contribution guidelines.
• If changes were made to any cmdlet, the XML help was regenerated using the platyPSHelp module.
• If any large changes are made to a service, they are reflected in the respective change log.

General Guidelines

• Title of the pull request is clear and informative.
• There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.
• The pull request does not introduce breaking changes (unless a major version change occurs in the assembly and module).

Testing Guidelines

• Pull request includes test coverage for the included changes.
• PowerShell scripts used in tests should do any necessary setup as part of the test or suite setup, and should not use hard-coded values for locations or existing resources.

Cmdlet Signature Guidelines

• New cmdlets that make changes or have side effects should implement ShouldProcess and have SupportShouldProcess=true specified in the cmdlet attribute. You can find more information on ShouldProcess here.
• Cmdlet specifies OutputType attribute if any output is produced - if the cmdlet produces no output, it should implement a PassThru parameter.

Cmdlet Parameter Guidelines

• Parameter types should not expose types from the management library - complex parameter types should be defined in the module.
• Complex parameter types are discouraged - a parameter type should be simple types as often as possible. If complex types are used, they should be shallow and easily creatable from a constructor or another cmdlet.
• Cmdlet parameter sets should be mutually exclusive - each parameter set must have at least one mandatory parameter not in other parameter sets.

[ro-joowan]

Since I am not too familiar with the Profile code base, it would be reassuring if the reviewer paid extra attention to my changes. What I do know for sure is that this fix here is needed, but I do not know is if this fix is comprehensive. That is, making sure that the AzureEnvironment uses the default DataLakeAudience ("https://datalake.azure.net") for all of ADL data-plane cmdlets, if the user does not set the DataLakeAudience manually.

• For example, in AddAzureRmEnvironment and SetAzureRmEnvironment, I see that @begoldsm set the DataLakeAudience in the else-block of the "this.ParameterSetName.Equals(MetadataParameterSet, StringComparison.Ordinal)" if-statement, and I think we can keep it that way.

• Also, it would be helpful to know if AddAzureRmAccount always uses the default DataLakeAudience if the Environment parameter is not provided by the user. It seems to me that this is the case because the default environment is AzureCloud, which uses the default DataLakeAudience.

[markcowl]

on demand run here:https://azuresdkci.westus2.cloudapp.azure.com/view/PowerShell/job/powershell-demand/144/

[begoldsm]

@ro-joowan this looks good to me! I am curious, was this a change in how AzurePS handles the environment strings, because I thought that I already set the audience strings when they were also updated for the SDK (or was that not the case?)

[ro-joowan]

@begoldsm Thanks! (and it's good to hear from you 😃) Are you referring to this change? [AzureEnvironment.cs - Line 55]

The change here addresses cmdlets like Get-AzureRmEnvironment and Set-AzureRmContext, which rely on the PSAzureEnvironment(IAzureEnvironment environment) copy constructor. But the CopyFrom() method in that constructor does not carry over the DataLake audience.

[begoldsm]

Ah, that makes sense. Yes, I was referring to this PR: #4136 which added those initial changes. Good find! Don't mind me, just occasionally lurking in the Azure repo still 😄