Skip to content

Networkacl code change revert #4210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 28, 2017
Merged

Conversation

blueww
Copy link
Member

@blueww blueww commented Jun 28, 2017

Description

This PR is to revert the change in the PR :#4157
Feature team has a last minute change need revert this feature in July release.

Yup, I apologize that it’s crazy and last minute, but Network wants us to delay the release of network ACLs in client to respond to feedback from senior leadership. Also, NMagent and RDAgent deployments are delayed so we’re now looking at an August public preview.

Thanks,
Dan

There are no other code change in this PR, but revert all the 4 commits in the PR #4157


This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.

General Guidelines

  • [Y ] Title of the pull request is clear and informative.
  • [Y ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.
  • [Y ] The pull request does not introduce breaking changes (unless a major version change occurs in the assembly and module).

Testing Guidelines

  • [Y ] Pull request includes test coverage for the included changes.
  • [Y ] PowerShell scripts used in tests should do any necessary setup as part of the test or suite setup, and should not use hard-coded values for locations or existing resources.

Cmdlet Signature Guidelines

  • [Y ] New cmdlets that make changes or have side effects should implement ShouldProcess and have SupportShouldProcess=true specified in the cmdlet attribute. You can find more information on ShouldProcess here.
  • [Y ] Cmdlet specifies OutputType attribute if any output is produced - if the cmdlet produces no output, it should implement a PassThru parameter.

Cmdlet Parameter Guidelines

  • [Y ] Parameter types should not expose types from the management library - complex parameter types should be defined in the module.
  • [Y ] Complex parameter types are discouraged - a parameter type should be simple types as often as possible. If complex types are used, they should be shallow and easily creatable from a constructor or another cmdlet.
  • [Y ] Cmdlet parameter sets should be mutually exclusive - each parameter set must have at least one mandatory parameter not in other parameter sets.

@blueww
Copy link
Member Author

blueww commented Jun 28, 2017

@cormacpayne cormacpayne merged commit ad9ef17 into Azure:preview Jun 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants