-
Notifications
You must be signed in to change notification settings - Fork 4k
Add cmdlets to management Network ACL #4324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Update the output format of Get/Update-AzureRmStorageAccountNetworkRuleSet (already discuss and agreed with Mark online), On Demand test run again in : http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-demand/1763/ |
@@ -222,6 +234,19 @@ Accept pipeline input: True (ByPropertyName) | |||
Accept wildcard characters: False | |||
``` | |||
|
|||
### -NetworkRule | |||
Storage Account NetworkRule```yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -328,6 +349,19 @@ Accept pipeline input: True (ByPropertyName) | |||
Accept wildcard characters: False | |||
``` | |||
|
|||
### -NetworkRule | |||
Storage Account NetworkRule```yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cormacpayne Thanks! |
} | ||
} | ||
|
||
[Parameter( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the future, I woudl consider a separate parameter set with string parameters for NetworkRuleId and IPAddressOrRange - this would make this cmdlet parallel with the create cmdlet
Changes have been made as specified
Description
Add Cmdlets to manage NetworkRule for Vnet.
The code logic is same with the before PR #4210, but some name change and output format change as feature team requested.
This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.
General Guidelines
Testing Guidelines
Cmdlet Signature Guidelines
ShouldProcess
and haveSupportShouldProcess=true
specified in the cmdlet attribute. You can find more information onShouldProcess
here.OutputType
attribute if any output is produced - if the cmdlet produces no output, it should implement aPassThru
parameter.Cmdlet Parameter Guidelines