Skip to content

Add cmdlets to management Network ACL #4324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 31, 2017
Merged

Conversation

EmmaZhu
Copy link
Member

@EmmaZhu EmmaZhu commented Jul 18, 2017

Description

Add Cmdlets to manage NetworkRule for Vnet.

The code logic is same with the before PR #4210, but some name change and output format change as feature team requested.


This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.

General Guidelines

  • [Y] Title of the pull request is clear and informative.
  • [Y] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.
  • Y] The pull request does not introduce breaking changes (unless a major version change occurs in the assembly and module).

Testing Guidelines

  • [Y ] Pull request includes test coverage for the included changes.
  • [Y ] PowerShell scripts used in tests should do any necessary setup as part of the test or suite setup, and should not use hard-coded values for locations or existing resources.

Cmdlet Signature Guidelines

  • [Y ] New cmdlets that make changes or have side effects should implement ShouldProcess and have SupportShouldProcess=true specified in the cmdlet attribute. You can find more information on ShouldProcess here.
  • [Y ] Cmdlet specifies OutputType attribute if any output is produced - if the cmdlet produces no output, it should implement a PassThru parameter.

Cmdlet Parameter Guidelines

  • [Y ] Parameter types should not expose types from the management library - complex parameter types should be defined in the module.
  • [Y ] Complex parameter types are discouraged - a parameter type should be simple types as often as possible. If complex types are used, they should be shallow and easily creatable from a constructor or another cmdlet.
  • [ Y] Cmdlet parameter sets should be mutually exclusive - each parameter set must have at least one mandatory parameter not in other parameter sets.

@blueww
Copy link
Member

blueww commented Jul 25, 2017

@cormacpayne
Copy link
Member

@EmmaZhu @blueww I had to stop the on-demand job since there is an issue with the on-demand and sign jobs hanging during help generation. I'll get the fix out, pull it into this PR and kick off another on-demand run.

@cormacpayne
Copy link
Member

@blueww blueww requested a review from markcowl July 26, 2017 01:41
@blueww
Copy link
Member

blueww commented Jul 26, 2017

Update the output format of Get/Update-AzureRmStorageAccountNetworkRuleSet (already discuss and agreed with Mark online), On Demand test run again in : http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-demand/1763/

@@ -222,6 +234,19 @@ Accept pipeline input: True (ByPropertyName)
Accept wildcard characters: False
```

### -NetworkRule
Storage Account NetworkRule```yaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EmmaZhu @blueww please make sure the ```yaml string is on a line by itself (see other parameters in this file as example). This will allow the markdown file to be rendered correctly.

@@ -328,6 +349,19 @@ Accept pipeline input: True (ByPropertyName)
Accept wildcard characters: False
```

### -NetworkRule
Storage Account NetworkRule```yaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EmmaZhu @blueww same comment

Copy link
Member

@cormacpayne cormacpayne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EmmaZhu @blueww made two minor comments. Otherwise, LGTM

@blueww
Copy link
Member

blueww commented Jul 31, 2017

@cormacpayne
The 2 comments for help has been resolved.
The on-demand test with the fix is in: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-demand/1771/

Thanks!

}
}

[Parameter(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the future, I woudl consider a separate parameter set with string parameters for NetworkRuleId and IPAddressOrRange - this would make this cmdlet parallel with the create cmdlet

@markcowl markcowl dismissed cormacpayne’s stale review July 31, 2017 03:22

Changes have been made as specified

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants