-
Notifications
You must be signed in to change notification settings - Fork 4k
New-AzureRmVm SimpleParameterSet, Strategies #5085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
db1f851
New-AzureVm SimpleParameterSet, Strategies
sergey-shandar d096345
Squashed commit of the following:
sergey-shandar 3aa77c2
Address comments:
sergey-shandar a26d6f1
XUnit
sergey-shandar c6e89ca
Explicit parameter names.
sergey-shandar 9abc791
FQDN => FullyQualifiedDomainName
sergey-shandar bc322e7
Merge from release-5.1.0
sergey-shandar bfd3311
Update AzureRM.Compute.Netcore.psd1
twitchax 3900208
Address comments.
sergey-shandar d5b96aa
Merge remote-tracking branch 'refs/remotes/azure1/release-5.1.0'
sergey-shandar 12dd95d
Test category.
sergey-shandar 352a613
Merge from 'release'
sergey-shandar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -211,4 +211,5 @@ FakesAssemblies/ | |
| /tools/*.dll | ||
| *.GhostDoc.xml | ||
| pingme.txt | ||
| groupMapping*.json | ||
| groupMapping*.json | ||
| .vscode/ | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
86 changes: 86 additions & 0 deletions
86
...ger/Common/Commands.Common.Strategies.UnitTest/Commands.Common.Strategies.UnitTest.csproj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,86 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <Project ToolsVersion="14.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | ||
| <Import Project="$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props" Condition="Exists('$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props')" /> | ||
| <PropertyGroup> | ||
| <Configuration Condition=" '$(Configuration)' == '' ">Debug</Configuration> | ||
| <Platform Condition=" '$(Platform)' == '' ">AnyCPU</Platform> | ||
| <ProjectGuid>{6756A7F2-1141-4065-BA23-0C555D2A2BC3}</ProjectGuid> | ||
| <OutputType>Library</OutputType> | ||
| <AppDesignerFolder>Properties</AppDesignerFolder> | ||
| <RootNamespace>Microsoft.Azure.Commands.Common.Strategies.UnitTest</RootNamespace> | ||
| <AssemblyName>Microsoft.Azure.Commands.Common.Strategies.UnitTest</AssemblyName> | ||
| <TargetFrameworkVersion>v4.5.2</TargetFrameworkVersion> | ||
| <FileAlignment>512</FileAlignment> | ||
| </PropertyGroup> | ||
| <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|AnyCPU' "> | ||
| <DebugSymbols>true</DebugSymbols> | ||
| <DebugType>full</DebugType> | ||
| <Optimize>false</Optimize> | ||
| <OutputPath>bin\Debug\</OutputPath> | ||
| <DefineConstants>DEBUG;TRACE</DefineConstants> | ||
| <ErrorReport>prompt</ErrorReport> | ||
| <WarningLevel>4</WarningLevel> | ||
| </PropertyGroup> | ||
| <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' "> | ||
| <DebugType>pdbonly</DebugType> | ||
| <Optimize>true</Optimize> | ||
| <OutputPath>bin\Release\</OutputPath> | ||
| <DefineConstants>TRACE</DefineConstants> | ||
| <ErrorReport>prompt</ErrorReport> | ||
| <WarningLevel>4</WarningLevel> | ||
| </PropertyGroup> | ||
| <ItemGroup> | ||
| <Reference Include="System" /> | ||
| <Reference Include="System.Core" /> | ||
| <Reference Include="System.Xml.Linq" /> | ||
| <Reference Include="System.Data.DataSetExtensions" /> | ||
| <Reference Include="Microsoft.CSharp" /> | ||
| <Reference Include="System.Data" /> | ||
| <Reference Include="System.Net.Http" /> | ||
| <Reference Include="System.Xml" /> | ||
| <Reference Include="xunit.abstractions, Version=2.0.0.0, Culture=neutral, PublicKeyToken=8d05b1bb7a6fdb6c, processorArchitecture=MSIL"> | ||
| <HintPath>..\..\..\packages\xunit.abstractions.2.0.0\lib\net35\xunit.abstractions.dll</HintPath> | ||
| <Private>True</Private> | ||
| </Reference> | ||
| <Reference Include="xunit.assert, Version=2.1.0.3179, Culture=neutral, PublicKeyToken=8d05b1bb7a6fdb6c, processorArchitecture=MSIL"> | ||
| <HintPath>..\..\..\packages\xunit.assert.2.1.0\lib\dotnet\xunit.assert.dll</HintPath> | ||
| <Private>True</Private> | ||
| </Reference> | ||
| <Reference Include="xunit.core, Version=2.1.0.3179, Culture=neutral, PublicKeyToken=8d05b1bb7a6fdb6c, processorArchitecture=MSIL"> | ||
| <HintPath>..\..\..\packages\xunit.extensibility.core.2.1.0\lib\dotnet\xunit.core.dll</HintPath> | ||
| <Private>True</Private> | ||
| </Reference> | ||
| <Reference Include="xunit.execution.desktop, Version=2.1.0.3179, Culture=neutral, PublicKeyToken=8d05b1bb7a6fdb6c, processorArchitecture=MSIL"> | ||
| <HintPath>..\..\..\packages\xunit.extensibility.execution.2.1.0\lib\net45\xunit.execution.desktop.dll</HintPath> | ||
| <Private>True</Private> | ||
| </Reference> | ||
| </ItemGroup> | ||
| <ItemGroup> | ||
| <Compile Include="Properties\AssemblyInfo.cs" /> | ||
| <Compile Include="TimeSlotTest.cs" /> | ||
| </ItemGroup> | ||
| <ItemGroup> | ||
| <None Include="packages.config" /> | ||
| </ItemGroup> | ||
| <ItemGroup> | ||
| <ProjectReference Include="..\Commands.Common.Strategies\Commands.Common.Strategies.csproj"> | ||
| <Project>{eea69772-d41b-482a-9252-2b4595c59e53}</Project> | ||
| <Name>Commands.Common.Strategies</Name> | ||
| </ProjectReference> | ||
| <ProjectReference Include="..\Commands.ScenarioTests.ResourceManager.Common\Commands.ScenarioTests.ResourceManager.Common.csproj"> | ||
| <Project>{3436a126-edc9-4060-8952-9a1be34cdd95}</Project> | ||
| <Name>Commands.ScenarioTests.ResourceManager.Common</Name> | ||
| </ProjectReference> | ||
| </ItemGroup> | ||
| <ItemGroup> | ||
| <Service Include="{82A7F48D-3B50-4B1E-B82E-3ADA8210C358}" /> | ||
| </ItemGroup> | ||
| <Import Project="$(MSBuildToolsPath)\Microsoft.CSharp.targets" /> | ||
| <!-- To modify your build process, add your task inside one of the targets below and uncomment it. | ||
| Other similar extension points exist, see Microsoft.Common.targets. | ||
| <Target Name="BeforeBuild"> | ||
| </Target> | ||
| <Target Name="AfterBuild"> | ||
| </Target> | ||
| --> | ||
| </Project> |
36 changes: 36 additions & 0 deletions
36
src/ResourceManager/Common/Commands.Common.Strategies.UnitTest/Properties/AssemblyInfo.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| using System.Reflection; | ||
| using System.Runtime.CompilerServices; | ||
| using System.Runtime.InteropServices; | ||
|
|
||
| // General Information about an assembly is controlled through the following | ||
| // set of attributes. Change these attribute values to modify the information | ||
| // associated with an assembly. | ||
| [assembly: AssemblyTitle("Commands.Common.Strategies.UnitTest")] | ||
| [assembly: AssemblyDescription("")] | ||
| [assembly: AssemblyConfiguration("")] | ||
| [assembly: AssemblyCompany("")] | ||
| [assembly: AssemblyProduct("Commands.Common.Strategies.UnitTest")] | ||
| [assembly: AssemblyCopyright("Copyright © Microsoft 2017")] | ||
| [assembly: AssemblyTrademark("")] | ||
| [assembly: AssemblyCulture("")] | ||
|
|
||
| // Setting ComVisible to false makes the types in this assembly not visible | ||
| // to COM components. If you need to access a type in this assembly from | ||
| // COM, set the ComVisible attribute to true on that type. | ||
| [assembly: ComVisible(false)] | ||
|
|
||
| // The following GUID is for the ID of the typelib if this project is exposed to COM | ||
| [assembly: Guid("6756a7f2-1141-4065-ba23-0c555d2a2bc3")] | ||
|
|
||
| // Version information for an assembly consists of the following four values: | ||
| // | ||
| // Major Version | ||
| // Minor Version | ||
| // Build Number | ||
| // Revision | ||
| // | ||
| // You can specify all the values or you can default the Build and Revision Numbers | ||
| // by using the '*' as shown below: | ||
| // [assembly: AssemblyVersion("1.0.*")] | ||
| [assembly: AssemblyVersion("1.0.0.0")] | ||
| [assembly: AssemblyFileVersion("1.0.0.0")] |
87 changes: 87 additions & 0 deletions
87
src/ResourceManager/Common/Commands.Common.Strategies.UnitTest/TimeSlotTest.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,87 @@ | ||
| // ---------------------------------------------------------------------------------- | ||
| // | ||
| // Copyright Microsoft Corporation | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
| // ---------------------------------------------------------------------------------- | ||
|
|
||
| using Microsoft.WindowsAzure.Commands.ScenarioTest; | ||
| using Xunit; | ||
|
|
||
| namespace Microsoft.Azure.Commands.Common.Strategies.UnitTest | ||
| { | ||
| public class TimeSlotTest | ||
| { | ||
| [Fact] | ||
| [Trait(Category.AcceptanceType, Category.CheckIn)] | ||
| public void AddTest() | ||
| { | ||
| var first = new TimeSlot(); | ||
|
|
||
| Assert.Equal(0, first.Duration); | ||
| Assert.Equal(0, first.TaskCount); | ||
| Assert.Equal(null, first.Next); | ||
|
|
||
| var next = first.AddTask(50); | ||
|
|
||
| Assert.Equal(50, first.Duration); | ||
| Assert.Equal(1, first.TaskCount); | ||
| Assert.Equal(next, first.Next); | ||
|
|
||
| Assert.Equal(10.0, first.GetTaskProgress(10)); | ||
|
|
||
| Assert.Equal(0, next.Duration); | ||
| Assert.Equal(0, next.TaskCount); | ||
| Assert.Equal(null, next.Next); | ||
|
|
||
| var next2 = first.AddTask(50); | ||
|
|
||
| Assert.Equal(50, first.Duration); | ||
| Assert.Equal(2, first.TaskCount); | ||
| Assert.Equal(next2, first.Next); | ||
| Assert.Equal(next, first.Next); | ||
|
|
||
| Assert.Equal(20.0, first.GetTaskProgress(40)); | ||
|
|
||
| Assert.Equal(0, next2.Duration); | ||
| Assert.Equal(0, next2.TaskCount); | ||
| Assert.Equal(null, next2.Next); | ||
|
|
||
| var next3 = first.AddTask(30); | ||
| Assert.Equal(30, first.Duration); | ||
| Assert.Equal(3, first.TaskCount); | ||
| Assert.Equal(next3, first.Next); | ||
|
|
||
| Assert.Equal(3.0, first.GetTaskProgress(9)); | ||
|
|
||
| Assert.Equal(20, next3.Duration); | ||
| Assert.Equal(2, next3.TaskCount); | ||
| Assert.Equal(next2, next3.Next); | ||
| Assert.Equal(next, next3.Next); | ||
|
|
||
| Assert.Equal(10.0 + 5, first.GetTaskProgress(40)); | ||
|
|
||
| Assert.Equal(0, next2.Duration); | ||
| Assert.Equal(0, next2.TaskCount); | ||
| Assert.Equal(null, next2.Next); | ||
|
|
||
| var next4 = first.AddTask(75); | ||
| Assert.Equal(25, next2.Duration); | ||
| Assert.Equal(1, next2.TaskCount); | ||
| Assert.Equal(next4, next2.Next); | ||
|
|
||
| Assert.Equal((30.0 / 4) + (20.0 / 3) + 20, first.GetTaskProgress(70)); | ||
|
|
||
| Assert.Equal(0, next4.Duration); | ||
| Assert.Equal(0, next4.TaskCount); | ||
| Assert.Equal(null, next4.Next); | ||
| } | ||
| } | ||
| } |
9 changes: 9 additions & 0 deletions
9
src/ResourceManager/Common/Commands.Common.Strategies.UnitTest/packages.config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <packages> | ||
| <package id="xunit" version="2.1.0" targetFramework="net452" /> | ||
| <package id="xunit.abstractions" version="2.0.0" targetFramework="net452" /> | ||
| <package id="xunit.assert" version="2.1.0" targetFramework="net452" /> | ||
| <package id="xunit.core" version="2.1.0" targetFramework="net452" /> | ||
| <package id="xunit.extensibility.core" version="2.1.0" targetFramework="net452" /> | ||
| <package id="xunit.extensibility.execution" version="2.1.0" targetFramework="net452" /> | ||
| </packages> |
104 changes: 104 additions & 0 deletions
104
src/ResourceManager/Common/Commands.Common.Strategies/Commands.Common.Strategies.csproj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,104 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <Project ToolsVersion="14.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | ||
| <Import Project="$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props" Condition="Exists('$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props')" /> | ||
| <PropertyGroup> | ||
| <Configuration Condition=" '$(Configuration)' == '' ">Debug</Configuration> | ||
| <Platform Condition=" '$(Platform)' == '' ">AnyCPU</Platform> | ||
| <ProjectGuid>{EEA69772-D41B-482A-9252-2B4595C59E53}</ProjectGuid> | ||
| <OutputType>Library</OutputType> | ||
| <AppDesignerFolder>Properties</AppDesignerFolder> | ||
| <RootNamespace>Microsoft.Azure.Commands.Common.Strategies</RootNamespace> | ||
| <AssemblyName>Microsoft.Azure.Commands.Common.Strategies</AssemblyName> | ||
| <TargetFrameworkVersion>v4.5.2</TargetFrameworkVersion> | ||
| <FileAlignment>512</FileAlignment> | ||
| </PropertyGroup> | ||
| <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|AnyCPU' "> | ||
| <DebugSymbols>true</DebugSymbols> | ||
| <DebugType>full</DebugType> | ||
| <Optimize>false</Optimize> | ||
| <OutputPath>bin\Debug\</OutputPath> | ||
| <DefineConstants>TRACE;DEBUG</DefineConstants> | ||
| <ErrorReport>prompt</ErrorReport> | ||
| <WarningLevel>4</WarningLevel> | ||
| </PropertyGroup> | ||
| <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' "> | ||
| <DebugType>pdbonly</DebugType> | ||
| <Optimize>true</Optimize> | ||
| <OutputPath>bin\Release\</OutputPath> | ||
| <DefineConstants>TRACE;SIGN</DefineConstants> | ||
| <ErrorReport>prompt</ErrorReport> | ||
| <WarningLevel>4</WarningLevel> | ||
| <SignAssembly>true</SignAssembly> | ||
| <DelaySign>true</DelaySign> | ||
| <AssemblyOriginatorKeyFile>MSSharedLibKey.snk</AssemblyOriginatorKeyFile> | ||
| </PropertyGroup> | ||
| <ItemGroup> | ||
| <Reference Include="Microsoft.Rest.ClientRuntime, Version=2.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL"> | ||
| <HintPath>..\..\..\packages\Microsoft.Rest.ClientRuntime.2.3.10\lib\net452\Microsoft.Rest.ClientRuntime.dll</HintPath> | ||
| <Private>True</Private> | ||
| </Reference> | ||
| <Reference Include="Microsoft.Rest.ClientRuntime.Azure, Version=3.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL"> | ||
| <HintPath>..\..\..\packages\Microsoft.Rest.ClientRuntime.Azure.3.3.10\lib\net452\Microsoft.Rest.ClientRuntime.Azure.dll</HintPath> | ||
| <Private>True</Private> | ||
| </Reference> | ||
| <Reference Include="Newtonsoft.Json, Version=6.0.0.0, Culture=neutral, PublicKeyToken=30ad4fe6b2a6aeed, processorArchitecture=MSIL"> | ||
| <HintPath>..\..\..\packages\Newtonsoft.Json.6.0.8\lib\net45\Newtonsoft.Json.dll</HintPath> | ||
| <Private>True</Private> | ||
| </Reference> | ||
| <Reference Include="System" /> | ||
| <Reference Include="System.Core" /> | ||
| <Reference Include="System.Xml.Linq" /> | ||
| <Reference Include="System.Data.DataSetExtensions" /> | ||
| <Reference Include="Microsoft.CSharp" /> | ||
| <Reference Include="System.Data" /> | ||
| <Reference Include="System.Net.Http" /> | ||
| <Reference Include="System.Xml" /> | ||
| </ItemGroup> | ||
| <ItemGroup> | ||
| <Compile Include="IReportProgress.cs" /> | ||
| <Compile Include="IResourceConfig.cs" /> | ||
| <Compile Include="IResourceConfigVisitor.cs" /> | ||
| <Compile Include="IResourceStrategy.cs" /> | ||
| <Compile Include="IShouldProcess.cs" /> | ||
| <Compile Include="ProgressMap.cs" /> | ||
| <Compile Include="TimeSlot.cs" /> | ||
| <Compile Include="StateOperationContext.cs" /> | ||
| <Compile Include="SyncTaskScheduler.cs" /> | ||
| <Compile Include="TimeSlotExtensions.cs" /> | ||
| <Compile Include="UpdateStateExtensions.cs" /> | ||
| <Compile Include="CreateOrUpdateAsyncParams.cs" /> | ||
| <Compile Include="EntityConfigExtensions.cs" /> | ||
| <Compile Include="Extensions.cs" /> | ||
| <Compile Include="GetStateExtensions.cs" /> | ||
| <Compile Include="GetAsyncParams.cs" /> | ||
| <Compile Include="IClient.cs" /> | ||
| <Compile Include="IEntityConfig.cs" /> | ||
| <Compile Include="IEntityConfigVisitor.cs" /> | ||
| <Compile Include="IEntityStrategy.cs" /> | ||
| <Compile Include="IState.cs" /> | ||
| <Compile Include="NestedResourceConfigExtensions.cs" /> | ||
| <Compile Include="ResourceConfigExtensions.cs" /> | ||
| <Compile Include="StateExtensions.cs" /> | ||
| <Compile Include="NestedResourceConfig.cs" /> | ||
| <Compile Include="NestedResourceStrategy.cs" /> | ||
| <Compile Include="TargetStateExtensions.cs" /> | ||
| <Compile Include="Properties\AssemblyInfo.cs" /> | ||
| <Compile Include="ResourceConfig.cs" /> | ||
| <Compile Include="ResourceStrategy.cs" /> | ||
| <Compile Include="State.cs" /> | ||
| <Compile Include="LocationExtensions.cs" /> | ||
| <Compile Include="Void.cs" /> | ||
| </ItemGroup> | ||
| <ItemGroup> | ||
| <None Include="MSSharedLibKey.snk" /> | ||
| <None Include="packages.config" /> | ||
| </ItemGroup> | ||
| <Import Project="$(MSBuildToolsPath)\Microsoft.CSharp.targets" /> | ||
| <!-- To modify your build process, add your task inside one of the targets below and uncomment it. | ||
| Other similar extension points exist, see Microsoft.Common.targets. | ||
| <Target Name="BeforeBuild"> | ||
| </Target> | ||
| <Target Name="AfterBuild"> | ||
| </Target> | ||
| --> | ||
| </Project> | ||
30 changes: 30 additions & 0 deletions
30
src/ResourceManager/Common/Commands.Common.Strategies/Common.Strategies.Netcore.csproj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| <Project Sdk="Microsoft.NET.Sdk"> | ||
|
|
||
| <Import Project="..\..\..\..\tools\Common.Netcore.Dependencies.targets" /> | ||
|
|
||
| <PropertyGroup> | ||
| <TargetFramework>netcoreapp2.0</TargetFramework> | ||
| <AssemblyName>Microsoft.Azure.Commands.Common.Strategies</AssemblyName> | ||
| <RuntimeIdentifiers>win10-x64</RuntimeIdentifiers> | ||
| <RootNamespace>Microsoft.Azure.Commands.Common.Strategies</RootNamespace> | ||
| <GenerateAssemblyInfo>false</GenerateAssemblyInfo> | ||
| </PropertyGroup> | ||
|
|
||
| <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'"> | ||
| <SignAssembly>True</SignAssembly> | ||
| <DelaySign>True</DelaySign> | ||
| <AssemblyOriginatorKeyFile>MSSharedLibKey.snk</AssemblyOriginatorKeyFile> | ||
| <DefineConstants>TRACE;RELEASE;NETSTANDARD;SIGN</DefineConstants> | ||
| </PropertyGroup> | ||
|
|
||
| <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'"> | ||
| <DefineConstants>TRACE;DEBUG;NETSTANDARD</DefineConstants> | ||
| <DelaySign>false</DelaySign> | ||
| </PropertyGroup> | ||
|
|
||
| <ItemGroup Condition=" '$(TargetFramework)' == 'netcoreapp2.0' "> | ||
| <PackageReference Include="Microsoft.Azure.Management.ResourceManager" Version="1.6.0-preview" /> | ||
| <PackageReference Include="Microsoft.Azure.Management.Compute" Version="16.3.0" /> | ||
| <PackageReference Include="Microsoft.Azure.Management.Network" Version="10.1.0-preview" /> | ||
| </ItemGroup> | ||
| </Project> |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally, for common code, the output path should be
bin/<Config>and the dll is copied over by project references.Also, you need a release target that does signing and a singing key (copy from any of the common assemblies)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should it be enough for signing?
Is there anything else I should add?