New-AzureRmVm SimpleParameterSet, Strategies #5085

sergey-shandar · 2017-12-06T01:22:09Z

New-AzureRmVm SimpleParameterSet, Strategies

Description

New-AzureRmVm SimpleParameterSet
Strategies library

This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.

I have read the contribution guidelines.
If changes were made to any cmdlet, the XML help was regenerated using the platyPSHelp module.
If any large changes are made to a service, they are reflected in the respective change log.

General Guidelines

Title of the pull request is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.
The pull request does not introduce breaking changes (unless a major version change occurs in the assembly and module).

Testing Guidelines

Pull request includes test coverage for the included changes.
PowerShell scripts used in tests should do any necessary setup as part of the test or suite setup, and should not use hard-coded values for locations or existing resources.

Cmdlet Signature Guidelines

New cmdlets that make changes or have side effects should implement ShouldProcess and have SupportShouldProcess=true specified in the cmdlet attribute. You can find more information on ShouldProcess here.
Cmdlet specifies OutputType attribute if any output is produced - if the cmdlet produces no output, it should implement a PassThru parameter.

Cmdlet Parameter Guidelines

Parameter types should not expose types from the management library - complex parameter types should be defined in the module.
Complex parameter types are discouraged - a parameter type should be simple types as often as possible. If complex types are used, they should be shallow and easily creatable from a constructor or another cmdlet.
Cmdlet parameter sets should be mutually exclusive - each parameter set must have at least one mandatory parameter not in other parameter sets.

markcowl · 2017-12-06T02:38:22Z

src/Common/Commands.Common/AzureLongRunningJob.cs

@@ -191,11 +191,13 @@ public override string StatusMessage
                returnValue.MyInvocation.BoundParameters.Add(parameter.Key, parameter.Value);
            }

-            foreach (var field in returnType.GetFields(BindingFlags.Instance | BindingFlags.Public | BindingFlags.NonPublic | BindingFlags.DeclaredOnly))
+
+            foreach (var field in returnType.GetFields(BindingFlags.Instance | BindingFlags.Public | BindingFlags.NonPublic))


I mistakenly changed this line in my PR - if you pull from my PR into release-5.1.0, this line is unchanged

markcowl · 2017-12-06T02:39:25Z

src/ResourceManager/Common/Commands.Common.Strategies.UnitTest/TimeSlotTest.cs

+
+namespace Microsoft.Azure.Commands.Common.Strategies.UnitTest
+{
+    [TestClass]


These should be xunit tests, and we will also need entries for them in the testmap

I've converted the project to XUnit.

markcowl · 2017-12-06T02:41:10Z

src/ResourceManager/Common/Commands.Common.Strategies/Commands.Common.Strategies.csproj

+  <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|AnyCPU' ">
+    <DebugSymbols>true</DebugSymbols>
+    <DebugType>full</DebugType>
+    <Optimize>false</Optimize>


Generally, for common code, the output path should be bin/<Config> and the dll is copied over by project references.

Also, you need a release target that does signing and a singing key (copy from any of the common assemblies)

Should it be enough for signing?

<PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' "> <DebugType>pdbonly</DebugType> <Optimize>true</Optimize> <OutputPath>bin\Release\</OutputPath> <DefineConstants>TRACE;SIGN</DefineConstants> <ErrorReport>prompt</ErrorReport> <WarningLevel>4</WarningLevel> <SignAssembly>true</SignAssembly> <DelaySign>true</DelaySign> <AssemblyOriginatorKeyFile>MSSharedLibKey.snk</AssemblyOriginatorKeyFile> </PropertyGroup>

Is there anything else I should add?

markcowl · 2017-12-06T02:56:36Z

tools/UpdateModules.ps1

@@ -50,7 +50,7 @@ function Create-ModulePsm1
           elseif ($mod["RequiredVersion"])
           {
               $importedModules += "Import-Module " + $mod["ModuleName"] + " -RequiredVersion " + $mod["RequiredVersion"] + "`r`n"
-           }        


please revert any changes here

markcowl · 2017-12-06T02:56:49Z

tools/StaticAnalysis/HelpAnalyzer/HelpAnalyzer.cs

@@ -67,7 +67,7 @@ private static bool IsAssemblyFile(string path)
            return result;
        }
        /// <summary>
-        /// Given a set of directory paths containing PowerShell module folders, analyze the help 


please revert any changes here

markcowl · 2017-12-06T02:57:41Z

tools/StaticAnalysis/BreakingChangeAnalyzer/BreakingChangeAnalyzer.cs

@@ -41,7 +41,7 @@ public BreakingChangeAnalyzer()
        }

        /// <summary>
-        /// Given a set of directory paths containing PowerShell module folders, 


remove any changes to this file

markcowl · 2017-12-06T02:58:14Z

src/ResourceManager/Profile/Commands.Profile/Models/SimpleAccessToken.cs

@@ -50,7 +50,7 @@ public SimpleAccessToken(IAzureAccount account, string tenantId, string tokenTyp
            }
            this.UserId = account.Id;


revert any changes here

markcowl · 2017-12-06T02:58:26Z

src/ResourceManager/Network/Commands.Network/LoadBalancer/NewAzureLoadBalancerCommand.cs

@@ -190,4 +190,4 @@ private PSLoadBalancer CreateLoadBalancer()
            return getLoadBalancer;
        }


revert changes here

markcowl · 2017-12-06T02:58:37Z

src/ResourceManager/Network/Commands.Network/Commands.Network.csproj

@@ -554,6 +554,10 @@
      <Project>{5ee72c53-1720-4309-b54b-5fb79703195f}</Project>
      <Name>Commands.Common</Name>
    </ProjectReference>
+    <ProjectReference Include="..\..\Common\Commands.Common.Strategies\Commands.Common.Strategies.csproj">


revert changes here

markcowl · 2017-12-06T02:59:01Z

src/ResourceManager/Compute/Commands.Compute/packages.config

@@ -4,6 +4,11 @@
  <package id="Microsoft.Azure.KeyVault.Core" version="1.0.0" targetFramework="net45" />
  <package id="Microsoft.Azure.Management.Compute" version="17.0.0" targetFramework="net452" />
  <package id="Microsoft.Azure.Management.KeyVault" version="2.3.0-preview" targetFramework="net452" />
+  <package id="Microsoft.Azure.Management.Network" version="15.1.0-preview" targetFramework="net452" />


we should not add packages here

I removed the references.

commit f8d5d37 Merge: 198747c 0146c16 Author: Sergey Shandar <[email protected]> Date: Tue Dec 5 16:46:59 2017 -0800 Merge branch 'sergey-entity' of https://github.com/sergey-shandar/azure-powershell commit 0146c16 Merge: 9c141ae 2eedb8e Author: Sergey Shandar <[email protected]> Date: Tue Dec 5 16:19:32 2017 -0800 Merge pull request #8 from markcowl/fixparams Fix usage of parameter sets in jobs commit 2eedb8e Author: markcowl <[email protected]> Date: Tue Dec 5 16:14:56 2017 -0800 Fix usage of parameter sets in jobs commit 198747c Author: Sergey Shandar <[email protected]> Date: Tue Dec 5 14:55:34 2017 -0800 progress report update. commit 9c141ae Author: Sergey Shandar <[email protected]> Date: Tue Dec 5 13:59:35 2017 -0800 AsJob commit 8285582 Author: Cormac McCarthy <[email protected]> Date: Tue Dec 5 13:14:49 2017 -0800 Update BreakingChangeIssues.csv commit f9cd63a Author: Sergey Shandar <[email protected]> Date: Tue Dec 5 11:57:21 2017 -0800 Comments. commit ea20f72 Author: Sergey Shandar <[email protected]> Date: Tue Dec 5 11:21:05 2017 -0800 Remove rubbish commit d016c0d Author: Sergey Shandar <[email protected]> Date: Tue Dec 5 11:15:47 2017 -0800 revert NewAzureLoadBalancerCommand commit 0bddd80 Author: Sergey Shandar <[email protected]> Date: Tue Dec 5 11:13:48 2017 -0800 Revert VMSS. commit 8c5d5f8 Merge: 572b642 1f2e6b7 Author: Sergey Shandar <[email protected]> Date: Tue Dec 5 11:10:10 2017 -0800 merge from no-sdk commit 572b642 Merge: 68b354d 78d3aae Author: Sergey Shandar <[email protected]> Date: Tue Dec 5 10:59:56 2017 -0800 Merge from preview commit 1f2e6b7 Author: Sergey Shandar <[email protected]> Date: Tue Dec 5 10:51:05 2017 -0800 update time for windows commit 6831544 Author: Sergey Shandar <[email protected]> Date: Mon Dec 4 17:13:09 2017 -0800 ImageName completer. commit 68b354d Author: Hovsep Mkrtchyan <[email protected]> Date: Mon Dec 4 16:10:56 2017 -0800 Fixed build breaks commit 3ac09fc Author: Hovsep Mkrtchyan <[email protected]> Date: Mon Dec 4 16:06:34 2017 -0800 fixed Compute.csproj commit 05516e5 Merge: bfb518a d5cbdcc Author: Hovsep Mkrtchyan <[email protected]> Date: Mon Dec 4 16:06:10 2017 -0800 Merge branch 'sergey-entity' of https://github.com/sergey-shandar/azure-powershell into sergey-entity # Conflicts: # src/ResourceManager/Common/Commands.Common.Strategies/Commands.Common.Strategies.csproj commit 3cb9ccf Author: Sergey Shandar <[email protected]> Date: Mon Dec 4 15:46:09 2017 -0800 internal members. commit 143153b Author: Sergey Shandar <[email protected]> Date: Mon Dec 4 15:01:40 2017 -0800 Use new SDK. commit 0ce5261 Merge: c757df2 5f34994 Author: Sergey Shandar <[email protected]> Date: Mon Dec 4 14:43:14 2017 -0800 Merge branch 'sergey-internal-network-2017-10-01' commit c757df2 Author: Sergey Shandar <[email protected]> Date: Mon Dec 4 13:13:07 2017 -0800 no sdk (broken, no NetworkSecurityGroup and no VirtualNetwork) commit d5cbdcc Merge: 2dd8a43 97d297d Author: Sergey Shandar <[email protected]> Date: Mon Dec 4 11:33:08 2017 -0800 Merge branch 'sergey-entity' of https://github.com/sergey-shandar/azure-powershell commit 2dd8a43 Author: Sergey Shandar <[email protected]> Date: Mon Dec 4 11:24:15 2017 -0800 minor comment commit 87b9def Author: Sergey Shandar <[email protected]> Date: Sun Dec 3 14:00:29 2017 -0800 ProgressMap commit 97d297d Merge: 56a866a ce56917 Author: Sergey Shandar <[email protected]> Date: Sun Dec 3 11:55:50 2017 -0800 Merge pull request #7 from twitchax/sergey-entity Netcore for Strategies. commit 4def246 Author: Sergey Shandar <[email protected]> Date: Sun Dec 3 11:53:27 2017 -0800 Progress. commit 0e90f00 Author: Sergey Shandar <[email protected]> Date: Fri Dec 1 14:29:05 2017 -0800 ConcurrentTeskProgress commit dfab985 Author: Sergey Shandar <[email protected]> Date: Fri Dec 1 13:46:35 2017 -0800 TimeSlots commit ce56917 Author: Aaron Roney <[email protected]> Date: Thu Nov 30 23:30:57 2017 -0800 Netcore for Strategies. commit bfb518a Merge: 2f71f18 56a866a Author: Hovsep Mkrtchyan <[email protected]> Date: Thu Nov 30 15:22:29 2017 -0800 Merge branch 'sergey-entity' of https://github.com/sergey-shandar/azure-powershell into sergey-entity commit 56a866a Author: Sergey Shandar <[email protected]> Date: Thu Nov 30 15:10:58 2017 -0800 size commit 5d6cb34 Author: Sergey Shandar <[email protected]> Date: Thu Nov 30 14:58:48 2017 -0800 NetworkSecurityGroup as an optional parameter in NetworkInterface. commit 7c247af Author: Sergey Shandar <[email protected]> Date: Thu Nov 30 14:43:19 2017 -0800 FQDN commit c7c883f Merge: 3ed267b b82f28b Author: Sergey Shandar <[email protected]> Date: Thu Nov 30 14:33:15 2017 -0800 Merge remote-tracking branch 'refs/remotes/azure1/preview' commit 3ed267b Author: Sergey Shandar <[email protected]> Date: Thu Nov 30 14:32:37 2017 -0800 handle exception commit 2f71f18 Merge: db0f83e 54a26f7 Author: Hovsep Mkrtchyan <[email protected]> Date: Thu Nov 30 13:40:48 2017 -0800 Merge branch 'sergey-entity' of https://github.com/sergey-shandar/azure-powershell into sergey-entity commit db0f83e Author: Hovsep Mkrtchyan <[email protected]> Date: Thu Nov 30 13:40:41 2017 -0800 VMSS simple cmdlets commit 54a26f7 Merge: 526b4b7 b8868f3 Author: Sergey Shandar <[email protected]> Date: Thu Nov 30 12:21:11 2017 -0800 merge from preview commit 526b4b7 Author: Sergey Shandar <[email protected]> Date: Thu Nov 30 12:19:39 2017 -0800 SyncTaskScheduler as a separete class. commit 9176172 Author: Sergey Shandar <[email protected]> Date: Wed Nov 29 20:20:50 2017 -0800 copyrights. commit bda3fba Merge: bcb9a26 56a843d Author: Sergey Shandar <[email protected]> Date: Wed Nov 29 18:47:51 2017 -0800 Merge branch 'sergey-entity' of https://github.com/sergey-shandar/azure-powershell commit bcb9a26 Author: Sergey Shandar <[email protected]> Date: Wed Nov 29 18:47:40 2017 -0800 MessageLoop, kind of. commit 56a843d Merge: dba029c b049751 Author: Sergey Shandar <[email protected]> Date: Wed Nov 29 16:25:17 2017 -0800 Merge pull request #6 from twitchax/sergey-entity Doc updates to New-AzureRmVM. commit dba029c Author: Sergey Shandar <[email protected]> Date: Wed Nov 29 11:50:10 2017 -0800 imagename case insensetive commit b049751 Author: Aaron Roney <[email protected]> Date: Wed Nov 29 00:05:37 2017 -0800 Doc updates to New-AzureRmVM. commit b5d723f Author: Sergey Shandar <[email protected]> Date: Tue Nov 28 15:31:33 2017 -0800 Copyrights commit e5abfd7 Author: Sergey Shandar <[email protected]> Date: Tue Nov 28 15:19:38 2017 -0800 wix fix. commit 8d283d1 Author: Sergey Shandar <[email protected]> Date: Tue Nov 28 15:19:05 2017 -0800 Revert "wix fix." This reverts commit 68c13e4. commit 68c13e4 Author: Sergey Shandar <[email protected]> Date: Tue Nov 28 15:18:36 2017 -0800 wix fix. commit 7b0c756 Author: Sergey Shandar <[email protected]> Date: Tue Nov 28 14:55:09 2017 -0800 Wix fix. commit ac3371c Author: Sergey Shandar <[email protected]> Date: Tue Nov 28 14:26:18 2017 -0800 Fix Azurecmdfiles.wxi commit 9db6d0d Author: Sergey Shandar <[email protected]> Date: Tue Nov 28 14:02:00 2017 -0800 IReportProgress commit ace1441 Author: Sergey Shandar <[email protected]> Date: Mon Nov 27 17:28:21 2017 -0800 ShouldProcess commit 901660a Author: Sergey Shandar <[email protected]> Date: Mon Nov 27 16:27:51 2017 -0800 WiX commit b41234e Author: Sergey Shandar <[email protected]> Date: Mon Nov 27 15:32:26 2017 -0800 NetworkSecurityGroup bug fix. commit c6b0f02 Author: Sergey Shandar <[email protected]> Date: Mon Nov 27 15:12:35 2017 -0800 NestedResource bug fix. commit eb69566 Merge: d691559 953f434 Author: Sergey Shandar <[email protected]> Date: Mon Nov 27 12:30:01 2017 -0800 Merge branch 'sergey-entity' of https://github.com/sergey-shandar/azure-powershell commit d691559 Author: Sergey Shandar <[email protected]> Date: Mon Nov 27 12:29:50 2017 -0800 Image name commit 953f434 Author: Cormac McCarthy <[email protected]> Date: Mon Nov 27 08:56:23 2017 -0800 Update BreakingChangeIssues.csv commit 03392cf Author: Sergey Shandar <[email protected]> Date: Thu Nov 23 15:11:21 2017 -0800 Get Image. commit 710c963 Author: Sergey Shandar <[email protected]> Date: Thu Nov 23 11:08:13 2017 -0800 minor commit 4e1df72 Merge: 1786a18 0a3403d Author: Sergey Shandar <[email protected]> Date: Wed Nov 22 17:11:16 2017 -0800 Merge from preview commit 1786a18 Author: Sergey Shandar <[email protected]> Date: Wed Nov 22 17:05:55 2017 -0800 simplify visitors. commit 2b2ecd2 Author: Sergey Shandar <[email protected]> Date: Wed Nov 22 16:55:05 2017 -0800 GetResourceDependencies() commit 4147b64 Author: Sergey Shandar <[email protected]> Date: Wed Nov 22 16:04:48 2017 -0800 address comments. commit 186926e Author: Sergey Shandar <[email protected]> Date: Wed Nov 22 13:39:27 2017 -0800 Address comments. commit 013ac18 Author: Sergey Shandar <[email protected]> Date: Tue Nov 21 22:46:56 2017 -0800 minor commit 3de22b5 Author: Sergey Shandar <[email protected]> Date: Tue Nov 21 22:36:05 2017 -0800 rename commit a318191 Author: Sergey Shandar <[email protected]> Date: Tue Nov 21 22:01:48 2017 -0800 bug fix commit 2c8aeb9 Author: Sergey Shandar <[email protected]> Date: Tue Nov 21 18:30:59 2017 -0800 new commit 6f8b6b7 Author: Sergey Shandar <[email protected]> Date: Mon Nov 20 14:58:34 2017 -0800 No Create, for now. commit 88a5696 Author: Sergey Shandar <[email protected]> Date: Fri Nov 17 11:31:29 2017 -0800 new interfaces commit 803c3c0 Author: Sergey Shandar <[email protected]> Date: Fri Nov 17 11:17:19 2017 -0800 renaming. commit e03403e Author: Sergey Shandar <[email protected]> Date: Fri Nov 17 10:52:20 2017 -0800 A Target state is created from a Current state. commit db8bd30 Author: Sergey Shandar <[email protected]> Date: Thu Nov 16 18:27:43 2017 -0800 Ids instead of objects. commit 37909d0 Author: Sergey Shandar <[email protected]> Date: Thu Nov 16 16:55:40 2017 -0800 Operation as a separate parameter. commit 2f7d5e3 Author: Sergey Shandar <[email protected]> Date: Thu Nov 16 15:52:25 2017 -0800 default location commit 254f7c1 Author: Sergey Shandar <[email protected]> Date: Thu Nov 16 15:33:23 2017 -0800 set properties. commit 29598d0 Author: Sergey Shandar <[email protected]> Date: Thu Nov 16 11:10:32 2017 -0800 Signing. commit d3abe06 Author: Sergey Shandar <[email protected]> Date: Wed Nov 15 18:32:59 2017 -0800 Revert some changes. commit 933c21b Author: Sergey Shandar <[email protected]> Date: Wed Nov 15 18:29:43 2017 -0800 Revert some changes. commit 48057f2 Author: Sergey Shandar <[email protected]> Date: Wed Nov 15 18:23:50 2017 -0800 no comments. commit 4e58d81 Author: Sergey Shandar <[email protected]> Date: Wed Nov 15 18:22:58 2017 -0800 No experiments. commit aa62b08 Author: Sergey Shandar <[email protected]> Date: Wed Nov 15 18:20:44 2017 -0800 Packages. commit 80878ba Merge: 44fd921 9b78152 Author: Sergey Shandar <[email protected]> Date: Wed Nov 15 18:09:51 2017 -0800 Merge from preview commit 44fd921 Author: Sergey Shandar <[email protected]> Date: Wed Nov 15 17:57:36 2017 -0800 Client. commit cad25fb Author: Sergey Shandar <[email protected]> Date: Wed Nov 15 16:40:06 2017 -0800 Resource strategies. commit e37b2a4 Author: Sergey Shandar <[email protected]> Date: Wed Nov 15 15:12:14 2017 -0800 Policy => Strategy commit 29af582 Author: Sergey Shandar <[email protected]> Date: Wed Nov 15 14:18:17 2017 -0800 Microsoft.Azure.Commands.Common.Stratagies commit 61d92df Author: Sergey Shandar <[email protected]> Date: Tue Nov 14 17:20:03 2017 -0800 Yes, it works! commit 27525ee Author: Sergey Shandar <[email protected]> Date: Tue Nov 14 16:59:30 2017 -0800 it works! :-) commit 381a986 Author: Sergey Shandar <[email protected]> Date: Tue Nov 14 14:24:56 2017 -0800 Unit tests. commit ca51bc7 Author: Sergey Shandar <[email protected]> Date: Tue Nov 14 12:41:24 2017 -0800 AsyncOperation commit 95173ef Author: Sergey Shandar <[email protected]> Date: Tue Nov 14 11:32:29 2017 -0800 ResourceOperations commit 74ff467 Author: Sergey Shandar <[email protected]> Date: Mon Nov 13 18:44:22 2017 -0800 CreaOperation, StateLocation commit b18f0d1 Author: Sergey Shandar <[email protected]> Date: Mon Nov 13 13:33:33 2017 -0800 State commit 74ffdeb Author: Sergey Shandar <[email protected]> Date: Sun Nov 12 18:08:35 2017 -0800 a lot commit bd12545 Author: Sergey Shandar <[email protected]> Date: Fri Nov 10 11:52:13 2017 -0800 Classic policies. commit 34a94ee Author: Sergey Shandar <[email protected]> Date: Thu Nov 9 20:27:51 2017 -0800 State commit facb9c5 Author: Sergey Shandar <[email protected]> Date: Thu Nov 9 17:59:29 2017 -0800 StateMap commit 6b2b72f Author: Sergey Shandar <[email protected]> Date: Thu Nov 9 15:24:34 2017 -0800 policies commit a4aeca6 Author: Sergey Shandar <[email protected]> Date: Thu Nov 9 15:14:25 2017 -0800 ChildResourceConfig commit ccb9d0e Author: Sergey Shandar <[email protected]> Date: Thu Nov 9 13:58:34 2017 -0800 No Resource Group. commit 76129f3 Author: Sergey Shandar <[email protected]> Date: Thu Nov 9 13:37:46 2017 -0800 IState commit 5b03081 Author: Sergey Shandar <[email protected]> Date: Thu Nov 9 12:19:28 2017 -0800 Info => Func<string, Info> commit 8b2b24b Author: Sergey Shandar <[email protected]> Date: Thu Nov 9 12:01:30 2017 -0800 NetworkInterfacePolicy commit 157f96b Author: Sergey Shandar <[email protected]> Date: Thu Nov 9 11:57:13 2017 -0800 Separeted policies. commit 0b84a5e Author: Sergey Shandar <[email protected]> Date: Thu Nov 9 11:24:22 2017 -0800 CreateConfig for different resources commit 6d8b26f Author: Sergey Shandar <[email protected]> Date: Thu Nov 9 10:48:30 2017 -0800 IClient.GetClient() commit b643730 Author: Sergey Shandar <[email protected]> Date: Thu Nov 9 10:37:57 2017 -0800 IClient commit e582289 Author: Sergey Shandar <[email protected]> Date: Fri Nov 3 14:03:29 2017 -0700 policies commit 6784457 Author: Sergey Shandar <[email protected]> Date: Fri Nov 3 13:37:42 2017 -0700 Readme update. commit a26b706 Author: Sergey Shandar <[email protected]> Date: Fri Nov 3 10:29:42 2017 -0700 Creating. commit cc429b7 Author: Sergey Shandar <[email protected]> Date: Thu Nov 2 18:37:40 2017 -0700 No interfaces. commit ed16283 Author: Sergey Shandar <[email protected]> Date: Wed Nov 1 16:24:18 2017 -0700 rethink. commit 5d3af68 Author: Sergey Shandar <[email protected]> Date: Wed Nov 1 13:10:58 2017 -0700 Better names commit bbd6632 Author: Sergey Shandar <[email protected]> Date: Wed Nov 1 11:24:30 2017 -0700 Better way commit 7832679 Author: Sergey Shandar <[email protected]> Date: Tue Oct 31 14:50:47 2017 -0700 GetDependecyLocation commit bc0fb77 Author: Sergey Shandar <[email protected]> Date: Fri Oct 27 11:23:03 2017 -0700 IGetParameters, ICreateParameters commit 7abf7d4 Author: Sergey Shandar <[email protected]> Date: Thu Oct 26 16:30:42 2017 -0700 Context. commit b8c75f8 Author: Sergey Shandar <[email protected]> Date: Thu Oct 26 15:45:54 2017 -0700 GetOrNullAsync commit 3eaa6c0 Author: Sergey Shandar <[email protected]> Date: Thu Oct 26 14:47:15 2017 -0700 GetAsync commit 4a41002 Author: Sergey Shandar <[email protected]> Date: Thu Oct 26 13:49:07 2017 -0700 Broken but it's ok ;-) commit d6db1f6 Author: Sergey Shandar <[email protected]> Date: Thu Oct 26 13:17:25 2017 -0700 Parameters commit 849627e Author: Sergey Shandar <[email protected]> Date: Thu Oct 26 11:59:08 2017 -0700 New concept. commit c844f7b Author: Sergey Shandar <[email protected]> Date: Wed Oct 25 14:27:50 2017 -0700 Name :-( commit 9821d44 Author: Sergey Shandar <[email protected]> Date: Wed Oct 25 13:15:04 2017 -0700 No public access to Info. commit 6b5bd83 Author: Sergey Shandar <[email protected]> Date: Wed Oct 25 12:12:17 2017 -0700 Async. commit 7b16d39 Author: Sergey Shandar <[email protected]> Date: Wed Oct 25 10:55:52 2017 -0700 location as a parameter. commit 3881543 Author: Sergey Shandar <[email protected]> Date: Wed Oct 25 10:43:06 2017 -0700 Minor commit 43bd4c0 Author: Sergey Shandar <[email protected]> Date: Tue Oct 24 16:31:25 2017 -0700 GetDependencyLocation() commit 94b26c2 Author: Sergey Shandar <[email protected]> Date: Tue Oct 24 15:41:00 2017 -0700 Network and Compute, policies. commit 7b3275b Author: Sergey Shandar <[email protected]> Date: Tue Oct 24 10:53:40 2017 -0700 it looks like it's broken. commit 1a063df Author: Sergey Shandar <[email protected]> Date: Thu Oct 19 13:45:26 2017 -0700 One project (two frameworks), one test. commit 1b3d6e8 Author: Sergey Shandar <[email protected]> Date: Wed Oct 18 15:21:56 2017 -0700 Simplify. commit 8c1c25e Author: Sergey Shandar <[email protected]> Date: Wed Oct 18 14:40:08 2017 -0700 .Net 4.5.2 commit 26288fe Author: Sergey Shandar <[email protected]> Date: Wed Oct 18 10:58:56 2017 -0700 Enbedded client. commit e40028a Author: Sergey Shandar <[email protected]> Date: Tue Oct 17 18:43:45 2017 -0700 Embedded context/client. commit db9488e Author: Sergey Shandar <[email protected]> Date: Tue Oct 17 18:23:38 2017 -0700 No delete function commit fb1539a Author: Sergey Shandar <[email protected]> Date: Tue Oct 17 18:14:24 2017 -0700 VmObject. commit 5782a9b Author: Sergey Shandar <[email protected]> Date: Tue Oct 17 13:00:25 2017 -0700 NetworkInterface commit a522a35 Author: Sergey Shandar <[email protected]> Date: Mon Oct 16 14:31:18 2017 -0700 Subnet commit 83d0145 Author: Sergey Shandar <[email protected]> Date: Mon Oct 16 13:35:39 2017 -0700 NetworkSecurityGroup commit 2be7c9c Author: Sergey Shandar <[email protected]> Date: Sat Oct 14 00:59:05 2017 -0700 PublicIpAddressObject.DeleteAsync commit 3237c8e Author: Sergey Shandar <[email protected]> Date: Sat Oct 14 00:15:15 2017 -0700 PublicIpAddressObject commit ebfa508 Author: Sergey Shandar <[email protected]> Date: Fri Oct 13 22:30:17 2017 -0700 AzureObject, ResourceGroupObject, VirtualNetworkObject. commit cf6fd68 Author: Sergey Shandar <[email protected]> Date: Fri Oct 13 16:25:41 2017 -0700 First test commit 0a78c02 Author: Sergey Shandar <[email protected]> Date: Fri Oct 13 13:10:50 2017 -0700 Azure Experiments C# project. commit 4fa263c Author: Sergey Shandar <[email protected]> Date: Mon Oct 9 13:04:37 2017 -0700 [Experiment][Compute] Tab completion for New-AzVm (#4655) * some bug fixes * subnet bug fix * Output * FQDN * output * progress using Write-Host * progress * progress * version update * 1.0.21 * Progress. * 1.0.22 * 1.0.23 * ResourceGroup has to be a direct dependency * clean output * 1.0.26 * ports * messages * minor * 1.0.27 * First Pester Tests. * first validation * bug fix * 1.0.28 * minor * Disable Boot Diagnostics #4735 * -DisableBootDiagnostics * Set-AzureRmVMBootDiagnostics * 1.0.30 commit 91c7ac0 Merge: 5a74e7a 8748388 Author: Sergey Shandar <[email protected]> Date: Thu Sep 21 17:16:35 2017 -0700 Merge pull request #4640 from markcowl/coreydemo Code for demo commit 8748388 Author: markcowl <[email protected]> Date: Thu Sep 21 01:07:07 2017 -0700 Code for demo commit 5a74e7a Merge: 127395f f3103c8 Author: Mark Cowlishaw <[email protected]> Date: Wed Sep 20 23:53:22 2017 -0700 Merge pull request #4618 from sergey-shandar/sergey-compute-asjob [Compute Experiments] AsJob, context and other paraemters commit f3103c8 Author: Sergey Shandar <[email protected]> Date: Wed Sep 20 16:08:51 2017 -0700 idempotent creation of resources commit fa7f2f6 Author: Sergey Shandar <[email protected]> Date: Tue Sep 19 16:34:20 2017 -0700 remove export of "New-AzVmInternal commit 040ac7c Author: Sergey Shandar <[email protected]> Date: Tue Sep 19 16:31:19 2017 -0700 New help. commit b0958e9 Merge: a034a9b 127395f Author: Sergey Shandar <[email protected]> Date: Tue Sep 19 15:25:07 2017 -0700 Merge from experiments branch commit 127395f Merge: cb572aa d9527e5 Author: Mark Cowlishaw <[email protected]> Date: Tue Sep 19 15:21:34 2017 -0700 Merge pull request #4606 from markcowl/webandcompute Web and Compute experiments commit a034a9b Author: Sergey Shandar <[email protected]> Date: Tue Sep 19 15:20:22 2017 -0700 AsJob commit 35ba386 Author: Sergey Shandar <[email protected]> Date: Mon Sep 18 18:46:48 2017 -0700 as job commit c4d8261 Author: Sergey Shandar <[email protected]> Date: Mon Sep 18 17:30:48 2017 -0700 AsJob preparation commit d0ec671 Author: Sergey Shandar <[email protected]> Date: Mon Sep 18 16:29:19 2017 -0700 add rules. commit 14697b7 Author: Sergey Shandar <[email protected]> Date: Mon Sep 18 16:26:07 2017 -0700 install *.3.2 modules. commit c1b3421 Author: Sergey Shandar <[email protected]> Date: Mon Sep 18 15:55:37 2017 -0700 1.0.8 commit 5d6f336 Merge: 72f2658 cb572aa Author: Sergey Shandar <[email protected]> Date: Mon Sep 18 15:55:07 2017 -0700 Merge remote-tracking branch 'azure1/experiments' into sergey-compute-class commit 72f2658 Author: Sergey Shandar <[email protected]> Date: Mon Sep 18 15:40:02 2017 -0700 Additional parameters commit 339357d Merge: b6fbae3 646a658 Author: Sergey Shandar <[email protected]> Date: Mon Sep 18 09:49:26 2017 -0700 Merge branch 'sergey-compute' into sergey-compute-class commit d9527e5 Author: markcowl <[email protected]> Date: Fri Sep 15 19:01:45 2017 -0700 updating tests commit 6a2a9cc Author: markcowl <[email protected]> Date: Fri Sep 15 18:55:46 2017 -0700 Add simple validation test commit 26c1ffe Merge: 7fb9bc3 646a658 Author: markcowl <[email protected]> Date: Fri Sep 15 16:50:52 2017 -0700 Update compute definiton commit 646a658 Author: Sergey Shandar <[email protected]> Date: Fri Sep 15 16:46:29 2017 -0700 remove "Computer" suffix commit b6fbae3 Author: Sergey Shandar <[email protected]> Date: Fri Sep 15 16:44:56 2017 -0700 subnet (broken) commit 7fb9bc3 Author: markcowl <[email protected]> Date: Fri Sep 15 14:44:10 2017 -0700 Build updates for compute module commit e372a86 Author: markcowl <[email protected]> Date: Fri Sep 15 14:01:39 2017 -0700 Updating tools to not alter build for Experiments modules commit 66fde51 Author: markcowl <[email protected]> Date: Fri Sep 15 13:25:36 2017 -0700 Update module metadata commit 6553d22 Author: markcowl <[email protected]> Date: Fri Sep 15 13:22:01 2017 -0700 Adding compute module commit 55f1dd2 Merge: 54e74a6 96b9cbf Author: markcowl <[email protected]> Date: Fri Sep 15 12:44:02 2017 -0700 Merge branch 'sergey-compute' of github.com:sergey-shandar/azure-powershell into webapp commit 54e74a6 Author: markcowl <[email protected]> Date: Fri Sep 15 12:03:35 2017 -0700 Add help and ShouldProcess commit e1b3725 Author: markcowl <[email protected]> Date: Fri Sep 15 11:49:53 2017 -0700 Update help and add maml help for website cmdlets commit e2cfbc1 Author: markcowl <[email protected]> Date: Fri Sep 15 10:56:43 2017 -0700 Updates to websites git integration commit e9b86e8 Author: markcowl <[email protected]> Date: Fri Sep 15 09:44:32 2017 -0700 build fixes commit 3149c62 Author: markcowl <[email protected]> Date: Fri Sep 15 09:28:59 2017 -0700 Update tools and module definition for websites experiments commit b72cdd8 Author: markcowl <[email protected]> Date: Fri Sep 15 01:59:45 2017 -0700 allow dealy signing of experiments assembly commit ad01778 Author: markcowl <[email protected]> Date: Fri Sep 15 01:14:00 2017 -0700 Update build tools for package commit b568a60 Author: markcowl <[email protected]> Date: Fri Sep 15 00:49:15 2017 -0700 Update headers in help file commit a474e2b Author: markcowl <[email protected]> Date: Thu Sep 14 20:26:30 2017 -0700 Help fixes commit 51e3ad9 Author: markcowl <[email protected]> Date: Thu Sep 14 20:08:33 2017 -0700 Fix experiments project commit e3a5858 Author: markcowl <[email protected]> Date: Thu Sep 14 20:04:23 2017 -0700 Make HalpAnalyzer robust over empty dependent assemblies commit a68a635 Author: markcowl <[email protected]> Date: Thu Sep 14 19:37:52 2017 -0700 Updating help and removing 'justdoit cmdlet commit 96b9cbf Merge: 0058e16 01d6a92 Author: Sergey Shandar <[email protected]> Date: Thu Sep 14 19:00:06 2017 -0700 Merge pull request #5 from sergey-shandar/sergey-compute-class remove old Az.Compute.psm1 commit 01d6a92 Author: Sergey Shandar <[email protected]> Date: Thu Sep 14 18:58:49 2017 -0700 remove old Az.Compute.psm1 commit 0058e16 Merge: 199077b eac6277 Author: Sergey Shandar <[email protected]> Date: Thu Sep 14 18:57:13 2017 -0700 Merge pull request #4 from sergey-shandar/sergey-compute-class OutputType commit eac6277 Author: Sergey Shandar <[email protected]> Date: Thu Sep 14 18:55:14 2017 -0700 OutputType commit a8e95a3 Merge: 83e20a2 cb572aa Author: Mark Cowlishaw <[email protected]> Date: Thu Sep 14 18:40:23 2017 -0700 Merge branch 'preview' into preview commit 199077b Merge: 4575ee6 315747d Author: Sergey Shandar <[email protected]> Date: Thu Sep 14 18:17:14 2017 -0700 Merge pull request #3 from sergey-shandar/sergey-compute-class Sergey compute class commit 315747d Author: Sergey Shandar <[email protected]> Date: Thu Sep 14 18:15:52 2017 -0700 CreateParams type commit 390bc29 Author: Sergey Shandar <[email protected]> Date: Thu Sep 14 17:44:52 2017 -0700 1.0.6 commit 63bf4b0 Author: Sergey Shandar <[email protected]> Date: Thu Sep 14 17:24:40 2017 -0700 -Warning SilentlyContinue commit b8950d4 Author: Sergey Shandar <[email protected]> Date: Thu Sep 14 17:09:07 2017 -0700 -WhatIf test commit 5d2629f Author: Sergey Shandar <[email protected]> Date: Thu Sep 14 16:59:07 2017 -0700 ShouldProcess commit 24c2a66 Author: Sergey Shandar <[email protected]> Date: Thu Sep 14 15:59:02 2017 -0700 docs commit 4575ee6 Merge: d32bee0 e89a548 Author: Sergey Shandar <[email protected]> Date: Thu Sep 14 15:10:50 2017 -0700 Merge pull request #2 from sergey-shandar/sergey-compute-class Sergey compute class commit e89a548 Author: Sergey Shandar <[email protected]> Date: Thu Sep 14 15:08:30 2017 -0700 help commit 35915ea Author: Sergey Shandar <[email protected]> Date: Thu Sep 14 14:33:48 2017 -0700 Help template commit 82731a3 Author: Sergey Shandar <[email protected]> Date: Thu Sep 14 13:42:53 2017 -0700 minor changes commit d32bee0 Merge: a321a65 90ab0fa Author: Sergey Shandar <[email protected]> Date: Mon Sep 11 16:25:11 2017 -0700 Compute classess (Get/Create logic). commit 90ab0fa Author: Sergey Shandar <[email protected]> Date: Mon Sep 11 16:18:54 2017 -0700 minor commit 1ea0d9d Author: Sergey Shandar <[email protected]> Date: Mon Sep 11 16:12:49 2017 -0700 remove Set-ResourceGroup commit 3f78229 Author: Sergey Shandar <[email protected]> Date: Mon Sep 11 16:02:00 2017 -0700 VM creation using classes commit 144b3a6 Author: Sergey Shandar <[email protected]> Date: Mon Sep 11 15:21:35 2017 -0700 unused object commit 01cc466 Author: Sergey Shandar <[email protected]> Date: Mon Sep 11 15:12:48 2017 -0700 NetworkInterface class implementation commit a434c6e Author: Sergey Shandar <[email protected]> Date: Mon Sep 11 14:18:50 2017 -0700 publicipaddress and securitygroup commit 2384e26 Author: Sergey Shandar <[email protected]> Date: Fri Sep 8 18:28:01 2017 -0700 Virtual Network as an object. commit 255e154 Author: Sergey Shandar <[email protected]> Date: Fri Sep 8 18:00:00 2017 -0700 resource group name as a parameter commit 96972d2 Author: Sergey Shandar <[email protected]> Date: Fri Sep 8 16:02:14 2017 -0700 classes commit 6571649 Author: Sergey Shandar <[email protected]> Date: Thu Sep 7 14:13:46 2017 -0700 common commit a321a65 Author: Sergey Shandar <[email protected]> Date: Wed Sep 6 16:45:33 2017 -0700 Set-ResourceGroup commit 02692a7 Author: Sergey Shandar <[email protected]> Date: Wed Sep 6 11:48:53 2017 -0700 publishing. commit 1d9486d Author: Sergey Shandar <[email protected]> Date: Tue Sep 5 18:08:14 2017 -0700 Use specific version of modules commit 539bbe1 Author: Sergey Shandar <[email protected]> Date: Tue Sep 5 11:16:54 2017 -0700 parameter commit d63a3e9 Author: Sergey Shandar <[email protected]> Date: Sat Sep 2 17:40:56 2017 -0700 no password commit 4507204 Author: Sergey Shandar <[email protected]> Date: Sat Sep 2 09:36:21 2017 -0700 remove images.json commit 09a4dc2 Author: Sergey Shandar <[email protected]> Date: Sat Sep 2 01:30:00 2017 -0700 hardcoded images commit 9eb80c7 Author: Sergey Shandar <[email protected]> Date: Fri Sep 1 15:05:23 2017 -0700 BOM ? commit 040b552 Author: Sergey Shandar <[email protected]> Date: Fri Sep 1 11:51:09 2017 -0700 AzureRM.Compute.Experements commit 57f9e73 Merge: ee3ade0 7d70753 Author: Sergey Shandar <[email protected]> Date: Tue Aug 29 13:16:21 2017 -0700 Merge branch 'preview' into sergey-compute commit ee3ade0 Author: Aaron Roney <[email protected]> Date: Sun Aug 27 19:18:18 2017 -0700 Update Az.Compute.psm1 commit b859389 Author: Aaron Roney <[email protected]> Date: Sun Aug 27 19:05:42 2017 -0700 Move. commit 72b44be Author: Aaron Roney <[email protected]> Date: Sun Aug 27 18:43:14 2017 -0700 Create VM rough draft. commit 83e20a2 Author: NelsonDaniel <[email protected]> Date: Fri Aug 18 13:08:46 2017 -0700 Made some cosmetic changes. commit c461635 Author: NelsonDaniel <[email protected]> Date: Fri Aug 18 10:36:45 2017 -0700 Added output path for helpfiles inside websites experiments project. commit b3d0e7b Author: NelsonDaniel <[email protected]> Date: Fri Aug 18 10:04:49 2017 -0700 Fix to breaking change analyzer for experimental cmdlets. commit 514b3f7 Author: NelsonDaniel <[email protected]> Date: Fri Aug 18 09:34:32 2017 -0700 Fix to help analyzer for webapp experimental cmdlets. commit e76b093 Author: NelsonDaniel <[email protected]> Date: Fri Aug 18 09:27:14 2017 -0700 Fixed experimental cmdlet unit tests. commit 4af3d5c Author: NelsonDaniel <[email protected]> Date: Thu Aug 17 17:48:05 2017 -0700 Added experimental cmdlets for webapp creation scenarios for webapps. Revert "New-AzureVm SimpleParameterSet, Strategies" This reverts commit db1f851.

- AsJob fix - Output folder for Debug - No Azure SDK packages.

markcowl · 2017-12-06T18:47:40Z

src/ResourceManager/Compute/Commands.Compute/Models/PSVirtualMachine.cs

@@ -98,5 +98,7 @@ public string ResourceGroupName

        // Gets or sets the virtual machine zones.
        public IList<string> Zones { get; set; }
+
+        public string Fqdn { get; set; }


I tyhink this should be 'DomainName',

markcowl · 2017-12-06T18:49:34Z

on demand run here: https://azuresdkci.westus2.cloudapp.azure.com/job/powershell-demand/246/
signing run here: https://azuresdkci.westus2.cloudapp.azure.com/view/PowerShell/job/powershell-sign/34/

hovsepm · 2017-12-06T19:23:52Z

src/Common/Commands.Common/Extensions/CmdletExtensions.cs

+                    catch
+                    {
+
+                    }


would be good to at least put some info somewhere (in the debug stream?) that there were an exception.

See this PR #5086 @markcowl

This is bootstrapping code that cannot fail, so we should not use the PowerShell ICommandRuntime

hovsepm · 2017-12-06T19:27:52Z

src/ResourceManager/Common/Commands.Common.Strategies/IResourceStrategy.cs

@@ -0,0 +1,10 @@
+namespace Microsoft.Azure.Commands.Common.Strategies
+{


license header missing ;)

hovsepm · 2017-12-06T19:29:58Z

src/ResourceManager/Common/Commands.Common.Strategies/LocationExtensions.cs

+        {
+            public string Location { get; }
+
+            public bool IsCompulsory { get; }


IsCompulsory [](start = 24, length = 12)

does this mean IsMandatory? Maybe change the name to be consistent with parameterset attribute "Mandatory = true"

It has different meaning. It means the resource requires all dependent resources has to have the same location. I like IsIntrusive. @markcowl what do you think?

@hovsepm Ok. we don't have a better name for now. I commented this property. The property is internal so we will have a chance to change it if we have a better name.

hovsepm · 2017-12-06T19:35:30Z

src/ResourceManager/Common/Commands.Common.Strategies/ResourceStrategy.cs

+            where TClient : ServiceClient<TClient>
+            => Create(
+                type,
+                name => new[] { "providers" }.Concat(headers).Concat(new[] { name }),


headers [](start = 53, length = 7)

this should be changed to "providers". I did revert my changes due to conflicts :)

hovsepm · 2017-12-06T19:38:29Z

using Xunit;

license header.... yes yes... even in tests :)

Refers to: src/ResourceManager/Common/Commands.Common.Strategies.UnitTest/TimeSlotTest.cs:1 in bfd3311. [](commit_id = bfd3311, deletion_comment = False)

hovsepm · 2017-12-06T19:40:17Z

src/ResourceManager/Compute/AzureRM.Compute.Netcore.psd1

@@ -61,7 +61,8 @@ RequiredAssemblies = 'netcoreapp2.0\AutoMapper.dll',
    'netcoreapp2.0\Microsoft.Data.Edm.dll',
    'netcoreapp2.0\Microsoft.Data.OData.dll',
    'netcoreapp2.0\Microsoft.WindowsAzure.Storage.dll',
-    'netcoreapp2.0\System.Spatial.dll'
+    'netcoreapp2.0\System.Spatial.dll', 
+    '.\Microsoft.Azure.Commands.Common.Strategies.dll'


.\ [](start = 5, length = 2)

shouldn't this as well reference strategies.dll in the netcoreapp2.0 folder? btw there were some issues with .\ path on linux on one of the versions of .Net Core PS.

@hovsepm I think, you are right. @twitchax please, confirm.

markcowl

Also, you will want to pull in my fix.

markcowl · 2017-12-06T22:09:58Z

src/ResourceManager/Common/Commands.Common.Strategies.UnitTest/TimeSlotTest.cs

+    public class TimeSlotTest
+    {
+        [Fact]
+        public void AddTest()


This should be a check-in tess, we use traits to select tests used for check-in, see any of the test projects
[Trait(Category.AcceptanceType, Category.CheckIn)]

markcowl · 2017-12-06T23:44:22Z

on demand: https://azuresdkci.westus2.cloudapp.azure.com/view/PowerShell/job/powershell-demand/255/

New-AzureVm SimpleParameterSet, Strategies

db1f851

azuresdkci added the needs-review label Dec 6, 2017

azuresdkci assigned shahabhijeet Dec 6, 2017

sergey-shandar mentioned this pull request Dec 6, 2017

Strategies. #4999

Closed

13 tasks

sergey-shandar changed the title ~~New-AzureVm SimpleParameterSet, Strategies~~ New-AzureRmVm SimpleParameterSet, Strategies Dec 6, 2017

markcowl requested changes Dec 6, 2017

View reviewed changes

sergey-shandar added 4 commits December 5, 2017 20:33

Address comments:

3aa77c2

- AsJob fix - Output folder for Debug - No Azure SDK packages.

XUnit

a26d6f1

Explicit parameter names.

c6e89ca

markcowl assigned sergey-shandar and unassigned shahabhijeet Dec 6, 2017

markcowl requested changes Dec 6, 2017

View reviewed changes

sergey-shandar and others added 3 commits December 6, 2017 10:59

FQDN => FullyQualifiedDomainName

9abc791

Merge from release-5.1.0

bc322e7

Update AzureRM.Compute.Netcore.psd1

bfd3311

hovsepm reviewed Dec 6, 2017

View reviewed changes

Address comments.

3900208

markcowl requested changes Dec 6, 2017

View reviewed changes

sergey-shandar added 3 commits December 6, 2017 14:36

Merge remote-tracking branch 'refs/remotes/azure1/release-5.1.0'

d5b96aa

Test category.

12dd95d

Merge from 'release'

352a613

markcowl approved these changes Dec 6, 2017

View reviewed changes

markcowl added Waiting for On Demand and removed needs-review labels Dec 6, 2017

hovsepm approved these changes Dec 7, 2017

View reviewed changes

markcowl merged commit 552460e into Azure:release-5.1.0 Dec 7, 2017

		@@ -50,7 +50,7 @@ public SimpleAccessToken(IAzureAccount account, string tenantId, string tokenTyp
		}
		this.UserId = account.Id;

		@@ -190,4 +190,4 @@ private PSLoadBalancer CreateLoadBalancer()
		return getLoadBalancer;
		}

+                                  catch
+                                  {
+                                  }

		@@ -0,0 +1,10 @@
		namespace Microsoft.Azure.Commands.Common.Strategies
		{

New-AzureRmVm SimpleParameterSet, Strategies #5085

New-AzureRmVm SimpleParameterSet, Strategies #5085

Uh oh!

Conversation

sergey-shandar commented Dec 6, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

markcowl commented Dec 6, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hovsepm commented Dec 6, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

markcowl left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

markcowl commented Dec 6, 2017

sergey-shandar commented Dec 6, 2017 •

edited

Loading