Skip to content

Pull in the latest from preview into websites-preview #5412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 209 commits into from

Conversation

cormacpayne
Copy link
Member

@cormacpayne cormacpayne commented Feb 1, 2018

Description


This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.
  • The pull request does not introduce breaking changes (unless a major version change occurs in the assembly and module).

Testing Guidelines

  • Pull request includes test coverage for the included changes.
  • PowerShell scripts used in tests should do any necessary setup as part of the test or suite setup, and should not use hard-coded values for locations or existing resources.

Cmdlet Signature Guidelines

  • New cmdlets that make changes or have side effects should implement ShouldProcess and have SupportShouldProcess=true specified in the cmdlet attribute. You can find more information on ShouldProcess here.
  • Cmdlet specifies OutputType attribute if any output is produced - if the cmdlet produces no output, it should implement a PassThru parameter.

Cmdlet Parameter Guidelines

  • Parameter types should not expose types from the management library - complex parameter types should be defined in the module.
  • Complex parameter types are discouraged - a parameter type should be simple types as often as possible. If complex types are used, they should be shallow and easily creatable from a constructor or another cmdlet.
  • Cmdlet parameter sets should be mutually exclusive - each parameter set must have at least one mandatory parameter not in other parameter sets.

stevestein and others added 30 commits September 6, 2017 16:39
…nto use-connect-and-disconnect-verbs

# Conflicts:
#	src/ResourceManager/Profile/AzureRM.Profile.Netcore.psd1
#	src/ResourceManager/Profile/AzureRM.Profile.psd1
#	src/ResourceManager/Profile/ChangeLog.md
#	tools/AzureRM/AzureRM.psm1
#	tools/InstallationTests/NetcoreTests/NetcoreTests.ps1
#	tools/StaticAnalysis/Exceptions/BreakingChangeIssues.csv
…hell into use-connect-and-disconnect-verbs

# Conflicts:
#	src/ResourceManager/Profile/AzureRM.Profile.psd1
#	src/ResourceManager/Profile/ChangeLog.md
#	src/ResourceManager/Profile/Commands.Profile/StartupScripts/AzureRmProfileStartup.ps1
#	tools/StaticAnalysis/Exceptions/BreakingChangeIssues.csv
Pull in the latest changes from Azure/preview
Replaced two uses of AddAzureRMAccountCommand with ConnectAzureRmAccountCommand.
…esource

Improved NestedResource configuration
…nto release-5.1.0

# Conflicts:
#	src/ResourceManager/Compute/Commands.Compute/Strategies/Network/SubnetStrategy.cs
Ajit Maruti Navasare (MINDTREE LIMITED) and others added 12 commits January 30, 2018 15:51
Update of Set-AzureRmVMOsDisk to support managed OS disk swap
Update EventHub SDK version used in IotHub tests
EventHubs: updated online version links in markdown files
EventGrid: Updated to use the latest version of the .NET SDK
…nto websites-preview

# Conflicts:
#	src/ResourceManager/Websites/AzureRM.Websites.psd1
#	src/ResourceManager/Websites/Commands.Websites/Properties/AssemblyInfo.cs
#	src/ResourceManager/Websites/WebSites.sln
#	tools/StaticAnalysis/Exceptions/BreakingChangeIssues.csv
@cormacpayne
Copy link
Member Author

markcowl
markcowl previously approved these changes Feb 1, 2018
maddieclayton and others added 4 commits January 31, 2018 17:31
@cormacpayne
Copy link
Member Author

@azuresdkci test this please

@cormacpayne
Copy link
Member Author

Closing temporarily until websites-preview branch is fully updated with changes by @panchagnula

@cormacpayne cormacpayne deleted the websites-preview branch May 2, 2018 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.