[Storage] Fix MD5 not work on FIPS enabled machine issue

[blueww]

Description

Fix the issue #4807

The resolution:

• At the begin of the related cmdlets, try call the MD5 caculate function, if the MD5 function report FIPS exception, set DMlib to use native MD5; else still use the orignal MD5 algrithm.

With this change:

• we can get the issue resolved without adding new parameter, so script can be shared across machines without change
• PowerShell by default will still use the orignal MD5 algrithm, so aligned with .net SDK (the MD5 check cost will be very low)
• It don’t need big cmdlet framework change.

Checklist

• I have read the Submitting Changes section of CONTRIBUTING.md
• The title of the PR is clear and informative
• The appropriate change log has been updated
• The PR does not introduce breaking changes
• If applicable, the changes made in the PR have proper test coverage
• For public API changes to cmdlets:
  • the changes have gone through a cmdlet design review
  • the cmdlet markdown files were generated using the platyPS module

[praries880]

@blueww
Thanks for fixing the issue :)
The changes look good to me... but this is a scenario we would like to have tests for. Do kindly add tests for this.

[blueww]

@praries880

Currently, we don't have Unit test for E2E of Storage data plan cmdlets. But will cover it in another test framework.
As I know, @MiYanni might will add Unit test for it in the future.

So for this change, the test we can do is to check FIPSEnabled is disable on normal machine. But dur to the protect level, we can't access FIPSEnabled from test case. I can change FIPSEnabled to public to add a test. But it looks not proper to change an object from protected to public just for test.

So I think we can wait for @MiYanni to add the storage Unit test, then add test case for it.

[MiYanni]

@blueww I'm not involved in this situation/issue. What's going on?

[blueww]

@MiYanni
Don't worry. It's just I am asked to add Unit test for some Storage data plan cmdlets change. But we don't have E2E Storage Dataplan test in PowerShell Unit test now.
As I remember, Mark send you a mail to add Storage Data plan test based on a script before.
So this test should base on the test change that change.
I am not pushing you to add the test now. Just explain why we can't add test for this change now.

[cormacpayne]

Sign job: https://azuresdkci.westus2.cloudapp.azure.com/job/ps-sign/265/

[praries880]

@blueww Thanks for the explanation.
Since we cant create a test, would you mind testing the signed bits for your changes (found here https://azuresdkci.westus2.cloudapp.azure.com/job/ps-sign/265/artifact/src/Package/) and test the functionality on a machine where you can controll the FIPS setting?

[markcowl]

typo?

[blueww]

fixed, use fipsEnabled

[markcowl]

variable name should be fipsEnabled

[blueww]

fixed, use fipsEnabled

[markcowl]

vertical space

[markcowl]

public static bool FipsEnabled {get;} = IsFIPSEnabled();

internal static bool ISFIPSEnabled()
{
                try
                {
                    System.Security.Cryptography.MD5.Create();
                    return false;
                }
              catch (System.Reflection.TargetInvocationException)
                {
                    return true;
                }
}

[markcowl]

I think we can take advantage of the fact that the static initializer will run once to simploify the code - so we cans et the value and then use it later

[blueww]

Fixed as the code from you. Thanks!

[markcowl]

Is this the only cmdlet that would be impacted? Wouldn't every blob-related cmdlet need this setting?

[blueww]

Only upload blob/file cmdlets need use MD5 function to calculate blob/file Property "ContentMD5". Other cmdlets don't use this function. So only need change cmdlets Set-AzureStorageBlob(File)Content

[blueww]

@markcowl

I have fixed the comments from you, please help to check. Change log is also added.
The on-demand test can be found in: https://azuresdkci.westus2.cloudapp.azure.com/job/powershell-demand/650/

[markcowl]

on demand run here: https://azuresdkci.westus2.cloudapp.azure.com/view/PowerShell/job/powershell-demand/685/