Brooklyn Feature: Point To Site IPSec custom policy set on Gateway #5909

Nilambari · 2018-04-09T20:22:01Z

Description

Checklist

I have read the Submitting Changes section of CONTRIBUTING.md
The title of the PR is clear and informative
The appropriate change log has been updated
The PR does not introduce breaking changes
If applicable, the changes made in the PR have proper test coverage
For public API changes to cmdlets:
- the changes have gone through a cmdlet design review
- the cmdlet markdown files were generated using the platyPS module

…icy set on Gateway. and fix build merge errors.

…nto preview1

MiYanni · 2018-04-20T16:29:44Z

Cmdlet review here: https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/45

…nto preview1

cormacpayne · 2018-05-07T15:47:14Z

@Nilambari please take a look at the build failures in the markdown help files:

Target	Description
New-AzureRmVirtualNetworkGateway.md	Trailing yaml string found in description for parameter VpnClientIpsecPolicy. Please move the trailing yaml string to a line by itself.
Set-AzureRmVirtualNetworkGateway.md	Trailing yaml string found in description for parameter VpnClientIpsecPolicy. Please move the trailing yaml string to a line by itself.

cormacpayne · 2018-05-15T19:37:14Z

src/ResourceManager/Dns/Commands.Dns.Test/ScenarioTests/ZoneTests.cs

@@ -31,36 +31,31 @@ public void TestZoneCrud()
            DnsTestsBase.NewInstance.RunPowerShellTest("Test-ZoneCrud");
        }

-        [Fact]
-        [Trait(Category.AcceptanceType, Category.CheckIn)]
+        [Fact(Skip = "Test is failing, service team needs to re-record")]


@Nilambari why are these tests failing? @muwaqar would you mind working with Nilambari to enable these tests?

Enabled skipped tests back as tests are passing now.

cormacpayne · 2018-05-15T19:37:46Z

src/ResourceManager/Network/ChangeLog.md

@@ -34,6 +34,16 @@
 * Add support for DDoS protection plan resource
 * Introduced multiple breaking changes
    - Please refer to the migration guide for more information
+* Updated below commands for feature: Point to Site IPsec custom policy set/remove on Brooklyn Gateway.


@Nilambari please move the snippet you are adding to below the ## Current Release header

cormacpayne · 2018-05-15T19:42:05Z

...er/Network/Commands.Network/VirtualNetworkGateway/GetAzureVpnClientIpsecParametersCommand.cs

+        {
+            base.Execute();
+
+            if (ShouldProcess("AzureRmVpnClientIpsecParameter", VerbsCommon.Get))


@Nilambari please remove the call to ShouldProcess for this cmdlet

cormacpayne · 2018-05-15T19:48:59Z

.../Network/Commands.Network/VirtualNetworkGateway/NewAzureRmVpnClientIpsecParametersCommand.cs

+        {
+            base.Execute();
+
+            if (ShouldProcess(Properties.Resources.CreatingResourceMessage + Properties.Resources.VirtualNetworkGatewayVpnClientIpsecPolicy))


@Nilambari it doesn't appear that this cmdlet doesn't make any calls to the server, it's just creating an in-memory object. If that is the case, then you don't need ShouldProcess and you can remove SupportsShouldProcess from the cmdlet attribute

That's right. Done.

cormacpayne · 2018-05-15T19:50:29Z

.../Network/Commands.Network/VirtualNetworkGateway/NewAzureRmVpnClientIpsecParametersCommand.cs

+            MNM.IpsecEncryption.GCMAES128,
+            MNM.IpsecEncryption.AES256,
+            MNM.IpsecEncryption.AES128,
+            IgnoreCase = false)]


@Nilambari is there any reason we need to be case sensitive for all of these parameters using ValidateSet? I think we should make all ValidateSet attributes case insensitive, so removing the IgnoreCase = False line from each one will resolve this issue.

cormacpayne · 2018-05-15T20:01:52Z

src/ResourceManager/Network/Commands.Network/help/New-AzureRmVpnClientIpsecPolicy.md

+
+### Create new virtual network gateway with setting vpn custom ipsec policy:
+```
+PS C:\> New-AzureRmVirtualNetworkGateway -ResourceGroupName vnet-gateway -name myNGW -location $location -IpConfigurations $vnetIpConfig -GatewayType Vpn -VpnType RouteBased -GatewaySku VpnGw1 -VpnClientIpsecPolicy $vpnclientipsecpolicy


@Nilambari same comment about adding corresponding output

cormacpayne · 2018-05-15T20:02:13Z

src/ResourceManager/Network/Commands.Network/help/New-AzureRmVpnClientIpsecPolicy.md

+
+### Get virtual network gateway to see if vpn custom policy is set correctly:
+```
+$gateway = Get-AzureRmVirtualNetworkGateway -ResourceGroupName vnet-gateway -name myNGW


@Nilambari nit: please add the PS C:\> string before this command to be consistent with the line below it

cormacpayne · 2018-05-15T20:02:44Z

src/ResourceManager/Network/Commands.Network/help/Remove-AzureRmVpnClientIpsecParameter.md

+# Remove-AzureRmVpnClientIpsecParameter
+
+## SYNOPSIS
+{{Fill in the Synopsis}}


@Nilambari please fill in a synopsis

cormacpayne · 2018-05-15T20:02:58Z

src/ResourceManager/Network/Commands.Network/help/Remove-AzureRmVpnClientIpsecParameter.md

+
+### 1: Deletes the set vpn ipsec parameters set on the Virtual Network Gateway
+```
+Remove-AzureRmVpnClientIpsecParameter -VirtualNetworkGatewayName myGateway -ResourceGroupName myRG


@Nilambari same comment about adding the corresponding output

cormacpayne · 2018-05-15T20:04:02Z

src/ResourceManager/Network/Commands.Network/help/Set-AzureRmVpnClientIpsecParameter.md

+### Example 1 : Sets a custom vpn ipsec policy to existing virtual network gateway.
+```powershell
+PS C:\>$vpnclientipsecparams = New-AzureRmVpnClientIpsecParameter -IpsecEncryption AES256 -IpsecIntegrity SHA256 -SALifeTime 86473 -SADataSize 429498 -IkeEncryption AES256 -IkeIntegrity SHA384 -DhGroup DHGroup2 -PfsGroup PFS2
+PS C:\> $setvpnIpsecParams = Set-AzureRmVpnClientIpsecParameter -VirtualNetworkGatewayName "ContosoLocalGateway" -ResourceGroupName "ContosoResourceGroup" -VpnClientIPsecParameter $vpnclientipsecparams


@Nilambari same comment about adding corresponding output

Done. Added output details in comment.

Nilambari · 2018-05-15T21:28:47Z

@cormacpayne Incorporated requested review comments. Please take a look and help accept the PR. Thanks!

Nilambari · 2018-05-15T22:58:48Z

@cormacpayne I think build failed due to static analysis errors. It asks for adding ShouldProcess to commandlets:- New-AzureRmVpnClientIpsecPolicy & New-AzureRmVpnClientIpsecParameter which was removed as per latest code review comments. Can you Please advice what to do in this case in order for build to pass?

This reverts commit a4bace3.

Nilambari · 2018-05-17T00:14:32Z

@cormacpayne Build is passed, Can you help accept the PR? Thanks!

cormacpayne · 2018-05-17T01:26:50Z

On-demand: https://azuresdkci.westus2.cloudapp.azure.com/job/powershell-demand/847/

cormacpayne · 2018-05-17T18:16:06Z

On-demand: https://azuresdkci.westus2.cloudapp.azure.com/job/powershell-demand/852/

maddieclayton · 2018-05-21T14:50:48Z

on demand here: https://azuresdkci.westus2.cloudapp.azure.com/view/PowerShell/job/powershell-demand/861/

cormacpayne · 2018-05-22T20:21:43Z

On-demand: https://azuresdkci.westus2.cloudapp.azure.com/job/powershell-demand/868/

Nilambari · 2018-05-23T20:47:34Z

@cormacpayne Seems on demand job is successful, can you Please help merge this PR?

cormacpayne · 2018-05-23T22:24:42Z

src/ResourceManager/Network/ChangeLog.md

@@ -22,6 +22,16 @@

 ## Version 6.1.0
 * Bump up Network SDK version from 18.0.0-preview to 19.0.0-preview
+* Updated below commands for feature: Point to Site IPsec custom policy set/remove on Brooklyn Gateway.


@Nilambari we'll need to move the release notes you added to be under the Current Release header above, but we can do that in a separate PR

Nilambari added 2 commits April 9, 2018 12:00

#1443089: New Powershell commandlets for feature:P2S Ipsec custom pol…

83c4ac9

…icy set on Gateway. and fix build merge errors.

#1443089: Fix build merge errors

9e31a3f

azuresdkci added the needs-review label Apr 9, 2018

#1443089: Update change log

28d982e

maddieclayton added the Cmdlet Review Required ⚠️ label Apr 10, 2018

Nilambari added 2 commits April 11, 2018 11:46

#1443089: Fix build merge conflicts

3dc3dbf

Merge branch 'preview' of https://github.com/Azure/azure-powershell i…

bef682b

…nto preview1

markcowl assigned cormacpayne Apr 12, 2018

Merge branch 'preview' of https://github.com/Azure/azure-powershell i…

929bb90

…nto preview1

cormacpayne assigned Nilambari and unassigned cormacpayne Apr 17, 2018

cormacpayne removed the needs-review label Apr 17, 2018

Nilambari added 2 commits April 18, 2018 17:04

fix in AzureRM.Network.psd1

0fba59b

Merge branch 'preview' of https://github.com/Azure/azure-powershell i…

7a6117d

…nto preview1

MiYanni changed the title ~~Brooklyn Fetaure:- Point To Site IPSec custom policy set on Gateway.~~ Brooklyn Feature: Point To Site IPSec custom policy set on Gateway Apr 20, 2018

MiYanni added needs-revision and removed Cmdlet Review Required ⚠️ labels Apr 20, 2018

Nilambari added 5 commits April 20, 2018 16:03

Fix Build merge conflicts

0d6d129

Add/update help files for PS command lets

7167152

Incorporate code review comments

889886f

Merge branch 'preview' of https://github.com/Azure/azure-powershell i…

20de82c

…nto preview1

Record failing tests

2c9d4a7

markcowl added Post Build and removed Post Build labels Apr 25, 2018

markcowl assigned cormacpayne May 1, 2018

maddieclayton added the Merge Conflicts label May 2, 2018

#Fix merge conflicts

3350cef

cormacpayne removed their assignment May 7, 2018

cormacpayne suggested changes May 15, 2018

View reviewed changes

Nilambari added 2 commits May 15, 2018 13:21

Fix build merge conflicts

70e002a

Incorporate code review comments

fa4a058

Nilambari added 4 commits May 15, 2018 16:26

Fix build merge conflicts

5cf0e9a

Fix command output

a4bace3

Revert "Fix command output"

2ef49bc

This reverts commit a4bace3.

Suppress signature issues as they are approved by Powershell team

4014464

cormacpayne changed the base branch from preview to release-6.1.0 May 17, 2018 00:20

Fix build merge errors

a4d554a

Merge branch 'release-6.1.0' into preview1

7111857

Merge branch 'release-6.1.0' into preview1

c5e31e6

cormacpayne changed the base branch from release-6.1.0 to preview May 18, 2018 21:09

cormacpayne and others added 3 commits May 21, 2018 13:08

Merge branch 'preview' into preview1

80b9971

Fix merge conflicts

aa74ac5

Fix merge conflicts

0419b06

maddieclayton assigned cormacpayne and unassigned Nilambari May 22, 2018

maddieclayton added needs-review and removed needs-revision labels May 22, 2018

cormacpayne reviewed May 23, 2018

View reviewed changes

cormacpayne approved these changes May 23, 2018

View reviewed changes

cormacpayne merged commit ba6ba51 into Azure:preview May 23, 2018

Brooklyn Feature: Point To Site IPSec custom policy set on Gateway #5909

Brooklyn Feature: Point To Site IPSec custom policy set on Gateway #5909

Uh oh!

Conversation

Nilambari commented Apr 9, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Uh oh!

MiYanni commented Apr 20, 2018

Uh oh!

cormacpayne commented May 7, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Nilambari May 15, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Nilambari commented May 15, 2018

Uh oh!

Nilambari commented May 15, 2018

Uh oh!

Nilambari commented May 17, 2018

Uh oh!

cormacpayne commented May 17, 2018

Uh oh!

cormacpayne commented May 17, 2018

Uh oh!

maddieclayton commented May 21, 2018

Uh oh!

cormacpayne commented May 22, 2018

Uh oh!

Nilambari commented May 23, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Nilambari commented Apr 9, 2018 •

edited

Loading

Nilambari May 15, 2018 •

edited

Loading