Skip to content

Brooklyn Feature: Point To Site IPSec custom policy set on Gateway #5909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 36 commits into from
May 23, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
83c4ac9
#1443089: New Powershell commandlets for feature:P2S Ipsec custom pol…
Nilambari Apr 9, 2018
9e31a3f
#1443089: Fix build merge errors
Nilambari Apr 9, 2018
28d982e
#1443089: Update change log
Nilambari Apr 9, 2018
3dc3dbf
#1443089: Fix build merge conflicts
Nilambari Apr 11, 2018
bef682b
Merge branch 'preview' of https://github.com/Azure/azure-powershell i…
Nilambari Apr 12, 2018
929bb90
Merge branch 'preview' of https://github.com/Azure/azure-powershell i…
Nilambari Apr 16, 2018
0fba59b
fix in AzureRM.Network.psd1
Nilambari Apr 19, 2018
7a6117d
Merge branch 'preview' of https://github.com/Azure/azure-powershell i…
Nilambari Apr 19, 2018
0d6d129
Fix Build merge conflicts
Nilambari Apr 20, 2018
7167152
Add/update help files for PS command lets
Nilambari Apr 21, 2018
889886f
Incorporate code review comments
Nilambari Apr 21, 2018
20de82c
Merge branch 'preview' of https://github.com/Azure/azure-powershell i…
Nilambari Apr 24, 2018
2c9d4a7
Record failing tests
Nilambari Apr 24, 2018
3350cef
#Fix merge conflicts
Nilambari May 3, 2018
3ca204f
Merge branch 'preview' of https://github.com/Azure/azure-powershell i…
Nilambari May 7, 2018
b746a9d
Recorded and enabled skipped tests
Nilambari May 9, 2018
223fe0c
fix merge conflicts
Nilambari May 9, 2018
0373b7b
Record and enable skipped Brooklyn tests to have test coverage
Nilambari May 11, 2018
5a47a7f
Merge branch 'preview' of https://github.com/Azure/azure-powershell i…
Nilambari May 11, 2018
8d80c96
#Fix help file error
Nilambari May 11, 2018
be5d3c4
Merge branch 'preview' of https://github.com/Azure/azure-powershell i…
Nilambari May 11, 2018
3cf55cb
Fix static analysis errors
Nilambari May 13, 2018
ff19e60
Fix cred scan errors
Nilambari May 14, 2018
6b195db
Fix cred scan errors
Nilambari May 14, 2018
70e002a
Fix build merge conflicts
Nilambari May 15, 2018
fa4a058
Incorporate code review comments
Nilambari May 15, 2018
5cf0e9a
Fix build merge conflicts
Nilambari May 15, 2018
a4bace3
Fix command output
Nilambari May 16, 2018
2ef49bc
Revert "Fix command output"
Nilambari May 16, 2018
4014464
Suppress signature issues as they are approved by Powershell team
Nilambari May 16, 2018
a4d554a
Fix build merge errors
Nilambari May 17, 2018
7111857
Merge branch 'release-6.1.0' into preview1
cormacpayne May 17, 2018
c5e31e6
Merge branch 'release-6.1.0' into preview1
cormacpayne May 17, 2018
80b9971
Merge branch 'preview' into preview1
cormacpayne May 21, 2018
aa74ac5
Fix merge conflicts
Nilambari May 22, 2018
0419b06
Fix merge conflicts
Nilambari May 22, 2018
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -32,35 +32,30 @@ public void TestZoneCrud()
}

[Fact]
[Trait(Category.AcceptanceType, Category.CheckIn)]
public void TestPrivateZoneCrud()
{
DnsTestsBase.NewInstance.RunPowerShellTest("Test-PrivateZoneCrud");
}

[Fact]
[Trait(Category.AcceptanceType, Category.CheckIn)]
public void TestPrivateZoneCrudRegistrationVirtualNetwork()
{
DnsTestsBase.NewInstance.RunPowerShellTest("Test-PrivateZoneCrudRegistrationVnet");
}

[Fact]
[Trait(Category.AcceptanceType, Category.CheckIn)]
public void TestPrivateZoneCrudResolutionVirtualNetwork()
{
DnsTestsBase.NewInstance.RunPowerShellTest("Test-PrivateZoneCrudResolutionVnet");
}

[Fact]
[Trait(Category.AcceptanceType, Category.CheckIn)]
public void TestPrivateZoneCrudByVirtualNetworkIds()
{
DnsTestsBase.NewInstance.RunPowerShellTest("Test-PrivateZoneCrudByVirtualNetworkIds");
}

[Fact]
[Trait(Category.AcceptanceType, Category.CheckIn)]
public void TestPrivateZoneCrudByVirtualNetworkObjects()
{
DnsTestsBase.NewInstance.RunPowerShellTest("Test-PrivateZoneCrudByVirtualNetworkObjects");
Expand Down
5 changes: 5 additions & 0 deletions src/ResourceManager/Network/AzureRM.Network.Netcore.psd1
Original file line number Diff line number Diff line change
Expand Up @@ -241,6 +241,11 @@ CmdletsToExport = 'Add-AzureRmApplicationGatewayAuthenticationCertificate',
'Reset-AzureRmVirtualNetworkGateway',
'Set-AzureRmVirtualNetworkGatewayDefaultSite',
'Remove-AzureRmVirtualNetworkGatewayDefaultSite',
'New-AzureRmVpnClientIpsecPolicy',
'New-AzureRmVpnClientIpsecParameter',
'Set-AzureRmVpnClientIpsecParameter',
'Get-AzureRmVpnClientIpsecParameter'
'Remove-AzureRmVpnClientIpsecParameter',
'Remove-AzureRmLocalNetworkGateway',
'Get-AzureRmLocalNetworkGateway', 'New-AzureRmLocalNetworkGateway',
'Set-AzureRmLocalNetworkGateway',
Expand Down
5 changes: 5 additions & 0 deletions src/ResourceManager/Network/AzureRM.Network.psd1
Original file line number Diff line number Diff line change
Expand Up @@ -227,6 +227,11 @@ CmdletsToExport = 'Add-AzureRmApplicationGatewayAuthenticationCertificate',
'Add-AzureRmVpnClientRevokedCertificate',
'New-AzureRmVpnClientRootCertificate',
'New-AzureRmVpnClientRevokedCertificate',
'New-AzureRmVpnClientIpsecPolicy',
'New-AzureRmVpnClientIpsecParameter',
'Set-AzureRmVpnClientIpsecParameter',
'Get-AzureRmVpnClientIpsecParameter',
'Remove-AzureRmVpnClientIpsecParameter',
'Resize-AzureRmVirtualNetworkGateway',
'Remove-AzureRmVpnClientRevokedCertificate',
'Remove-AzureRmVpnClientRootCertificate',
Expand Down
10 changes: 10 additions & 0 deletions src/ResourceManager/Network/ChangeLog.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,16 @@

## Version 6.1.0
* Bump up Network SDK version from 18.0.0-preview to 19.0.0-preview
* Updated below commands for feature: Point to Site IPsec custom policy set/remove on Brooklyn Gateway.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Nilambari we'll need to move the release notes you added to be under the Current Release header above, but we can do that in a separate PR

- Updated New-AzureRmVirtualNetworkGateway: Added optional parameter -VpnClientIpsecPolicy [Pass the value from output of newly added command:- New-AzureRmVpnClientIpsecPolicy]
- Updated Set-AzureRmVirtualNetworkGateway: Added optional parameter -VpnClientIPsecParameter [Pass the value from output of newly added command:- New-AzureRmVpnClientIpsecPolicy]
* Added new commands for feature: Point to Site IPsec custom policy set/remove on Brooklyn Gateway.
- New-AzureRmVpnClientIpsecPolicy : Added for passing output from this command to existing commands: New-AzureRmVirtualNetworkGateway & Set-AzureRmVirtualNetworkGateway to set Vpn IPSec policy
- New-AzureRmVpnClientIpsecParameter
- Set-AzureRmVpnClientIpsecParameter
- Get-AzureRmVpnClientIpsecParameter
- Remove-AzureRmVpnClientIpsecParameter
* Added a warning note for existing command: Set-AzureRmVirtualNetworkGatewayVpnClientConfig to let users know of its plan of removal in next release.
* Added cmdlet to create protocol configuration
- New-AzureRmNetworkWatcherProtocolConfiguration
* Added cmdlet to add a new circuit connection to an existing express route circuit.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -558,6 +558,9 @@
<None Include="SessionRecords\Commands.Network.Test.ScenarioTests.VirtualNetworkGatewayConnectionTests\TestVirtualNetworkGatewayConnectionwithIpsecPoliciesCRUD.json">
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
</None>
<None Include="SessionRecords\Commands.Network.Test.ScenarioTests.VirtualNetworkGatewayTests\TestVirtualNetworkGatewayP2SAndSKU.json">
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
</None>
<None Include="SessionRecords\Commands.Network.Test.ScenarioTests.VirtualNetworkGatewayConnectionTests\TestVirtualNetworkGatewayVpnDeviceConfigurationScripts.json">
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
</None>
Expand Down Expand Up @@ -618,6 +621,9 @@
<None Include="SessionRecords\Commands.Network.Test.ScenarioTests.VirtualNetworkGatewayTests\VirtualNetworkGatewayRouteApiTest.json">
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
</None>
<None Include="SessionRecords\Commands.Network.Test.ScenarioTests.VirtualNetworkGatewayTests\VirtualNetworkGatewayVpnCustomIpsecPolicySetTest.json">
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
</None>
<None Include="SessionRecords\Commands.Network.Test.ScenarioTests.VirtualNetworkTests\TestResourceNavigationLinksOnSubnetCRUD.json">
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
</None>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,15 +26,15 @@ public VirtualNetworkGatewayConnectionTests(ITestOutputHelper output)
XunitTracingInterceptor.AddToContext(new XunitTracingInterceptor(output));
}

[Fact(Skip = "Rerecord tests")]
[Fact]
[Trait(Category.AcceptanceType, Category.CheckIn)]
[Trait(Category.Owner, Category.brooklynft)]
public void TestVirtualNetworkGatewayConnectionCRUD()
{
NetworkResourcesController.NewInstance.RunPsTest("Test-VirtualNetworkGatewayConnectionCRUD");
}

[Fact(Skip = "Rerecord tests")]
[Fact]
[Trait(Category.AcceptanceType, Category.CheckIn)]
[Trait(Category.Owner, Category.brooklynft)]
public void TestVirtualNetworkGatewayConnectionSharedKeyCRUD()
Expand All @@ -50,7 +50,7 @@ public void TestVirtualNetworkeExpressRouteGatewayConnectionCRUD()
NetworkResourcesController.NewInstance.RunPsTest("Test-VirtualNetworkeExpressRouteGatewayConnectionCRUD");
}

[Fact(Skip = "Rerecord tests")]
[Fact]
[Trait(Category.AcceptanceType, Category.CheckIn)]
[Trait(Category.Owner, Category.brooklynft)]
public void TestVirtualNetworkGatewayConnectionWithBgpCRUD()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ public VirtualNetworkGatewayTests(ITestOutputHelper output)
XunitTracingInterceptor.AddToContext(new XunitTracingInterceptor(output));
}

[Fact(Skip = "NRP code to be there to test this scenario, skipping it until NRP is ready")]
[Fact]
[Trait(Category.AcceptanceType, Category.CheckIn)]
[Trait(Category.Owner, Category.brooklynft)]
public void TestVirtualNetworkExpressRouteGatewayCRUD()
Expand All @@ -43,7 +43,7 @@ public void TestVirtualNetworkGatewayCRUD()
NetworkResourcesController.NewInstance.RunPsTest("Test-VirtualNetworkGatewayCRUD");
}

[Fact(Skip = "Need to record afterwards, failing due to product issue.")]
[Fact]
[Trait(Category.AcceptanceType, Category.CheckIn)]
[Trait(Category.Owner, Category.brooklynft)]
public void TestVirtualNetworkGatewayP2SAndSKU()
Expand All @@ -65,15 +65,14 @@ public void VirtualNetworkGatewayActiveActiveFeatureTest()
NetworkResourcesController.NewInstance.RunPsTest("Test-VirtualNetworkGatewayActiveActiveFeatureOperations");
}

[Fact(Skip = "Need service team to re-record test after changes to the ClientRuntime.")]
[Trait("Re-record", "ClientRuntime changes")]
[Fact]
[Trait(Category.Owner, Category.brooklynft)]
public void VirtualNetworkGatewayRouteApiTest()
{
NetworkResourcesController.NewInstance.RunPsTest("Test-VirtualNetworkGatewayBgpRouteApi");
}

[Fact(Skip ="Recorded with an older version of network, rerecord #4631")]
[Fact]
[Trait(Category.Owner, Category.brooklynft)]
public void TestVirtualNetworkGatewayP2SVpnProfile()
{
Expand All @@ -88,5 +87,12 @@ public void VirtualNetworkGatewayIkeV2Test()
{
NetworkResourcesController.NewInstance.RunPsTest("Test-VirtualNetworkGatewayIkeV2");
}

[Fact]
[Trait(Category.AcceptanceType, Category.CheckIn)]
public void VirtualNetworkGatewayVpnCustomIpsecPolicySetTest()
{
NetworkResourcesController.NewInstance.RunPsTest("Test-VirtualNetworkGatewayVpnCustomIpsecPolicySet");
}
}
}
Loading