Skip to content

Merge KeyVault_preview to preview #6027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 68 commits into from
Apr 24, 2018
Merged

Merge KeyVault_preview to preview #6027

merged 68 commits into from
Apr 24, 2018

Conversation

maddieclayton
Copy link
Contributor

Description

Checklist

Maddie Clayton and others added 30 commits March 15, 2018 16:00
Merge pull request #5749 from maddieclayton/KeyVault1
0ac6561 
Merge KeyVault changes into keyvault_preview
first commit
aa068ac
merge changes from non-breaking PR
2bbaa32
revert unnecessary changes
8c38b80
update piping scenarios and help
14ccb61
fix issue
ce55c73
@dragav
updating KeyVault PowerShell to latest API spec
20787f2
@dragav
DO NOT MERGE: pushing partial changes to KV PSh
0103d0f
@dragav
updating KeyVault PowerShell to latest API spec
c1eed14
@dragav
DO NOT MERGE: pushing partial changes to KV PSh
ae0f95d
add examples
0a448c5
update KeyUsage to enum
06eb72d
@jasonxdhu @dragav
Add KeyVault VNET PowerShell cmdlets to Azure PS
71fe957
@jasonxdhu @dragav
Fix VNET 'Update' command to override default ip-address or resource ids
c18626e
@dragav
integrating VNet into KeyVault PSh
3ac926e
@dragav
Merge branch 'kv-apr-18-preview' of https://github.com/dragav/azure-p…
31379b1 
…owershell into kv-apr-18-preview
issue 4393
9f6c119
Merge branch 'preview' of github.com:Azure/azure-powershell into KeyV…
3d0d5e6 
…ault2
Merge pull request #5802 from Azure/preview
3880069 
Merge preview into keyvault_preview
Merge branch 'keyvault_preview' into KeyVault2
37affef
Merge branch 'keyvault_preview' into kv-apr-18-preview
510e07a
add to breakingchanges.csv
ab27d7c
add aliases and update set-secret
68cc43e
update help files
8960fc4
update online version
7af25f6
address comments
b4dec5e
@dragav
relocating the CertificateTransparency flag to the issuer parameters
1fc293f
@dragav
addressing PR feedback
9c796f1
@dragav
Addressing PR feedback, take 2
e648248
@dragav
generating and updating help files
c2a1cbd
dragav and others added 15 commits April 16, 2018 11:33
@dragav
adding support for specifying key size at creation time
5463c45
@dragav
updating help file for Add-Key cmdlet
612d08e
Merge branch 'keyvault_preview' into kv-apr-18-bugfixes
9ec840e
@dragav
Fixing purging of managed storage accounts
c98279e
@dragav
fixing formatting of new parameter in the help file corresponding to …
3e7dc4c 
…Remove-StorageAccount
Merge pull request #5963 from dragav/kv-apr-18-bugfixes
c7557fd 
KeyVault: adding support for specifying key size on creation
fix format.ps1xml for KV (preview)
7a2e77f
Merge pull request #5995 from maddieclayton/kvbug1
2725496 
fix format.ps1xml for KV (preview)
@dragav
removing the explicit parameters of KeyVault-managed storage SAS defi…
0aee77c 
…nitions

updating help file, with end-to-end example
@dragav
adding known breaking changes to the exception list
c3f368a
Merge pull request #6006 from dragav/kv-apr-18-bugfixes
c219007 
Removing explicit parameters for creating KV-managed storage sas definitions
merge kv to preview
78a3ed2
updates
8a31784
update psd1
e5c37ca
fix
3c0bb29
@maddieclayton
Copy link
Contributor Author

on demand job here: https://azuresdkci.westus2.cloudapp.azure.com/view/PowerShell/job/powershell-demand/768/

schaabs
schaabs approved these changes Apr 24, 2018
View reviewed changes
Copy link

@schaabs schaabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. After this is merged into preview it will it get merged to master for the build release?

@maddieclayton
Copy link
Contributor Author

@schaabs Yes, it will first go to the release branch for //build, where it will be released with the rest of the modules, and then merged to master.

@RandalliLama
Copy link
Contributor

@maddieclayton If @schaabs is happy then I am happy.

@cormacpayne cormacpayne merged commit 888646d into Azure:preview Apr 24, 2018
@maddieclayton maddieclayton deleted the mergekv branch April 25, 2018 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cormacpayne cormacpayne cormacpayne approved these changes

@schaabs schaabs schaabs approved these changes

Assignees

@markcowl markcowl

@RandalliLama RandalliLama

@cormacpayne cormacpayne

@schaabs schaabs

@dragav dragav

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@maddieclayton @RandalliLama @cormacpayne @schaabs @markcowl @azuresdkci @dragav @jasonxdhu