Merge preview into network branch #6290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…icy set on Gateway. and fix build merge errors.
Moved the Websites dependency of LogicApp into commons
…nto dependency_logicapp
…nto dependency_logicapp
…nto dependency_logicapp
…nto dependency_logicapp
Websites: Websites.Strategies are replaced by Common.Strategies library.
Fix sign job failure with Commands.Common.Websites
…-location Remove spaces in location before comparision
Fix flaky long running operation test
Introduce Azure Maps cmdlets
Brooklyn Feature: Point To Site IPSec custom policy set on Gateway
Update azure-powershell-developer-guide.md
…colconfig Update test for test-ConnectivityTroubleshoot
Fix local build issues because of a netcore sln file introduced accidentally
* Fix for #535 Dependency fixes for ServiceFabric in this commit * Add signing stuff and netcode projects to fix netcore build. * Added exception for breaking changes * Update all the sln projects with the newest Keyvault common project * Took care of Cormac's comments * Fix bad merge * Fix breaking build as oer comments from Cormac * Fix file name * Fix sln files for new dependencies * Fix netcore csproj * Fic netcode proj for storage.management * Fix dependency paths and project names * Fix assembly name in assembluInfo * Fix KEyVault guid * Add csproj fils for the new common modules to profile * Fix names of csproj files * Netcore projects are case sensitive, and when i changed Keyvault to KeyVault, none of the folder names or file names reflected the change in git... git still sees them as Keyvault * Fix caseing in one more netcore project * Fix casing on the namespace... * Fix the folder name mixup. Step 1 of 2 * Fix the foldername mixup, Step 2 of 2 * Fix project references to point to the correct location * Fix namespace casing in test projet * Fix bad merge * Fix mad merge * Fix project dependencies * As poer feedback, add 2018_04_01 version for compute * Update sevice fabric dependency on the common compute code * Suppress warnings about passwords in generated code. * Credscan can not hanndle secrets in comments.. just removing the offending comments * Fix tests to be able to record them and other small changes * Fix bad merge * Remove UTF8 BOM encoding from file * Fix bad merge in profile psd1 file * Took care of Maddie's comment * iFix assembly name in profile csproj * Add common projects to the stack solution as well
cormacpayne
approved these changes
May 24, 2018
EvgenyAgafonchikov
pushed a commit
to EvgenyAgafonchikov/azure-powershell
that referenced
this pull request
May 28, 2018
* #1443089: New Powershell commandlets for feature:P2S Ipsec custom policy set on Gateway. and fix build merge errors. * #1443089: Update change log * fix in AzureRM.Network.psd1 * Fix for issue Azure#5365 Moved the Websites dependency of LogicApp into commons * Add websites dll to required assemblies part of Profile * Fic sln files to include the dependencies * Fic dependency paths and projects * Fix dll name * Add/update help files for PS command lets * Incorporate code review comments * Add csproj files for the new common module to Profile * Fix build * Fix dll name (WebSites -> Websites) in the pofile psd1 * Record failing tests * Enabled using network watcher by location * update OutputType in cmdlet * add New-AzureRMNetworkWatcherProtocolConfiguration * fix idictionary issue for header * record network watcher test * [Maps] Rename folders and files from LocationBasedServices * [Maps] Rename help file names * [Maps] Renaming variables, strings, descriptions, etc. * update help docs for New-AzureRmNetworkWatcherProtocolConfiguration * Add -ExtendedProperty parameter to New-AzureService and Set-AzureService cmdlets * Modify Commands.Sql.csproj and Commands.Sql.Test.csproj to use local update Management.Sql.dll binary for now * adding new parameters for create/update elastic pool and database cmdlets. update related db/elastic pool create/update tests * Fix issue in composing PUT request body for database and pool -- Sku object null scenario * Update elasticPool adaptor and communicator to using new sdk when trying to get databases inside a pool (Get-AzureRmSqlElasticPoolDatabase) * Update database replication related models and services to use new autorest sdk (instead of Legacy sdk) to do database copy/secondary, etc. Rerecord all replication related tests * address comments on database/elastic pool cmdlets-- null check, remove commentout codes, etc * address comments. Used -Edition -RequestedServiceObjectiveName for vcore database/pool. Only add new parameter -Vcore to specify vcore number. Modify the database replications, database restore related communicator to use new database webapi * used the published SDK 1.14.0-preview. Update LocationCapabilities model to use new API version (2017 version). Re-record LocationCapability tests * Update all db creation related cmdlets to support vcore database * Update db/elasticpool creation/update tests * Add functions to get skuname when given tier for database and pool, to avoid duplicate codes in cmdlets * use dictionary to mapping tier to skuname * re-record tests and update help file * Update restore cmdlet. Re-recording LTR restore test. Update changeLog. * address comments. and revert all changes related with 'replication links' * using published sdk 1.15.0-preview for the build issue. * Update cmds for creating/updating elasticpool. Use Patch way to do pool update inorder to support correct behaviors for updating pool * fix the yaml trailing issue in help files * Add the removed properties back in DatabaseModel and ElasticPoolModel to avoid breaking changes. And add Edition to BreakingChangeIssue exception * Update BreakingChangeIssues.csv * Address comments. Re-recording part of the failed tests in CI build * re-recording part of the failed tests in CI build. * add new tests records to output dic * link website for New-AzureRmNetworkWatcherProtocolConfiguration.md * re-record backup LTR v2 tests, AuditingClassicStorageTests, ThreatDetectionclassicStorageTests * re-record tests related with ClassicStorage * Fix test TestExportDatabase and re-record it. * fix issue with network watcher md files * Recorded and enabled skipped tests * Add StaticAnalysis checks for - No output type - Optional positional parameters - Parameter set names containing a space - Cmdlets with no default parameter set name and multiple sets * Update BreakingChangeIssues.csv * Record auditing & threat detection tests * Skip severel tests that can only run in live mode (talked with test owner). * Add tests for new static analysis checks * [Maps] Use Maps SDK over LocationBasedServices SDK * Update AzureRM.Network.psd1 * Update New-AzureRmNetworkWatcherProtocolConfiguration.md * make protocol required * Record and enable skipped Brooklyn tests to have test coverage * fix test * move from on demand to regular build * #Fix help file error * address comments. Remove Sku and PerDatabaseSettings from DatabaseModel and ElasticPoolModel.Modify the database and elastic pool response for powershell. * Fix static analysis errors * Update the elastic pool tests. fix bug. * Fix cred scan errors * Fix cred scan errors * Address comments. ReplicationLinkModel, DatabaseCopyModel, remove duplication null check and incorrect help message. * Add dependence in the ServiceManagement sln to fix the sign job * Update SignatureIssues.csv * Add default parameter set for two cmdlets. Update ChangeLog.md and remove unnecessary package files * small type fix * fix breaking change issue and signature issue * Small fix. Use SkuName in the pool model to keep alignment with other models. Rerecord related pool tests * Incorporate code review comments * Updating Networking tests with owner attributes * Fix command output * Revert "Fix command output" This reverts commit a4bace3. * Suppress signature issues as they are approved by Powershell team * Update ChangeLog.md * Update NewAzureNetworkWatcherProtocolConfiguration.cs * Fix to `New-AzureRmAks` help text. * Fix issue with Clear-AzureRmContext where old default context name was being used for empty context * Strategies library: Version 4, new WriteWarning method. * Websites.Strategies are replaced by Common.Strategies library. * Added comments with full team names * update cmdlets based on autorest .net client 2018-01-01 * Refactor InputObject variables and other review comments * get identity properties from InputObject and allow override by parameters * Skip failing Batch tests in on-demand build (see issue Azure#5006) * Update SignatureIssues.csv * Cleanup dependencies and assembly references * remove one more reference * Update modules for 6.1.0 release * Fix error in paths for Profile RequiredAssemblies * Fix for empty examples. * [Maps] Add legacy ResourceManager & update test recordings * [Maps] Add legacy ResourceManager & update test recordings * Add example to Stop-AzureRmResourceGroupDeployment.md * [Maps] Resolving merge revision requests * [Maps] Resolving merge revision requests (2) * Remove spaces in location before comparision * Update Stack.sln * [Maps] Add PassThru to Remove method, resolve build failure * Update azure-powershell-developer-guide.md * [Maps] Update help files to reflect -PassThru param addition * [Maps] Fix trailing yaml string for PassThru * address comments * Fix local build issues because of a netcore sln file introduced accidentally * Update azure-powershell-developer-guide.md * Update test for test-ConnectivityTroubleshoot * Dependency fix : ServiceFabric (Azure#5971) * Fix for Azure#535 Dependency fixes for ServiceFabric in this commit * Add signing stuff and netcode projects to fix netcore build. * Added exception for breaking changes * Update all the sln projects with the newest Keyvault common project * Took care of Cormac's comments * Fix bad merge * Fix breaking build as oer comments from Cormac * Fix file name * Fix sln files for new dependencies * Fix netcore csproj * Fic netcode proj for storage.management * Fix dependency paths and project names * Fix assembly name in assembluInfo * Fix KEyVault guid * Add csproj fils for the new common modules to profile * Fix names of csproj files * Netcore projects are case sensitive, and when i changed Keyvault to KeyVault, none of the folder names or file names reflected the change in git... git still sees them as Keyvault * Fix caseing in one more netcore project * Fix casing on the namespace... * Fix the folder name mixup. Step 1 of 2 * Fix the foldername mixup, Step 2 of 2 * Fix project references to point to the correct location * Fix namespace casing in test projet * Fix bad merge * Fix mad merge * Fix project dependencies * As poer feedback, add 2018_04_01 version for compute * Update sevice fabric dependency on the common compute code * Suppress warnings about passwords in generated code. * Credscan can not hanndle secrets in comments.. just removing the offending comments * Fix tests to be able to record them and other small changes * Fix bad merge * Remove UTF8 BOM encoding from file * Fix bad merge in profile psd1 file * Took care of Maddie's comment * iFix assembly name in profile csproj * Add common projects to the stack solution as well
EvgenyAgafonchikov
pushed a commit
to EvgenyAgafonchikov/azure-powershell
that referenced
this pull request
May 30, 2018
* #1443089: New Powershell commandlets for feature:P2S Ipsec custom policy set on Gateway. and fix build merge errors. * #1443089: Update change log * fix in AzureRM.Network.psd1 * Fix for issue Azure#5365 Moved the Websites dependency of LogicApp into commons * Add websites dll to required assemblies part of Profile * Fic sln files to include the dependencies * Fic dependency paths and projects * Fix dll name * Add/update help files for PS command lets * Incorporate code review comments * Add csproj files for the new common module to Profile * Fix build * Fix dll name (WebSites -> Websites) in the pofile psd1 * Record failing tests * Enabled using network watcher by location * update OutputType in cmdlet * add New-AzureRMNetworkWatcherProtocolConfiguration * fix idictionary issue for header * record network watcher test * [Maps] Rename folders and files from LocationBasedServices * [Maps] Rename help file names * [Maps] Renaming variables, strings, descriptions, etc. * update help docs for New-AzureRmNetworkWatcherProtocolConfiguration * Add -ExtendedProperty parameter to New-AzureService and Set-AzureService cmdlets * Modify Commands.Sql.csproj and Commands.Sql.Test.csproj to use local update Management.Sql.dll binary for now * adding new parameters for create/update elastic pool and database cmdlets. update related db/elastic pool create/update tests * Fix issue in composing PUT request body for database and pool -- Sku object null scenario * Update elasticPool adaptor and communicator to using new sdk when trying to get databases inside a pool (Get-AzureRmSqlElasticPoolDatabase) * Update database replication related models and services to use new autorest sdk (instead of Legacy sdk) to do database copy/secondary, etc. Rerecord all replication related tests * address comments on database/elastic pool cmdlets-- null check, remove commentout codes, etc * address comments. Used -Edition -RequestedServiceObjectiveName for vcore database/pool. Only add new parameter -Vcore to specify vcore number. Modify the database replications, database restore related communicator to use new database webapi * used the published SDK 1.14.0-preview. Update LocationCapabilities model to use new API version (2017 version). Re-record LocationCapability tests * Update all db creation related cmdlets to support vcore database * Update db/elasticpool creation/update tests * Add functions to get skuname when given tier for database and pool, to avoid duplicate codes in cmdlets * use dictionary to mapping tier to skuname * re-record tests and update help file * Update restore cmdlet. Re-recording LTR restore test. Update changeLog. * address comments. and revert all changes related with 'replication links' * using published sdk 1.15.0-preview for the build issue. * Update cmds for creating/updating elasticpool. Use Patch way to do pool update inorder to support correct behaviors for updating pool * fix the yaml trailing issue in help files * Add the removed properties back in DatabaseModel and ElasticPoolModel to avoid breaking changes. And add Edition to BreakingChangeIssue exception * Update BreakingChangeIssues.csv * Address comments. Re-recording part of the failed tests in CI build * re-recording part of the failed tests in CI build. * add new tests records to output dic * link website for New-AzureRmNetworkWatcherProtocolConfiguration.md * re-record backup LTR v2 tests, AuditingClassicStorageTests, ThreatDetectionclassicStorageTests * re-record tests related with ClassicStorage * Fix test TestExportDatabase and re-record it. * fix issue with network watcher md files * Recorded and enabled skipped tests * Add StaticAnalysis checks for - No output type - Optional positional parameters - Parameter set names containing a space - Cmdlets with no default parameter set name and multiple sets * Update BreakingChangeIssues.csv * Record auditing & threat detection tests * Skip severel tests that can only run in live mode (talked with test owner). * Add tests for new static analysis checks * [Maps] Use Maps SDK over LocationBasedServices SDK * Update AzureRM.Network.psd1 * Update New-AzureRmNetworkWatcherProtocolConfiguration.md * make protocol required * Record and enable skipped Brooklyn tests to have test coverage * fix test * move from on demand to regular build * #Fix help file error * address comments. Remove Sku and PerDatabaseSettings from DatabaseModel and ElasticPoolModel.Modify the database and elastic pool response for powershell. * Fix static analysis errors * Update the elastic pool tests. fix bug. * Fix cred scan errors * Fix cred scan errors * Address comments. ReplicationLinkModel, DatabaseCopyModel, remove duplication null check and incorrect help message. * Add dependence in the ServiceManagement sln to fix the sign job * Update SignatureIssues.csv * Add default parameter set for two cmdlets. Update ChangeLog.md and remove unnecessary package files * small type fix * fix breaking change issue and signature issue * Small fix. Use SkuName in the pool model to keep alignment with other models. Rerecord related pool tests * Incorporate code review comments * Updating Networking tests with owner attributes * Fix command output * Revert "Fix command output" This reverts commit a4bace3. * Suppress signature issues as they are approved by Powershell team * Update ChangeLog.md * Update NewAzureNetworkWatcherProtocolConfiguration.cs * Fix to `New-AzureRmAks` help text. * Fix issue with Clear-AzureRmContext where old default context name was being used for empty context * Strategies library: Version 4, new WriteWarning method. * Websites.Strategies are replaced by Common.Strategies library. * Added comments with full team names * update cmdlets based on autorest .net client 2018-01-01 * Refactor InputObject variables and other review comments * get identity properties from InputObject and allow override by parameters * Skip failing Batch tests in on-demand build (see issue Azure#5006) * Update SignatureIssues.csv * Cleanup dependencies and assembly references * remove one more reference * Update modules for 6.1.0 release * Fix error in paths for Profile RequiredAssemblies * Fix for empty examples. * [Maps] Add legacy ResourceManager & update test recordings * [Maps] Add legacy ResourceManager & update test recordings * Add example to Stop-AzureRmResourceGroupDeployment.md * [Maps] Resolving merge revision requests * [Maps] Resolving merge revision requests (2) * Remove spaces in location before comparision * Update Stack.sln * [Maps] Add PassThru to Remove method, resolve build failure * Update azure-powershell-developer-guide.md * [Maps] Update help files to reflect -PassThru param addition * [Maps] Fix trailing yaml string for PassThru * address comments * Fix local build issues because of a netcore sln file introduced accidentally * Update azure-powershell-developer-guide.md * Update test for test-ConnectivityTroubleshoot * Dependency fix : ServiceFabric (Azure#5971) * Fix for Azure#535 Dependency fixes for ServiceFabric in this commit * Add signing stuff and netcode projects to fix netcore build. * Added exception for breaking changes * Update all the sln projects with the newest Keyvault common project * Took care of Cormac's comments * Fix bad merge * Fix breaking build as oer comments from Cormac * Fix file name * Fix sln files for new dependencies * Fix netcore csproj * Fic netcode proj for storage.management * Fix dependency paths and project names * Fix assembly name in assembluInfo * Fix KEyVault guid * Add csproj fils for the new common modules to profile * Fix names of csproj files * Netcore projects are case sensitive, and when i changed Keyvault to KeyVault, none of the folder names or file names reflected the change in git... git still sees them as Keyvault * Fix caseing in one more netcore project * Fix casing on the namespace... * Fix the folder name mixup. Step 1 of 2 * Fix the foldername mixup, Step 2 of 2 * Fix project references to point to the correct location * Fix namespace casing in test projet * Fix bad merge * Fix mad merge * Fix project dependencies * As poer feedback, add 2018_04_01 version for compute * Update sevice fabric dependency on the common compute code * Suppress warnings about passwords in generated code. * Credscan can not hanndle secrets in comments.. just removing the offending comments * Fix tests to be able to record them and other small changes * Fix bad merge * Remove UTF8 BOM encoding from file * Fix bad merge in profile psd1 file * Took care of Maddie's comment * iFix assembly name in profile csproj * Add common projects to the stack solution as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
CONTRIBUTING.mdplatyPSmodule