AzureRm.Storage module consuming api-version 2016-01-01 and common runtime #7041

bganapa · 2018-08-24T21:54:52Z

Description

AzureRM.Storage module version update to 2016-01-01
Copying Storage SDK version 5.0.0-preview
Corresponding cmdlet changes, redoing IStorageContext move and Common runtime move, Redoing HashTable[] to HashTable
references to 8.6.0 WindowsAzure.Storage.dll and dependent dlls update
Recorded test changes

Checklist

I have read the Submitting Changes section of CONTRIBUTING.md
The title of the PR is clear and informative
The appropriate change log has been updated
The PR does not introduce breaking changes
If applicable, the changes made in the PR have proper test coverage
For public API changes to cmdlets:
- the changes have gone through a cmdlet design review
- the cmdlet markdown files were generated using the platyPS module

src/StackAdmin/Storage.Management/AzureRM.Storage.psd1

bganapa · 2018-08-24T22:08:25Z

...StackAdmin/Storage.Management/Commands.Management.Storage/Commands.Management.Storage.csproj

+    </None>
+  </ItemGroup>
+  <ItemGroup>
+    <!--    <ProjectReference Include="..\..\..\Common\Commands.Common.Authentication.Abstractions\Commands.Common.Authentication.Abstractions.csproj">


Remove commented project references

src/StackAdmin/Storage.Management/AzureRM.Storage.psd1

deathly809 · 2018-08-24T23:05:33Z

.../Storage.Management/Commands.Management.Storage.Test/Commands.Management.Storage.Test.csproj

@@ -40,10 +40,26 @@
    <Compile Include="TestController.cs" />
  </ItemGroup>
  <ItemGroup>
+    <!--    <ProjectReference Include="..\..\..\Common\Commands.Common.Authentication.Abstractions\Commands.Common.Authentication.Abstractions.csproj">


Remove commented out code please.

deathly809 · 2018-08-24T23:07:41Z

...StackAdmin/Storage.Management/Commands.Management.Storage/Commands.Management.Storage.csproj

+      <HintPath>..\..\..\..\packages\Microsoft.Azure.KeyVault.Core.1.0.0\lib\net40\Microsoft.Azure.KeyVault.Core.dll</HintPath>
+      <Private>True</Private>
+    </Reference>
+    <!--    <Reference Include="Microsoft.Azure.Management.Storage, Version=6.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">


You could shorten this if you wanted the reference version.

...StackAdmin/Storage.Management/Commands.Management.Storage/Commands.Management.Storage.csproj

bganapa · 2018-08-27T18:19:08Z

@maddieclayton the PR is failing due to this test In Profile. I have already retried..

System.ArgumentException : An item with the same key has already been added.
at System.ThrowHelper.ThrowArgumentException(ExceptionResource resource)
at System.Collections.Generic.Dictionary`2.Insert(TKey key, TValue value, Boolean add)
at Microsoft.Azure.Commands.Profile.Test.TelemetryTests.DataCollectionHandlesSerializationErrors() in c:\workspace\powershell\src\ResourceManager\Profile\Commands.Profile.Test\TelemetryTests.cs:line

bganapa · 2018-08-27T18:19:54Z

Here is the build.. https://azuresdkci.westus2.cloudapp.azure.com/job/powershell/6915/. I am retrying again

MiYanni · 2018-08-27T18:31:45Z

@bganapa We skipped DataCollectionHandlesSerializationErrors in the latest from the preview branch. Pull in to get that update.

deathly809 · 2018-08-31T21:12:41Z

@maddieclayton / @MiYanni I am very confused on how the tests are passing as we don't have the required Azure.Storage module for AzureRM.Storage in the repo anywhere. I don't see any output about the tests actually running.

src/StackAdmin/Storage/Commands.Management.Storage/Commands.Management.Storage.csproj

markcowl

Also, why remove all the help files?

markcowl · 2018-08-31T21:32:31Z

src/StackAdmin/Storage.Management/Commands.Management.Storage.Test/packages.config

@@ -14,7 +14,7 @@
  <package id="Microsoft.Bcl.Build" version="1.0.14" targetFramework="net45" />
  <package id="Microsoft.IdentityModel.Clients.ActiveDirectory" version="2.28.3" targetFramework="net45" />
  <package id="Microsoft.Net.Http" version="2.2.28" targetFramework="net45" />
-  <package id="Microsoft.Rest.ClientRuntime" version="2.3.12" targetFramework="net452" />
+  <package id="Microsoft.Rest.ClientRuntime" version="2.3.11" targetFramework="net452" />


This should not be downgraded

src/StackAdmin/Storage.Management/Commands.Management.Storage/AzureRM.Storage.psd1

...StackAdmin/Storage.Management/Commands.Management.Storage/Commands.Management.Storage.csproj

markcowl · 2018-08-31T21:36:59Z

...gement/Commands.Management.Storage/Microsoft.Azure.Commands.Management.Storage.dll-Help.psd1

@@ -0,0 +1,111 @@
+#


You don't need this

bganapa · 2018-09-05T02:38:33Z

@maddieclayton addressed the review comments. Thanks for the review

maddieclayton · 2018-09-05T03:57:58Z

@bganapa Made two small changes but everything else looks good. Please get @deathly809 to approve and we will merge tomorrow morning.

sign job is passing here: https://azuresdkci.westus2.cloudapp.azure.com/view/PowerShell/job/ps-sign/1156/

bganapa · 2018-09-05T05:07:37Z

@deathly809 , @knithinc to approve this PR

deathly809 · 2018-09-05T17:38:26Z

@maddieclayton I approved, but the build is failing trying to fetch from github. Bala is going to retry,

maddieclayton · 2018-09-05T17:41:41Z

@deathly809 The build was previously failing to I pushed out a fix - we should see in about an hour if it fixed the build.

…ntime

bganapa · 2018-09-05T18:04:59Z

@maddieclayton rebased to resolve conflicts in stack.sln

Addressed.

bganapa requested review from markcowl, maddieclayton, MiYanni and deathly809 August 24, 2018 21:54

bganapa mentioned this pull request Aug 24, 2018

AzureRm.Storage module consuming api-version 2016-01-01 and common runtime #6864

Closed

8 tasks

azuresdkci1x added the needs-review label Aug 24, 2018

bganapa commented Aug 24, 2018

View reviewed changes

src/StackAdmin/Storage.Management/AzureRM.Storage.psd1 Outdated Show resolved Hide resolved

bganapa commented Aug 24, 2018

View reviewed changes

src/StackAdmin/Storage.Management/AzureRM.Storage.psd1 Outdated Show resolved Hide resolved

bganapa commented Aug 24, 2018

View reviewed changes

deathly809 reviewed Aug 24, 2018

View reviewed changes

src/StackAdmin/Storage.Management/AzureRM.Storage.psd1 Outdated Show resolved Hide resolved

deathly809 reviewed Aug 24, 2018

View reviewed changes

...StackAdmin/Storage.Management/Commands.Management.Storage/Commands.Management.Storage.csproj Show resolved Hide resolved

maddieclayton added needs-revision and removed needs-review labels Aug 27, 2018

maddieclayton assigned bganapa Aug 27, 2018

bganapa force-pushed the storage-2018 branch from f2a8d2c to 033d3ff Compare August 27, 2018 23:07

maddieclayton added the Azure Stack label Aug 29, 2018

bganapa assigned markcowl and unassigned bganapa Aug 31, 2018

bganapa added needs-review and removed needs-revision labels Aug 31, 2018

bganapa assigned maddieclayton Aug 31, 2018

deathly809 reviewed Aug 31, 2018

View reviewed changes

src/StackAdmin/Storage/Commands.Management.Storage/Commands.Management.Storage.csproj Outdated Show resolved Hide resolved

markcowl previously requested changes Aug 31, 2018

View reviewed changes

markcowl removed the needs-review label Aug 31, 2018

bganapa force-pushed the storage-2018 branch from 39d82d6 to b288c9a Compare September 5, 2018 02:37

bganapa added needs-review and removed needs-revision labels Sep 5, 2018

bganapa assigned maddieclayton and unassigned markcowl, maddieclayton and bganapa Sep 5, 2018

maddieclayton assigned deathly809 Sep 5, 2018

deathly809 previously approved these changes Sep 5, 2018

View reviewed changes

maddieclayton dismissed deathly809’s stale review via 8d1e37d September 5, 2018 17:33

bganapa and others added 10 commits September 5, 2018 10:49

AzureRm.Storage module consuming api-version 2016-01-01 and common ru…

1bcf725

…ntime

Addressing review comments

a50d718

Addressing review comments, Updating help files

1241a6f

Removing help.psd1 and entries in packages.config

2f65ce9

adding stack specific Microsoft.Azure.Management.Storage.dll for siging

6577cfe

removing commands.management.storage from the wrong location

1736bac

rebasing and addressing review comments

fcd0a4a

Update StorageSDK.csproj

c198c9d

Update AssemblyInfo.cs

1ffb74d

Fixing conflicts in stack.sln

adba9c6

bganapa force-pushed the storage-2018 branch from 8d1e37d to adba9c6 Compare September 5, 2018 18:04

maddieclayton approved these changes Sep 5, 2018

View reviewed changes

maddieclayton merged commit a8d21ee into Azure:preview Sep 5, 2018

AzureRm.Storage module consuming api-version 2016-01-01 and common runtime #7041

AzureRm.Storage module consuming api-version 2016-01-01 and common runtime #7041

Uh oh!

Conversation

bganapa commented Aug 24, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bganapa commented Aug 27, 2018

Uh oh!

bganapa commented Aug 27, 2018

Uh oh!

MiYanni commented Aug 27, 2018

Uh oh!

deathly809 commented Aug 31, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

markcowl left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bganapa commented Sep 5, 2018

Uh oh!

maddieclayton commented Sep 5, 2018

Uh oh!

bganapa commented Sep 5, 2018

Uh oh!

deathly809 commented Sep 5, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

maddieclayton commented Sep 5, 2018

Uh oh!

bganapa commented Sep 5, 2018

Uh oh!

Uh oh!

bganapa commented Aug 24, 2018 •

edited

Loading

deathly809 commented Aug 31, 2018 •

edited

Loading

deathly809 commented Sep 5, 2018 •

edited

Loading