AzureRm.Storage module consuming api-version 2016-01-01 and common runtime #6864
Conversation
| </Reference> | ||
| <Reference Include="Microsoft.Rest.ClientRuntime.Azure, Version=3.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL"> | ||
| <HintPath>..\..\..\..\packages\Microsoft.Rest.ClientRuntime.Azure.3.3.13\lib\net452\Microsoft.Rest.ClientRuntime.Azure.dll</HintPath> | ||
| <HintPath>..\..\..\..\packages\Microsoft.Rest.ClientRuntime.Azure.3.3.12\lib\net452\Microsoft.Rest.ClientRuntime.Azure.dll</HintPath> |
There was a problem hiding this comment.
This looks like a downgrade.. I think i should revert back
There was a problem hiding this comment.
They are upgrading all the clientruntime versions in all packages. I think we want to make sure we stay with them.
| <Reference Include="Microsoft.WindowsAzure.Storage, Version=6.1.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL"> | ||
| <HintPath>..\..\..\..\packages\WindowsAzure.Storage.6.1.0\lib\net40\Microsoft.WindowsAzure.Storage.dll</HintPath> | ||
| <Reference Include="Microsoft.WindowsAzure.Storage, Version=8.6.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL"> | ||
| <HintPath>..\..\..\..\packages\WindowsAzure.Storage.8.6.0\lib\net45\Microsoft.WindowsAzure.Storage.dll</HintPath> |
There was a problem hiding this comment.
updating to 8.6.0 since, azure.storage 4.1.1 has this dependency
| <Link>Common\AzureStorageContext.cs</Link> | ||
| </Compile> | ||
| <Compile Include="..\..\..\..\Common\Commands.Common.Storage\Adapters\WindowsAzure.Storage.6\LazyAzureStorageContext.cs"> | ||
| <Compile Include="..\..\..\..\Common\Commands.Common.Storage\Adapters\WindowsAzure.Storage.8\LazyAzureStorageContext.cs"> |
There was a problem hiding this comment.
Updating the linked file references here, since we move on to 8.6.0 version of windowsazure.storage
| @@ -1,42 +1,26 @@ | |||
| // Copyright (c) Microsoft Corporation. All rights reserved. | |||
There was a problem hiding this comment.
Copied the 5.0.0-preview version of the SDK here
| @@ -46,5 +46,5 @@ | |||
| // You can specify all the values or you can default the Build and Revision Numbers | |||
| // by using the '*' as shown below: | |||
|
|
|||
| [assembly: AssemblyVersion("3.3.2")] | |||
| [assembly: AssemblyFileVersion("3.3.2")] | |||
| [assembly: AssemblyVersion("1.1.0")] | |||
There was a problem hiding this comment.
This looks like a downgrade..
There was a problem hiding this comment.
reverted back to 3.3.2, i dont think this needs to match the module version
| @@ -41,14 +41,6 @@ Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Commands.Storage", "Storage | |||
| EndProject | |||
| Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Commands.Management.Storage", "ResourceManager\Storage\Stack\Commands.Management.Storage\Commands.Management.Storage.csproj", "{A50AB133-5C04-4A17-9054-F8343683EC23}" | |||
| EndProject | |||
| Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "VhdManagement", "ResourceManager\Compute\Stack\VhdManagement\VhdManagement.csproj", "{80496B7B-068A-4A1E-B0BB-4B1FFF3FA616}" | |||
There was a problem hiding this comment.
Compute, network projects will be added it back with other PRs
| @@ -1,40 +0,0 @@ | |||
| --- | |||
There was a problem hiding this comment.
md files are getting removed, add it back from the version 1.1.0
Split SDK out into it's own project
|
Closing in favor of #7041 |
Description
AzureRM.Storage module version update to 2016-01-01
Copying Storage SDK version 5.0.0-preview
Corresponding cmdlet changes, redoing IStorageContext move and Common runtime move, Redoing HashTable[] to HashTable
references to 8.6.0 WindowsAzure.Storage.dll and dependent dlls update
Recorded test changes
Checklist
CONTRIBUTING.mdplatyPSmodule