Skip to content

New cmdlets to create/enter PSSession in remote container app. New cmdlet for getting container continuous deployment url #7231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from

Conversation

exc3eed
Copy link

@exc3eed exc3eed commented Sep 13, 2018

Description

https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/145

Checklist

@exc3eed exc3eed added the Ignite label Sep 13, 2018
@exc3eed exc3eed changed the title New cmdlets for windows container app to create and and enter remote PSSession for container app. New cmdlet for getting container continuous deployment url New cmdlets for windows container app to create/enter remote PSSession for container app. New cmdlet for getting container continuous deployment url Sep 13, 2018
@exc3eed exc3eed changed the title New cmdlets for windows container app to create/enter remote PSSession for container app. New cmdlet for getting container continuous deployment url New cmdlets for windows container app to create/enter PSSession in remote container app. New cmdlet for getting container continuous deployment url Sep 13, 2018
@exc3eed exc3eed changed the title New cmdlets for windows container app to create/enter PSSession in remote container app. New cmdlet for getting container continuous deployment url New cmdlets to create/enter PSSession in remote container app. New cmdlet for getting container continuous deployment url Sep 13, 2018
@MiYanni
Copy link
Contributor

MiYanni commented Sep 13, 2018

This looks like it is based on #7191. Meaning, they have the same history up to a point and then there are additions for the PR. I'll wait until that PR is merged to review this PR appropriately. Most of the file changes currently aren't related to the intent of this PR.

@maddieclayton maddieclayton changed the base branch from preview to release-2018-09-17 September 14, 2018 01:07
@exc3eed exc3eed force-pushed the asfarok-container-newcmdlets branch from 1b82bc5 to 70e9ab1 Compare September 14, 2018 08:23
@MiYanni
Copy link
Contributor

MiYanni commented Sep 14, 2018

@exc3eed Please merge in the latest from the release-2018-09-17 branch.

@maddieclayton maddieclayton changed the base branch from release-2018-09-17 to preview September 17, 2018 22:52
@cormacpayne
Copy link
Member

@exc3eed would you mind resolving the merge conflicts?

@MiYanni
Copy link
Contributor

MiYanni commented Sep 19, 2018

@panchagnula @Nking92 I believe @exc3eed is OOF. Do you have details on if this was supposed to be part of a preview release for Ignite?

@panchagnula
Copy link
Contributor

@jvano can you are someone from you team unblock this PR? thank you.

@vinisoto
Copy link
Contributor

@panchagnula @MiYanni @jvano I'm going to look into this. Since I cannot update Ashraf's fork, please expect a new PR from me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants