New cmdlets to create/enter PSSession in remote container app. New cmdlet for getting container continuous deployment url

[vinisoto]

Description

@panchagnula @jvano @MiYanni
This PR replaces this original PR: #7231 due to the original requestor being OOF.

Azure/azure-powershell-cmdlet-review-pr#145

Checklist

• I have read the Submitting Changes section of CONTRIBUTING.md
• The title of the PR is clear and informative
• The appropriate change log has been updated
• The PR does not introduce breaking changes
• If applicable, the changes made in the PR have proper test coverage
• For public API changes to cmdlets:
  • the changes have gone through a cmdlet design review
  • the cmdlet markdown files were generated using the platyPS module

[adxsdkps]

Can one of the admins verify this patch?

[MiYanni]

@vinisoto This PR would at least need to be building successfully by EoD today if it has a chance of getting into a preview module release for Ignite.

[MiYanni]

• Missing tests for Enter-AzureRmWebAppContainerPSSession and New-AzureRmWebAppContainerPSSession
  • The Enter cmdlet may not have a way to do tests. So, that may be fine to not have. The New cmdlet can definitely have tests.

[vinisoto]

@MiYanni yes. Working on it.

[vinisoto]

@MiYanni @panchagnula - Any clues on why this test doesn't find the new cmdlet during CI? It is passing locally:

[xUnit.net 00:00:21.87] Microsoft.Azure.Commands.Websites.Test.ScenarioTests.WebAppTests.TestEnableContainerContiniousDeploymentAndGetUrl [FAIL]
Failed Microsoft.Azure.Commands.Websites.Test.ScenarioTests.WebAppTests.TestEnableContainerContiniousDeploymentAndGetUrl
Error Message:
System.Management.Automation.CommandNotFoundException : The term 'Get-AzureRmWebAppContainerContinuousDeploymentUrl' is not recognized as the name of a cmdlet, function, script file, or operable program.
Check the spelling of the name, or if a path was included, verify that the path is correct and try again.
Stack Trace:
at System.Management.Automation.Runspaces.PipelineBase.Invoke(IEnumerable input)

[panchagnula]

@vinisoto - for all commands there is a file that maps the AzureRm command to the az command - have you updated this file? I don't remember the name of the file off the top of my head . I would recommend doing that instead of skipping the test - especially since this a new commandlet you are adding

[vinisoto]

@panchagnula - Thanks. Found it. Will try that

[vinisoto]

@MiYanni regarding tests for New-AzureRmWebAppContainerPSSession We can't write tests for it as it stands now since:

1. 1. It depends on having a WS-MAN client which may or may not be available in the build machine (there are some open source WS-MAN clients for Linux, but I'm not familiar with the exact configuration of the build machine)
2. Since it modifies the local machine WSMAN object, in most cases it needs to run elevated.

I propose that we we don't create a test for it right now until we come up with a way to test it properly. In any case, the underlying API (GetPublishingCredentials) that this cmdlet uses is already being tested by Get-AzureRMWebAppContainerContinuousDeploymentUrl

[vinisoto]

Adding this issue to track adding tests to New-AzureRmWebAppContainerPSSession

[MiYanni]

@azuresdkci Retest this please

[MiYanni]

@vinisoto You have static analysis failures to investigate.

[vinisoto]

Thanks @MiYanni. I addressed the static analysis failures.

[MiYanni]

@azuresdkci Retest this please

[vinisoto]

Looks like all the checks have passed now

[MiYanni]

@vinisoto The issue is, the main 2 cmdlets, New and Enter are not designed for your primary use case of running them in CloudShell. See the email thread for details.

[MiYanni]

@azuresdkci Retest this please

[MiYanni]

@azdevxps Retest this please

[vinisoto]

Looks like all checks have passed

[MiYanni]

• tools/AzureRM/AzureRM.psm1 should not be committed in this PR.

[MiYanni]

@vinisoto Also, this cmdlet will be part of the next AzureRM/Az release (10/05). Is that the intent?

[vinisoto]

Yes @MiYanni - we would like this cmdlet to be part of the next release.

[vinisoto]

@MiYanni would you mind kicking off retesting? (can I do it myself?)

[MiYanni]

@azuresdkci Retest this please

[vinisoto]

Thanks @MiYanni for your help and guidance