Adding -AzureStorageAccounts parameter to Set-AzureRmWebApp and Set-AzureRmWebAppSlot #7295

vinisoto · 2018-09-19T17:45:32Z

Description

Adding -AzureStorageAccounts parameter to Set-AzureRmWebApp and Set-AzureRmWebAppSlot to support "Bring your own storage" to Container-based web apps

Checklist

[x ] I have read the Submitting Changes section of CONTRIBUTING.md
[ x] The title of the PR is clear and informative
The appropriate change log has been updated
[x ] The PR does not introduce breaking changes
[ x] If applicable, the changes made in the PR have proper test coverage
[x ] For public API changes to cmdlets:
- the changes have gone through a cmdlet design review [design review open] (https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/166):
- [x ] the cmdlet markdown files were generated using the platyPS module

Description

Adding -AzureStorageAccounts parameter to Set-AzureRmWebApp and Set-AzureRmWebAppSlot to support "Bring your own storage" to Container-based web apps

Checklist

[x ] I have read the Submitting Changes section of CONTRIBUTING.md
[ x] The title of the PR is clear and informative
The appropriate change log has been updated
[x ] The PR does not introduce breaking changes
[ x] If applicable, the changes made in the PR have proper test coverage
[x ] For public API changes to cmdlets:
- the changes have gone through a cmdlet design review [design review open] (https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/166):
- [x ] the cmdlet markdown files were generated using the platyPS module

adxsdkps · 2018-09-19T17:46:22Z

Can one of the admins verify this patch?

vinisoto · 2018-09-19T17:46:25Z

@jvano. Who else need to review this? Thanks.

vinisoto · 2018-09-19T18:29:15Z

Hi! I opened a design review for this changes: https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/166

jvano

vinisoto · 2018-10-09T18:47:47Z

Hi @maddieclayton - I have submitted the changes as per the design review. However, looks like the Jenkins build is failing:

c:\workspace\powershell\src\packages\BuildTools.StyleCop.4.7.49.0\tools\StyleCop.targets(98,5): error MSB4062: The "StyleCopTask" task could not be loaded from the assembly c:\workspace\powershell\src\packages\BuildTools.StyleCop.4.7.49.0\tools\StyleCop.dll. Could not load file or assembly 'Microsoft.Build.Utilities.v3.5, Version=3.5.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' or one of its dependencies. The system cannot find the file specified. Confirm that the <UsingTask> declaration is correct, that the assembly and all its dependencies are available, and that the task contains a public class that implements Microsoft.Build.Framework.ITask. [c:\workspace\powershell\src\ServiceManagement\RecoveryServices\Commands.RecoveryServices\Commands.RecoveryServicesRdfe.csproj]

It doesn't seem related to my change but I might be wrong. Would you mind taking a look?

Thank you

src/ResourceManager/Websites/Commands.Websites/help/New-AzureRmWebAppAzureStoragePath.md

vinisoto · 2018-10-11T18:44:29Z

Hey @maddieclayton and @cormacpayne looks like all checks have passed.

maddieclayton · 2018-10-11T20:23:48Z

src/ResourceManager/Websites/Commands.Websites.Test/ScenarioTests/WebAppSlotTests.cs

@@ -122,5 +122,12 @@ public void TestWebAppSwapWithPreviewCompleteSlotSwap()
        {
            WebsitesController.NewInstance.RunPsTest(_logger, "Test-WebAppSwapWithPreviewCompleteSlotSwap");
        }
+
+        [Fact(Skip = "Currently the API fails when adding Azure Storage Accounts for slots. Will enable this test when the API is fixed")]


We can't merge this PR until the API is fixed

@maddieclayton - I will ping you once the API is fixed

@vinosoto still waiting for this change

maddieclayton · 2018-10-11T20:25:52Z

src/ResourceManager/Websites/Commands.Websites/ChangeLog.md

@@ -27,7 +28,6 @@
 * Updating to use the latest .NET SDK version (2.0.0)
 * Added two new cmdlets: Get-AzureRmDeletedWebApp and Restore-AzureRmDeletedWebApp
 * New-AzureRmAppServicePlan -HyperV switch is added for create app service plan with windows container
-* New-AzureRmWebApp/ New-AzureRmWebAppSlot/ Set-AzureRmWebApp/ Set-AzureRmWebAppSlot - New parameters (–ContainerRegistryUser string -ContainerRegistryPassword secureString -EnableContainerContinuousDeployment) added for creating and managing windows container app


Please add this line back in.

maddieclayton · 2018-10-11T20:32:15Z

...ourceManager/Websites/Commands.Websites/Validations/ValidateAzureStorageAccountsAttribute.cs

+
+namespace Microsoft.Azure.Commands.WebApps.Validations
+{
+    public class ValidateAzureStorageAccountsAttribute : ValidateArgumentsAttribute


do you still need this class?

maddieclayton · 2018-10-11T20:34:49Z

tools/AzureRM/AzureRM.psm1

@@ -1 +0,0 @@
-#placeholder


Please revert this change.

markcowl · 2018-10-24T22:52:49Z

@vinosoto We are still waiting on re-enabling the test. If this is not done by EOW, we will have to close this PR for lack of activity

vinisoto · 2018-10-29T17:58:15Z

@markcowl - the underlying API that this test uses will tentatively be updated on Nov 6th. Let's close this Pr and I will raise a new one once the API is updated. Thanks.

Vini Soto added 4 commits September 18, 2018 21:58

support byos for Windows containers

2a4acc9

Add Azure storage accounts to slots + Tests

cbb5a49

Help for support bring your own storage for Windows containers

caf7a4a

Updating change log

3648204

markcowl added the Cmdlet Review Required ⚠️ label Sep 19, 2018

azuresdkci1x added the needs-review label Sep 19, 2018

jvano previously approved these changes Sep 19, 2018

View reviewed changes

Vini Soto added 2 commits October 1, 2018 11:52

merging from preview

6eed2a0

removing AzureRM.psm1 from PR added by mistake

e1b9d0c

vinisoto dismissed jvano’s stale review via e1b9d0c October 1, 2018 18:53

Vini Soto added 4 commits October 1, 2018 14:39

Updating slot tests

8143019

Fixing Changelog entries

84d0ac4

Fixing static analysis and design review comments

fb91e63

Solving merge conflicts and getting latest from preview

1e90be6

maddieclayton added needs-revision Cmdlet Review Complete and removed Cmdlet Review Required ⚠️ needs-review labels Oct 8, 2018

maddieclayton assigned vinisoto Oct 8, 2018

Vini Soto added 5 commits October 8, 2018 21:38

Supporting Azure Storage Accounts (a.k.a. "bring your own storage")

0f8fa79

Getting latest from preview

9877475

Fixing Static Analysis issues

057cd15

Fixing Az alias

69100f9

Adding comments to specify why the slot test is skipped for now

2112ad7

Merge remote-tracking branch 'main/preview' into latest

6cda3b4

cormacpayne reviewed Oct 10, 2018

View reviewed changes

src/ResourceManager/Websites/Commands.Websites/help/New-AzureRmWebAppAzureStoragePath.md Outdated Show resolved Hide resolved

fixing changelog and markup file

d919632

maddieclayton suggested changes Oct 11, 2018

View reviewed changes

Vini Soto added 4 commits October 11, 2018 17:09

Merge remote-tracking branch 'main/preview' into latest

3be3982

Removing unused validation class and updating chengelog

951770d

undoing AzureRM.ps1 deletion

f896cb4

re-ignoring /tools/AzureRM/AzureRM.psm1

98b4298

vinisoto closed this Oct 29, 2018

vinisoto mentioned this pull request Nov 21, 2018

Adding -AzureStorageAccounts parameter to Set-AzureRmWebApp and Set-AzureRmWebAppSlot #7885

Merged

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Adding -AzureStorageAccounts parameter to Set-AzureRmWebApp and Set-AzureRmWebAppSlot #7295

Adding -AzureStorageAccounts parameter to Set-AzureRmWebApp and Set-AzureRmWebAppSlot #7295

Uh oh!

vinisoto commented Sep 19, 2018 •

edited

Loading

Uh oh!

adxsdkps commented Sep 19, 2018

Uh oh!

vinisoto commented Sep 19, 2018

Uh oh!

vinisoto commented Sep 19, 2018

Uh oh!

jvano left a comment

Uh oh!

vinisoto commented Oct 9, 2018

Uh oh!

Uh oh!

vinisoto commented Oct 11, 2018

Uh oh!

maddieclayton Oct 11, 2018

Uh oh!

vinisoto Oct 15, 2018

Uh oh!

markcowl Oct 24, 2018

Uh oh!

maddieclayton Oct 11, 2018

Uh oh!

maddieclayton Oct 11, 2018

Uh oh!

maddieclayton Oct 11, 2018

Uh oh!

markcowl commented Oct 24, 2018

Uh oh!

vinisoto commented Oct 29, 2018

Uh oh!

Uh oh!

		@@ -1 +0,0 @@
		#placeholder

Adding -AzureStorageAccounts parameter to Set-AzureRmWebApp and Set-AzureRmWebAppSlot #7295

Adding -AzureStorageAccounts parameter to Set-AzureRmWebApp and Set-AzureRmWebAppSlot #7295

Uh oh!

Conversation

vinisoto commented Sep 19, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Description

Checklist

Uh oh!

adxsdkps commented Sep 19, 2018

Uh oh!

vinisoto commented Sep 19, 2018

Uh oh!

vinisoto commented Sep 19, 2018

Uh oh!

jvano left a comment

Choose a reason for hiding this comment

Uh oh!

vinisoto commented Oct 9, 2018

Uh oh!

Uh oh!

vinisoto commented Oct 11, 2018

Uh oh!

maddieclayton Oct 11, 2018

Choose a reason for hiding this comment

Uh oh!

vinisoto Oct 15, 2018

Choose a reason for hiding this comment

Uh oh!

markcowl Oct 24, 2018

Choose a reason for hiding this comment

Uh oh!

maddieclayton Oct 11, 2018

Choose a reason for hiding this comment

Uh oh!

maddieclayton Oct 11, 2018

Choose a reason for hiding this comment

Uh oh!

maddieclayton Oct 11, 2018

Choose a reason for hiding this comment

Uh oh!

markcowl commented Oct 24, 2018

Uh oh!

vinisoto commented Oct 29, 2018

Uh oh!

Uh oh!

vinisoto commented Sep 19, 2018 •

edited

Loading