Adding -AzureStorageAccounts parameter to Set-AzureRmWebApp and Set-AzureRmWebAppSlot #7885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 23 commits
September 18, 2018 21:58
…app and Linux webapps
|
Disabled tests have now been enabled. |
cormacpayne
suggested changes
Nov 21, 2018
There was a problem hiding this comment.
@vinisoto a few minor comments to take a look at, otherwise LGTM
| @@ -0,0 +1,52 @@ | |||
| using Microsoft.Azure.Commands.WebApps.Models; | |||
There was a problem hiding this comment.
@vinisoto please add a license header to this file
| @@ -0,0 +1,24 @@ | |||
| using Microsoft.Azure.Management.WebSites.Models; | |||
There was a problem hiding this comment.
@vinisoto please add a license header to this file
|
|
||
| namespace Microsoft.Azure.Commands.WebApps.Cmdlets.WebApps | ||
| { | ||
| [Cmdlet("New", ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "WebAppAzureStoragePath", SupportsShouldProcess = true), OutputType(typeof(WebAppAzureStoragePath))] |
There was a problem hiding this comment.
@vinisoto instead of "New", please use VerbsCommon.New
|
|
||
| namespace Microsoft.Azure.Commands.WebApps.Cmdlets.WebApps | ||
| { | ||
| [Cmdlet("New", ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "WebAppAzureStoragePath", SupportsShouldProcess = true), OutputType(typeof(WebAppAzureStoragePath))] |
There was a problem hiding this comment.
@vinisoto as a note, it's not necessary to support ShouldProcess in this scenario since you are creating an in-memory object, but it doesn't hurt to have it supported 😀
|
Thanks @cormacpayne. I addressed the requested changes. |
cormacpayne
approved these changes
Nov 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Re-submitting #7295
Design review has been approved: Azure/azure-powershell-cmdlet-review-pr#166
Adding -AzureStorageAccounts parameter to Set-AzureRmWebApp and Set-AzureRmWebAppSlot to support "Bring your own storage" to Container-based web apps
Checklist
CONTRIBUTING.mdplatyPSmodule