Microsoft.StorageSync - Adding Cmdlets to Az.StorageSync module #8465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ase. Remove tests deriving of test controller base. Used updated test controller from master with slight modifications.
StorageSync test runner fix
…quired clients to test controller.
Removed multi SDK dependency, added required clients to test controller
…to Az-StorageSync-v5-try1
…to Az-StorageSync-v5-try1
…to Az-StorageSync-v5-try1
…to Az-StorageSync-v5-try1
�[?1h�=�[39;49m�[31m/home/travis/build/Azure/azure-powershell/build.proj(405,5): error MSB3030: Could not copy the file "/home/travis/build/Azure/azure-powershell/src/**/TestResults/*.trx" because it was not found. �[39;49m�[39;49m�[31m/home/travis/build/Azure/azure-powershell/build.proj(411,5): error : Test failures occured, check the files in artifacts/Test
markcowl
requested changes
Feb 11, 2019
There was a problem hiding this comment.
There is quite a bit of code, and looks like soem native code in this PR that should really be part of a .Net client-side SDK. It would be good if we could get the signoff from another dev on the StorageSync team for the partf of this code that perform native api calls.
Other comments inline.
src/StorageSync/StorageSync/help/Unregister-AzStorageSyncServer.md
Outdated
Show resolved
Hide resolved
src/StorageSync/StorageSync/ServerEndpoint/InvokeStorageSyncFileRecallCommand.cs
Show resolved
Hide resolved
src/StorageSync/StorageSync/RegisteredServer/RegisterServerCommand.cs
Outdated
Show resolved
Hide resolved
src/StorageSync/StorageSync/Common/ArgumentCompleters/StorageSyncServiceCompleterAttribute.cs
Outdated
Show resolved
Hide resolved
| ## Upcoming Release | ||
|
|
||
| ## Version 0.7.1 | ||
| ## Current Release |
There was a problem hiding this comment.
Please bring this up to date - your changes should just be under Current Release
There was a problem hiding this comment.
…to Az-StorageSync-v5-try1
…dlish2/azure-powershell into Az-StorageSync-v5-try1
dlets... :USERPROFILE : The term ':USERPROFILE' is not recognized as the name of a cmdlet, function, script file, or operable program. Check the spelling of the name, or if a path was included, verify that the path is correct and try again. At line:1 char:31 + Remove-Item -Path (Join-Path (:USERPROFILE) .nuget packages) -Recurse ... + ~~~~~~~~~~~~ + CategoryInfo : ObjectNotFound: (:USERPROFILE:String) [], CommandNotFoundException mandNotFoundException Remove-Item : Cannot convert 'System.String' to the type 'System.Management.Automation.SwitchParameter' required by parameter 'Confirm'. At line:1 char:97 + ... re-powershell/artifacts -Recurse -Force -Confirm: -ErrorAction Ignore + ~~~~~~~~~~~~ + CategoryInfo : InvalidArgument: (:) [Remove-Item], ParameterBindingException + FullyQualifiedErrorId : CannotConvertArgument,Microsoft.PowerShell.Commands.RemoveItemCommand ove-Item : Cannot convert 'System.String' to the type 'System.Management.Automation.SwitchParameter' required by parameter 'Confirm'. At line:1 char:148 + ... tResults' | Remove-Item -Recurse -Force -Confirm: -ErrorAction Ignore + ~~~~~~~~~~~~ + CategoryInfo : InvalidArgument: (:) [Remove-Item], ParameterBindingException + FullyQualifiedErrorId : CannotConvertArgument,Microsoft.PowerShell.Commands.RemoveItemCommand
|
Moved to new PR with less commit history : #8527 |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a change prepared against the design issue Az Powershell design issue
Checklist
CONTRIBUTING.mdplatyPSmodule