Add Az.StorageSync Cmdlets supported by Microsoft.StorageSync RP - v5 version #8527

ankushbindlish2 · 2019-02-13T08:16:27Z

Description

This is a change prepared against the design issue Az Powershell design issue

Checklist

ankushbindlish2 · 2019-02-13T21:26:38Z

Old PR : #8465

ankushbindlish2 · 2019-02-13T21:28:34Z

Mark thinks that COM interaction should be in client SDK.
We want c# sdk to be generated from swagger as it is today. COM interaction is a special client only interaction and we will prefer to reside the code in powershell cmdlet code.

[Won't Fix]

ankushbindlish2 · 2019-02-13T21:29:14Z

[Mark] : would be good if we could get the signoff from another dev on the StorageSync team
Added Kristian from our team.

kszobi · 2019-02-13T21:45:17Z

public interface IEcsManagement : IDisposable

CR signed off #Closed

Refers to: src/StorageSync/StorageSync/Interop/Interfaces/IEcsManagement.cs:24 in 7b8b40f. [](commit_id = 7b8b40f, deletion_comment = False)

kszobi · 2019-02-13T21:45:27Z

public interface INetworkLimitConfigEntry

CR signed off #Closed

Refers to: src/StorageSync/StorageSync/Interop/Interfaces/INetworkLimitConfigEntry.cs:23 in 7b8b40f. [](commit_id = 7b8b40f, deletion_comment = False)

kszobi · 2019-02-13T21:45:36Z

public interface INetworkLimitConfigurationEntryEnumeration

CR signed off #Closed

Refers to: src/StorageSync/StorageSync/Interop/Interfaces/INetworkLimitConfigurationEntryEnumeration.cs:27 in 7b8b40f. [](commit_id = 7b8b40f, deletion_comment = False)

kszobi · 2019-02-13T21:45:43Z

public interface ISyncServerRegistration : IDisposable

CR signed off #Closed

Refers to: src/StorageSync/StorageSync/Interop/Interfaces/ISyncServerRegistration.cs:24 in 7b8b40f. [](commit_id = 7b8b40f, deletion_comment = False)

kszobi · 2019-02-13T21:46:35Z

public class Win32Helper

CR signed off #Closed

Refers to: src/StorageSync/StorageSync/Interop/Helpers/Win32Helper.cs:24 in 7b8b40f. [](commit_id = 7b8b40f, deletion_comment = False)

kszobi · 2019-02-13T21:52:37Z

public class ManagementInteropConstants

CR signed off #Resolved

Refers to: src/StorageSync/StorageSync/Interop/Helpers/ManagementInteropConstants.cs:21 in 7b8b40f. [](commit_id = 7b8b40f, deletion_comment = False)

kszobi · 2019-02-13T21:52:43Z

public sealed class ServerRegistrationException : Exception

CR signed off #Closed

Refers to: src/StorageSync/StorageSync/Interop/Exceptions/ServerRegistrationException.cs:24 in 7b8b40f. [](commit_id = 7b8b40f, deletion_comment = False)

kszobi · 2019-02-13T21:53:22Z

public enum ServerRegistrationErrorCode

CR signed off #Closed

Refers to: src/StorageSync/StorageSync/Interop/Enums/ServerRegistrationErrorCode.cs:17 in 7b8b40f. [](commit_id = 7b8b40f, deletion_comment = False)

kszobi · 2019-02-13T21:53:26Z

public enum ScrubbingMode

CR signed off #Closed

Refers to: src/StorageSync/StorageSync/Interop/Enums/ScrubbingMode.cs:17 in 7b8b40f. [](commit_id = 7b8b40f, deletion_comment = False)

kszobi · 2019-02-13T21:53:35Z

public enum RpcImpLevel

CR signed off #Closed

Refers to: src/StorageSync/StorageSync/Interop/Enums/RpcImpLevel.cs:17 in 7b8b40f. [](commit_id = 7b8b40f, deletion_comment = False)

kszobi · 2019-02-13T21:53:38Z

public enum RpcAuthnLevel

CR signed off #Closed

Refers to: src/StorageSync/StorageSync/Interop/Enums/RpcAuthnLevel.cs:17 in 7b8b40f. [](commit_id = 7b8b40f, deletion_comment = False)

kszobi · 2019-02-13T21:53:43Z

public enum RecallResult

CR signed off #Closed

Refers to: src/StorageSync/StorageSync/Interop/Enums/RecallResult.cs:20 in 7b8b40f. [](commit_id = 7b8b40f, deletion_comment = False)

kszobi · 2019-02-13T21:53:47Z

public enum OleAuthCapabilities

CR signed off #Closed

Refers to: src/StorageSync/StorageSync/Interop/Enums/OleAuthCapabilities.cs:20 in 7b8b40f. [](commit_id = 7b8b40f, deletion_comment = False)

kszobi · 2019-02-13T21:53:53Z

public enum GarbageCollectionMode : UInt32

CR signed off #Closed

Refers to: src/StorageSync/StorageSync/Interop/Enums/GarbageCollectionMode.cs:20 in 7b8b40f. [](commit_id = 7b8b40f, deletion_comment = False)

kszobi · 2019-02-13T21:53:58Z

public enum EoAuthnCap

CR signed off #Closed

Refers to: src/StorageSync/StorageSync/Interop/Enums/EoAuthnCap.cs:24 in 7b8b40f. [](commit_id = 7b8b40f, deletion_comment = False)

kszobi · 2019-02-13T21:54:05Z

public enum EFileShare : uint

CR signed off #Closed

Refers to: src/StorageSync/StorageSync/Interop/Enums/EFileShare.cs:22 in 7b8b40f. [](commit_id = 7b8b40f, deletion_comment = False)

Remove Test code Add help content Add xml comments Re-Record

…azure-powershell into storage-sync2

Update StorageSync PR

…to Az-StorageSync-v5-Final

markcowl

I noted some places where resource strings were still needed, and a few places where the default parameters et needed to be changed. Also, there are a couple of depdnencies on test code in the cmdlets that should be removed.

markcowl · 2019-02-25T19:54:58Z

build.proj

@@ -49,19 +49,18 @@
    <LibrarySourceFolder>$(LibraryRoot)src</LibrarySourceFolder>
    <LibraryToolsFolder>$(LibraryRoot)tools</LibraryToolsFolder>
    <LibraryArtifactsFolder>$(LibraryRoot)artifacts</LibraryArtifactsFolder>
-    <LocalFeedFolder>$(LibraryToolsFolder)\LocalFeed</LocalFeedFolder>
-    <Configuration Condition=" '$(Configuration)' != 'Release'">Debug</Configuration>
+    <LocalFeedFolder>$(LibraryToolsFolder)/LocalFeed</LocalFeedFolder>    <Configuration Condition=" '$(Configuration)' != 'Release'">Debug</Configuration>


fix line ending (note: this could be an issue with my PR, but please fix)

This line still needs to be fixed

tools/StaticAnalysis/Exceptions/Az.StorageSync/SignatureIssues.csv

src/StorageSync/StorageSync.Test/Common/MockStorageSyncResourceManager.cs

src/StorageSync/StorageSync/ServerEndpoint/InvokeStorageSyncFileRecallCommand.cs

src/StorageSync/StorageSync/ServerEndpoint/RemoveServerEndpointCommand.cs

src/StorageSync/StorageSync/StorageSyncService/RemoveStorageSyncServiceCommand.cs

tools/StaticAnalysis/Program.cs

src/StorageSync/StorageSync/Interfaces/IStorageSyncResourceManager.cs

Fixing issue with wildcard expansion with long paths

markcowl · 2019-02-26T20:51:54Z

build.proj

@@ -49,19 +49,18 @@
    <LibrarySourceFolder>$(LibraryRoot)src</LibrarySourceFolder>
    <LibraryToolsFolder>$(LibraryRoot)tools</LibraryToolsFolder>
    <LibraryArtifactsFolder>$(LibraryRoot)artifacts</LibraryArtifactsFolder>
-    <LocalFeedFolder>$(LibraryToolsFolder)\LocalFeed</LocalFeedFolder>
-    <Configuration Condition=" '$(Configuration)' != 'Release'">Debug</Configuration>
+    <LocalFeedFolder>$(LibraryToolsFolder)/LocalFeed</LocalFeedFolder>    <Configuration Condition=" '$(Configuration)' != 'Release'">Debug</Configuration>


This line still needs to be fixed

ankushbindlish2 added 2 commits February 13, 2019 00:11

Add StorageSync Cmdlets

67d85e9

StorageSync Cmdlets

7b8b40f

ankushbindlish2 requested review from MiYanni and cormacpayne February 13, 2019 08:16

ankushbindlish2 mentioned this pull request Feb 13, 2019

Microsoft.StorageSync - Adding Cmdlets to Az.StorageSync module #8465

Closed

9 tasks

azuresdkci added the needs-review label Feb 13, 2019

maddieclayton assigned markcowl Feb 13, 2019

ankushbindlish2 requested a review from kszobi February 13, 2019 19:05

Merge branch 'master' into Az-StorageSync-v5-Final

f9d5dc2

ankushbindlish2 requested a review from markcowl February 13, 2019 21:24

Update ChangeLog.md

6c69d09

maddieclayton added the Preview label Feb 20, 2019

ankushbindlish2 and others added 11 commits February 21, 2019 11:03

Review Comments Incorporation

a09e52b

Remove Test code Add help content Add xml comments Re-Record

Remove OfflineDataTransferShareName from Set-SEP

36e1942

Fix issu of having new mock object for each test

19a60bb

Fix Tenant bug for Graph Client

e321aab

Add additional framework extension assemblies for StorageSync support

bb215ee

Change load ordering

b6fcd49

Merging with upstream

61f3940

Merge branch 'Az-StorageSync-v5-Final' of github.com:ankushbindlish2/…

3ab1abe

…azure-powershell into storage-sync2

Update logs to ensure each cmdlet uses Win32registry

00be931

Merge pull request #3 from markcowl/storage-sync2

dbe0293

Update StorageSync PR

Merge branch 'master' of https://github.com/Azure/azure-powershell in…

af69379

…to Az-StorageSync-v5-Final

ankushbindlish2 requested a review from markcowl February 25, 2019 19:53

markcowl requested changes Feb 25, 2019

View reviewed changes

markcowl added needs-revision and removed needs-review labels Feb 25, 2019

markcowl assigned ankushbindlish2 and unassigned markcowl Feb 25, 2019

ankushbindlish2 and others added 4 commits February 25, 2019 15:23

Update Program.cs

4c70412

Fixing issue with wildcard expansion with long paths

6b1b894

Merge pull request #4 from markcowl/storage-sync3

4aaf2ff

Fixing issue with wildcard expansion with long paths

Review Comments

7e8cd89

ankushbindlish2 requested a review from markcowl February 26, 2019 00:12

ankushbindlish2 added 2 commits February 25, 2019 23:44

review comments

c2ca53f

Update StorageSyncConstants.cs

d9cd366

markcowl requested changes Feb 26, 2019

View reviewed changes

Update build.proj

b6d4314

ankushbindlish2 requested a review from markcowl February 26, 2019 21:42

markcowl approved these changes Feb 26, 2019

View reviewed changes

markcowl merged commit 7b55679 into Azure:master Feb 26, 2019

Add Az.StorageSync Cmdlets supported by Microsoft.StorageSync RP - v5 version #8527

Add Az.StorageSync Cmdlets supported by Microsoft.StorageSync RP - v5 version #8527

Uh oh!

Conversation

ankushbindlish2 commented Feb 13, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Uh oh!

ankushbindlish2 commented Feb 13, 2019

Uh oh!

ankushbindlish2 commented Feb 13, 2019

Uh oh!

ankushbindlish2 commented Feb 13, 2019

Uh oh!

kszobi commented Feb 13, 2019 • edited by ankushbindlish2 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kszobi commented Feb 13, 2019 • edited by ankushbindlish2 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kszobi commented Feb 13, 2019 • edited by ankushbindlish2 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kszobi commented Feb 13, 2019 • edited by ankushbindlish2 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kszobi commented Feb 13, 2019 • edited by ankushbindlish2 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kszobi commented Feb 13, 2019 • edited by ankushbindlish2 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kszobi commented Feb 13, 2019 • edited by ankushbindlish2 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kszobi commented Feb 13, 2019 • edited by ankushbindlish2 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kszobi commented Feb 13, 2019 • edited by ankushbindlish2 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kszobi commented Feb 13, 2019 • edited by ankushbindlish2 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kszobi commented Feb 13, 2019 • edited by ankushbindlish2 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kszobi commented Feb 13, 2019 • edited by ankushbindlish2 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kszobi commented Feb 13, 2019 • edited by ankushbindlish2 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kszobi commented Feb 13, 2019 • edited by ankushbindlish2 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kszobi commented Feb 13, 2019 • edited by ankushbindlish2 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kszobi commented Feb 13, 2019 • edited by ankushbindlish2 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

markcowl left a comment

Choose a reason for hiding this comment

Uh oh!

markcowl Feb 25, 2019

Choose a reason for hiding this comment

Uh oh!

markcowl Feb 26, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ankushbindlish2 commented Feb 13, 2019 •

edited

Loading

kszobi commented Feb 13, 2019 •

edited by ankushbindlish2

Loading

kszobi commented Feb 13, 2019 •

edited by ankushbindlish2

Loading

kszobi commented Feb 13, 2019 •

edited by ankushbindlish2

Loading

kszobi commented Feb 13, 2019 •

edited by ankushbindlish2

Loading

kszobi commented Feb 13, 2019 •

edited by ankushbindlish2

Loading

kszobi commented Feb 13, 2019 •

edited by ankushbindlish2

Loading

kszobi commented Feb 13, 2019 •

edited by ankushbindlish2

Loading

kszobi commented Feb 13, 2019 •

edited by ankushbindlish2

Loading

kszobi commented Feb 13, 2019 •

edited by ankushbindlish2

Loading

kszobi commented Feb 13, 2019 •

edited by ankushbindlish2

Loading

kszobi commented Feb 13, 2019 •

edited by ankushbindlish2

Loading

kszobi commented Feb 13, 2019 •

edited by ankushbindlish2

Loading

kszobi commented Feb 13, 2019 •

edited by ankushbindlish2

Loading

kszobi commented Feb 13, 2019 •

edited by ankushbindlish2

Loading

kszobi commented Feb 13, 2019 •

edited by ankushbindlish2

Loading

kszobi commented Feb 13, 2019 •

edited by ankushbindlish2

Loading