Skip to content

Update permissive record matcher to allow ignoring api versions at resource type level. #9705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Update permissive record matcher to allow ignoring api versions at resource type level. #9705

wants to merge 3 commits into from

Conversation

johnpaulkee
Copy link
Contributor

Description

  • Bump Management.Azure.Management.Sql to 1.33.0-preview
  • Ignore Microsoft.Sql api versions
  • Fix PermissiveRecordMatcherWithApiExclusion uri escaping

Checklist

Update permissive record matcher, fix recording of TestGetManagedData…
9dcd58d 
…baseGeoBackup.json, ignore api versions for Microsoft.Sql, and bump Microsoft.Azure.Management.Sql version to 1.33.0-preview
@adxsdkps
Copy link
Collaborator

Can one of the admins verify this patch?

@pixia pixia self-assigned this Jul 23, 2019
pixia
pixia previously approved these changes Jul 23, 2019
View reviewed changes
markcowl
markcowl requested changes Jul 23, 2019
View reviewed changes
johnpaulkee
johnpaulkee commented Jul 24, 2019
View reviewed changes
src/Sql/Sql.Test/ScenarioTests/ManagedInstanceCrudScenarioTests.cs
@@ -33,6 +33,7 @@ protected override void SetupManagementClients(RestTestFramework.MockContext con

public ManagedInstanceCrudScenarioTests(ITestOutputHelper output) : base(output)
{
base.resourceTypesToIgnoreApiVersion = new string[] { "Microsoft.Sql/managedInstances" };
Copy link
Contributor Author

@johnpaulkee johnpaulkee Jul 24, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will have new recordings as it's a top level resource test - this is stubbed here to test build.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/329, I've added some new recordings that verifying server level communication with 2018-06-01-preview against managedInstances works after api version bump.

johnpaulkee
johnpaulkee commented Jul 24, 2019
View reviewed changes
@johnpaulkee johnpaulkee changed the title Update permissive record matcher, fix recording of TestGetManagedData… Update permissive record matcher to allow ignoring api versions at resource type level. Jul 24, 2019
@johnpaulkee
Copy link
Contributor Author

Friendly ping @markcowl on updated review.
Understood that review still requires new recordings for managed instance, but wanted thoughts on api exclusion per resource type.

@johnpaulkee
Copy link
Contributor Author

Friendly ping @markcowl

@cormacpayne cormacpayne assigned markcowl and cormacpayne and unassigned pixia Jul 29, 2019
@johnpaulkee johnpaulkee mentioned this pull request Jul 30, 2019
Merged
8 tasks
cormacpayne
cormacpayne suggested changes Jul 31, 2019
View reviewed changes
@johnpaulkee
Copy link
Contributor Author

Closing this PR and continuing updates in #9744

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markcowl markcowl markcowl requested changes

@cormacpayne cormacpayne cormacpayne requested changes

@pixia pixia pixia left review comments

Assignees

@markcowl markcowl

@cormacpayne cormacpayne

Labels
needs-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@johnpaulkee @adxsdkps @markcowl @cormacpayne @pixia @azuresdkci