Add instance pool, instance pool usages cmdlets, and update managed instance cmdlets to support instance pools. #9744
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
July 22, 2019 17:47
…baseGeoBackup.json, ignore api versions for Microsoft.Sql, and bump Microsoft.Azure.Management.Sql version to 1.33.0-preview
… pool tests, instance pool usages tests
…to instancePoolsMaster
|
Can one of the admins verify this patch? |
johnpaulkee
assigned
markcowl,
cormacpayne and
johnpaulkee and unassigned
markcowl and
cormacpayne
…ssed unless using common helper
cormacpayne
suggested changes
Jul 30, 2019
| @@ -32,6 +33,9 @@ protected override void SetupManagementClients(RestTestFramework.MockContext con | |||
|
|
|||
| public AdvancedDataSecurityManagedInstanceTests(ITestOutputHelper output) : base(output) | |||
| { | |||
| base.resourceTypesToIgnoreApiVersion = new string[] { | |||
There was a problem hiding this comment.
@johnpaulkee TBD on this change 😁
| @@ -0,0 +1,74 @@ | |||
| using Microsoft.WindowsAzure.Commands.ScenarioTest; | |||
There was a problem hiding this comment.
@johnpaulkee TBD on this file 😁
There was a problem hiding this comment.
Acked 👍 I'm hoping we can come to a solution sometime this week.
added 4 commits
July 30, 2019 10:01
added 8 commits
July 30, 2019 11:18
This was referenced Jul 31, 2019
|
Friendly ping to @markcowl to help take a look at the permissive record matcher changes when possible. We're really trying to catch the 8/5 code completion date for release by 8/13 and also to unblock the other SQL folks for the failing MI tests due to version bump. |
…atcher with resource api exclusion and update sql tests to use that new matcher for safety
cormacpayne
approved these changes
Aug 5, 2019
|
thank you @cormacpayne and @markcowl for reviewing and merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds cmdlets for Azure SQL Instance pools, Instance pool usages, and updates existing managed instance cmdlets to support placement of an instance within an instance pool.
Design review:
https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/329
Related pull request:
#9705
Checklist
CONTRIBUTING.mdplatyPSmodule