Skip to content

Fix a malfunction in yesterday's acquire_token_interactive() PR #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 4, 2020
Merged

Fix a malfunction in yesterday's acquire_token_interactive() PR #282

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions msal/application.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1059,9 +1059,11 @@ def acquire_token_interactive(
port=port or 0),
prompt=prompt,
login_hint=login_hint,
domain_hint=domain_hint,
timeout=timeout,
auth_params={"claims": claims},
auth_params={
"claims": claims,
"domain_hint": domain_hint,
},
data=dict(kwargs.pop("data", {}), claims=claims),
headers={
CLIENT_REQUEST_ID: _get_new_correlation_id(),
Expand Down
2 changes: 2 additions & 0 deletions tests/http_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,13 @@ def __init__(self, verify=True, proxies=None, timeout=None):
self.timeout = timeout

def post(self, url, params=None, data=None, headers=None, **kwargs):
assert not kwargs, "Our stack shouldn't leak extra kwargs: %s" % kwargs
return MinimalResponse(requests_resp=self.session.post(
url, params=params, data=data, headers=headers,
timeout=self.timeout))

def get(self, url, params=None, headers=None, **kwargs):
assert not kwargs, "Our stack shouldn't leak extra kwargs: %s" % kwargs
return MinimalResponse(requests_resp=self.session.get(
url, params=params, headers=headers, timeout=self.timeout))

Expand Down