Update the default broker redirect URI to be a valid URI #673
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgavrilMS
approved these changes
Mar 1, 2024
Ray: I tested it on his Win laptop to successfully acquire normal token and ssh cert from broker
rayluo
force-pushed
the
iulico/update-broker-default-redirect-uri
branch
from
7a5f3e1 to
c73b7ca
Compare
rayluo
approved these changes
Mar 6, 2024
There was a problem hiding this comment.
Note: Later when we need to merge in the mac branch, we will do it this way.
if running_on_mac:
uri = "msauth.com.msauth.unsignedapp://auth"
else:
uri = "https://login.microsoftonline.com/common/oauth2/nativeclient" # Came from https://learn.microsoft.com/en-us/entra/identity-platform/v2-oauth2-auth-code-flow#request-an-authorization-codeAnd then MSALRuntime will also decide whether to honor the MSAL.py request based on the current platform.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSAL.cpp fixed the URI parsing logic to not allow invalid URIs which causes the default redirect URI to not be properly set when calling MSAL.runtime. This caused the sev2 ICM with azcli.
Chaning the default to be the default RU for native clients: https://login.microsoftonline.com/common/oauth2/nativeclient