Skip to content

Increase code coverage #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 25, 2019
Merged

Conversation

smyrick
Copy link
Contributor

@smyrick smyrick commented Sep 25, 2019

📝 Description

Update the code coverage levels with more unit tests and update the maven settings to exclude the examples in the Jacoco reports

@smyrick smyrick added the type: documentation Documentation or test changes label Sep 25, 2019
@smyrick smyrick changed the title Code coverage Increase code coverage Sep 25, 2019
@codecov-io
Copy link

codecov-io commented Sep 25, 2019

Codecov Report

Merging #376 into master will increase coverage by 17.53%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             master     #376       +/-   ##
=============================================
+ Coverage     78.23%   95.76%   +17.53%     
- Complexity      341      347        +6     
=============================================
  Files           132       98       -34     
  Lines          1470     1205      -265     
  Branches        236      213       -23     
=============================================
+ Hits           1150     1154        +4     
+ Misses          277       11      -266     
+ Partials         43       40        -3
Impacted Files Coverage Δ Complexity Δ
.../graphql/spring/execution/GraphQLContextFactory.kt 50% <0%> (-50%) 0% <0%> (ø)
.../graphql/sample/context/MyGraphQLContextFactory.kt
.../sample/directives/CustomDirectiveWiringFactory.kt
...e/datafetchers/CustomDataFetcherFactoryProvider.kt
...ample/directives/LowercaseSchemaDirectiveWiring.kt
...ediagroup/graphql/sample/query/EnvironmentQuery.kt
...diagroup/graphql/sample/mutation/WidgetMutation.kt
...le/exceptions/CustomDataFetcherExceptionHandler.kt
...in/com/expediagroup/graphql/sample/model/Animal.kt
...expediagroup/graphql/sample/query/DataAndErrors.kt
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfbd1a9...013fc4f. Read the comment docs.

@@ -200,6 +200,11 @@
<groupId>org.jacoco</groupId>
<artifactId>jacoco-maven-plugin</artifactId>
<version>${jacoco-maven-plugin.version}</version>
<configuration>
<excludes>
<exclude>**/*com/expediagroup/graphql/sample/**</exclude>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

outside of this PR but maybe we should rename sample package to example?

@dariuszkuc dariuszkuc merged commit 7f2214c into ExpediaGroup:master Sep 25, 2019
@smyrick smyrick deleted the code-coverage branch September 25, 2019 14:18
@smyrick smyrick mentioned this pull request Sep 25, 2019
dariuszkuc pushed a commit to dariuszkuc/graphql-kotlin that referenced this pull request Aug 5, 2022
* Increase code coverage

* Update jacoco config to exclude examples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation Documentation or test changes
Development

Successfully merging this pull request may close these issues.

3 participants