Skip to content

Rename examples package #380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 25, 2019

Conversation

smyrick
Copy link
Contributor

@smyrick smyrick commented Sep 25, 2019

📝 Description

Rename the package from com.expediagroup.graphql.sample to com.expediagroup.graphql.examples to match directory name

Test changes only

🔗 Related Issues

#376 (comment)

Rename the package from com.expediagroup.graphql.sample to com.expediagroup.graphql.examples to match directory name
@smyrick smyrick added the type: documentation Documentation or test changes label Sep 25, 2019
@@ -202,7 +202,7 @@
<version>${jacoco-maven-plugin.version}</version>
<configuration>
<excludes>
<exclude>**/*com/expediagroup/graphql/sample/**</exclude>
<exclude>**/com/expediagroup/graphql/examples/**</exclude>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also updating the jacoco config: #376 (comment)

@codecov-io
Copy link

codecov-io commented Sep 25, 2019

Codecov Report

Merging #380 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #380   +/-   ##
=========================================
  Coverage     97.75%   97.75%           
  Complexity      316      316           
=========================================
  Files           103      103           
  Lines          1203     1203           
  Branches        198      198           
=========================================
  Hits           1176     1176           
  Misses            8        8           
  Partials         19       19

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c97eab8...90b607f. Read the comment docs.

@smyrick smyrick merged commit 51b9cab into ExpediaGroup:master Sep 25, 2019
@smyrick smyrick deleted the rename-examples-package branch September 25, 2019 22:50
dariuszkuc pushed a commit to dariuszkuc/graphql-kotlin that referenced this pull request Aug 5, 2022
Rename the package from com.expediagroup.graphql.sample to com.expediagroup.graphql.examples to match directory name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation Documentation or test changes
Development

Successfully merging this pull request may close these issues.

3 participants